From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: muhammad.husaini.zulkifli@intel.com,
Adrian Hunter <adrian.hunter@intel.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
lakshmi.bai.raja.subramanian@intel.com,
Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3 1/2] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC
Date: Wed, 7 Oct 2020 11:55:34 +0300 [thread overview]
Message-ID: <CAHp75VfXe=dwbNEdUfwmMnZCkSTRH_6HjGD0MUs=GY0en4f0sw@mail.gmail.com> (raw)
In-Reply-To: <49c9fe27-ee82-f490-482b-365101d3b6cf@xilinx.com>
On Wed, Oct 7, 2020 at 11:38 AM Michal Simek <michal.simek@xilinx.com> wrote:
> On 06. 10. 20 17:55, muhammad.husaini.zulkifli@intel.com wrote:
...
> > + /*
> > + * This is like final gatekeeper. Need to ensure changed voltage
like a final
> > + * is settled before and after turn on this bit.
> > + */
...
> > + /*
> > + * This is like final gatekeeper. Need to ensure changed voltage
Likewise.
> > + * is settled before and after turn on this bit.
> > + */
...
> > + struct device *dev = &pdev->dev;
>
> nit: I got this but as I see 3 lines below maybe would be better to use
> it everywhere but it can be done in separate patch.
In that case I think it would be better to have that patch first. It
make follow up code cleaner.
...
> > + if (of_device_is_compatible(np, "intel,keembay-sdhci-5.1-sd")) {
> > + struct gpio_desc *uhs;
> > +
> > + uhs = devm_gpiod_get_optional(dev, "uhs", GPIOD_OUT_HIGH);
>
> I can't see change in dt binding to record uhs gpio.
>
>
> Better
> sdhci_arasan->uhs_gpio = devm_gpiod_get_optional(dev, "uhs",
> GPIOD_OUT_HIGH);
>
> then you can avoid uhs variable.
Actually it's readability vs. additional variable. It was my
suggestion to have a variable to make readability better.
Are you insisting on this change?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-07 8:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 15:55 [PATCH v3 0/2] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC muhammad.husaini.zulkifli
2020-10-06 15:55 ` [PATCH v3 1/2] " muhammad.husaini.zulkifli
2020-10-07 8:33 ` Michal Simek
2020-10-07 8:55 ` Andy Shevchenko [this message]
2020-10-07 9:10 ` Michal Simek
2020-10-07 12:08 ` Andy Shevchenko
2020-10-07 13:28 ` Zulkifli, Muhammad Husaini
2020-10-07 14:54 ` Andy Shevchenko
2020-10-07 16:08 ` Zulkifli, Muhammad Husaini
2020-10-07 13:25 ` Zulkifli, Muhammad Husaini
2020-10-06 15:55 ` [PATCH v3 2/2] firmware: Keem Bay: Add support for Arm Trusted Firmware Service call muhammad.husaini.zulkifli
2020-10-06 20:37 ` kernel test robot
2020-10-07 3:41 ` Zulkifli, Muhammad Husaini
2020-10-07 8:20 ` Michal Simek
2020-10-07 10:10 ` Sudeep Holla
2020-10-07 13:29 ` Zulkifli, Muhammad Husaini
2020-10-07 13:21 ` Zulkifli, Muhammad Husaini
2020-10-07 13:37 ` Michal Simek
2020-10-07 13:52 ` Zulkifli, Muhammad Husaini
2020-10-07 13:58 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfXe=dwbNEdUfwmMnZCkSTRH_6HjGD0MUs=GY0en4f0sw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).