linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: allwinner: Pine H64: Enable both RGMII RX/TX delay
@ 2020-10-19  6:34 Corentin Labbe
  2020-10-22 16:09 ` Maxime Ripard
  0 siblings, 1 reply; 2+ messages in thread
From: Corentin Labbe @ 2020-10-19  6:34 UTC (permalink / raw)
  To: mripard, wens; +Cc: devicetree, linux-arm-kernel, linux-kernel, Corentin Labbe

Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config"),
the network is unusable on PineH64 model A.

This is due to phy-mode incorrectly set to rgmii instead of rgmii-id.

Fixes: 729e1ffcf47e ("arm64: allwinner: h6: add support for the Ethernet on Pine H64")
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
index af85b2074867..961732c52aa0 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
@@ -100,7 +100,7 @@ &ehci3 {
 &emac {
 	pinctrl-names = "default";
 	pinctrl-0 = <&ext_rgmii_pins>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-handle = <&ext_rgmii_phy>;
 	phy-supply = <&reg_gmac_3v3>;
 	allwinner,rx-delay-ps = <200>;
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: allwinner: Pine H64: Enable both RGMII RX/TX delay
  2020-10-19  6:34 [PATCH] arm64: dts: allwinner: Pine H64: Enable both RGMII RX/TX delay Corentin Labbe
@ 2020-10-22 16:09 ` Maxime Ripard
  0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2020-10-22 16:09 UTC (permalink / raw)
  To: Corentin Labbe; +Cc: wens, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

On Mon, Oct 19, 2020 at 06:34:49AM +0000, Corentin Labbe wrote:
> Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config"),
> the network is unusable on PineH64 model A.
> 
> This is due to phy-mode incorrectly set to rgmii instead of rgmii-id.
> 
> Fixes: 729e1ffcf47e ("arm64: allwinner: h6: add support for the Ethernet on Pine H64")
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Queued as a fix for 5.10, thanks!
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-22 16:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19  6:34 [PATCH] arm64: dts: allwinner: Pine H64: Enable both RGMII RX/TX delay Corentin Labbe
2020-10-22 16:09 ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).