* [PATCH] pinctrl: remove unneeded break
@ 2020-10-19 19:00 trix
2020-10-19 19:22 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-10-19 19:00 UTC (permalink / raw)
To: kgene, krzk, tomasz.figa, s.nawrocki, linus.walleij
Cc: linux-arm-kernel, linux-samsung-soc, linux-gpio, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
index 5e24838a582f..2223ead5bd72 100644
--- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
+++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
@@ -108,19 +108,14 @@ static int s3c24xx_eint_get_trigger(unsigned int type)
switch (type) {
case IRQ_TYPE_EDGE_RISING:
return EINT_EDGE_RISING;
- break;
case IRQ_TYPE_EDGE_FALLING:
return EINT_EDGE_FALLING;
- break;
case IRQ_TYPE_EDGE_BOTH:
return EINT_EDGE_BOTH;
- break;
case IRQ_TYPE_LEVEL_HIGH:
return EINT_LEVEL_HIGH;
- break;
case IRQ_TYPE_LEVEL_LOW:
return EINT_LEVEL_LOW;
- break;
default:
return -EINVAL;
}
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] pinctrl: remove unneeded break
2020-10-19 19:00 [PATCH] pinctrl: remove unneeded break trix
@ 2020-10-19 19:22 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2020-10-19 19:22 UTC (permalink / raw)
To: trix
Cc: Kukjin Kim, Krzysztof Kozlowski, tomasz.figa, s.nawrocki,
Linus Walleij, linux-arm Mailing List, linux-samsung-soc,
open list:GPIO SUBSYSTEM, Linux Kernel Mailing List
On Mon, Oct 19, 2020 at 10:04 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
When it's a single driver, use the proper prefix in the Subject line.
Also use proper English punctuation, i.e. period at the end of commit message.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> index 5e24838a582f..2223ead5bd72 100644
> --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> @@ -108,19 +108,14 @@ static int s3c24xx_eint_get_trigger(unsigned int type)
> switch (type) {
> case IRQ_TYPE_EDGE_RISING:
> return EINT_EDGE_RISING;
> - break;
> case IRQ_TYPE_EDGE_FALLING:
> return EINT_EDGE_FALLING;
> - break;
> case IRQ_TYPE_EDGE_BOTH:
> return EINT_EDGE_BOTH;
> - break;
> case IRQ_TYPE_LEVEL_HIGH:
> return EINT_LEVEL_HIGH;
> - break;
> case IRQ_TYPE_LEVEL_LOW:
> return EINT_LEVEL_LOW;
> - break;
> default:
> return -EINVAL;
> }
> --
> 2.18.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-19 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 19:00 [PATCH] pinctrl: remove unneeded break trix
2020-10-19 19:22 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).