* [PATCH] ipack: iopctal: remove unneeded break
@ 2020-10-19 19:32 trix
2020-10-20 5:50 ` [Industrypack-devel] " Samuel Iglesias Gonsálvez
0 siblings, 1 reply; 3+ messages in thread
From: trix @ 2020-10-19 19:32 UTC (permalink / raw)
To: siglesias, jens.taprogge, gregkh, arnd
Cc: industrypack-devel, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/ipack/devices/ipoctal.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c
index d480a514c983..3940714e4397 100644
--- a/drivers/ipack/devices/ipoctal.c
+++ b/drivers/ipack/devices/ipoctal.c
@@ -544,7 +544,6 @@ static void ipoctal_set_termios(struct tty_struct *tty,
break;
default:
return;
- break;
}
baud = tty_get_baud_rate(tty);
--
2.18.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Industrypack-devel] [PATCH] ipack: iopctal: remove unneeded break
2020-10-19 19:32 [PATCH] ipack: iopctal: remove unneeded break trix
@ 2020-10-20 5:50 ` Samuel Iglesias Gonsálvez
2020-10-20 6:03 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Iglesias Gonsálvez @ 2020-10-20 5:50 UTC (permalink / raw)
To: trix, jens.taprogge, gregkh, arnd; +Cc: linux-kernel, industrypack-devel
[-- Attachment #1: Type: text/plain, Size: 884 bytes --]
Hi Tom,
Thanks for the patch!
Patch is,
Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Greg, Would you mind picking this patch through your char-misc
tree?
Thanks!
Sam
On Mon, 2020-10-19 at 12:32 -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/ipack/devices/ipoctal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ipack/devices/ipoctal.c
> b/drivers/ipack/devices/ipoctal.c
> index d480a514c983..3940714e4397 100644
> --- a/drivers/ipack/devices/ipoctal.c
> +++ b/drivers/ipack/devices/ipoctal.c
> @@ -544,7 +544,6 @@ static void ipoctal_set_termios(struct tty_struct
> *tty,
> break;
> default:
> return;
> - break;
> }
>
> baud = tty_get_baud_rate(tty);
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Industrypack-devel] [PATCH] ipack: iopctal: remove unneeded break
2020-10-20 5:50 ` [Industrypack-devel] " Samuel Iglesias Gonsálvez
@ 2020-10-20 6:03 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-10-20 6:03 UTC (permalink / raw)
To: Samuel Iglesias Gonsálvez
Cc: trix, jens.taprogge, arnd, linux-kernel, industrypack-devel
On Tue, Oct 20, 2020 at 07:50:39AM +0200, Samuel Iglesias Gonsálvez wrote:
> Hi Tom,
>
> Thanks for the patch!
>
> Patch is,
>
> Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
>
> Greg, Would you mind picking this patch through your char-misc
> tree?
Will do after -rc1 is out.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-20 6:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 19:32 [PATCH] ipack: iopctal: remove unneeded break trix
2020-10-20 5:50 ` [Industrypack-devel] " Samuel Iglesias Gonsálvez
2020-10-20 6:03 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).