* [PATCH] PM: sleep: remove unneeded break
@ 2020-10-19 20:03 trix
2020-10-22 16:48 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-10-19 20:03 UTC (permalink / raw)
To: rjw, len.brown, pavel, gregkh; +Cc: linux-pm, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/base/power/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index 205a06752ca9..c7ac49042cee 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -363,7 +363,6 @@ static pm_callback_t pm_op(const struct dev_pm_ops *ops, pm_message_t state)
case PM_EVENT_THAW:
case PM_EVENT_RECOVER:
return ops->thaw;
- break;
case PM_EVENT_RESTORE:
return ops->restore;
#endif /* CONFIG_HIBERNATE_CALLBACKS */
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PM: sleep: remove unneeded break
2020-10-19 20:03 [PATCH] PM: sleep: remove unneeded break trix
@ 2020-10-22 16:48 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-10-22 16:48 UTC (permalink / raw)
To: trix
Cc: Rafael J. Wysocki, Len Brown, Pavel Machek, Greg Kroah-Hartman,
Linux PM, Linux Kernel Mailing List
On Mon, Oct 19, 2020 at 10:03 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/base/power/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index 205a06752ca9..c7ac49042cee 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -363,7 +363,6 @@ static pm_callback_t pm_op(const struct dev_pm_ops *ops, pm_message_t state)
> case PM_EVENT_THAW:
> case PM_EVENT_RECOVER:
> return ops->thaw;
> - break;
> case PM_EVENT_RESTORE:
> return ops->restore;
> #endif /* CONFIG_HIBERNATE_CALLBACKS */
> --
Applied as 5.10-rc material with edits in the subject and changelog, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-22 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 20:03 [PATCH] PM: sleep: remove unneeded break trix
2020-10-22 16:48 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).