* [PATCH v3 0/1] Add macro definition for the upcoming new OST driver. @ 2020-10-26 15:58 周琰杰 (Zhou Yanjie) 2020-10-26 15:58 ` [PATCH v3 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver 周琰杰 (Zhou Yanjie) 0 siblings, 1 reply; 4+ messages in thread From: 周琰杰 (Zhou Yanjie) @ 2020-10-26 15:58 UTC (permalink / raw) To: robh+dt Cc: linux-kernel, devicetree, daniel.lezcano, dongsheng.qiu, aric.pzqi, rick.tyliu, yanfei.li, sernia.zhou, zhenwenjin Add new macro definition to "ingenic,sysost.h", exchange the original ABI values of OST_CLK_PERCPU_TIMER and OST_CLK_GLOBAL_TIMER, prepare for the upcoming new OST driver. I'm sure that exchanging the ABI values of OST_CLK_PERCPU_TIMER and OST_CLK_GLOBAL_TIMER will not affect the existing related drivers and the SoCs whitch using these drivers, so we should be able to exchange them safely. v1->v2: Rewrite the commit message so that each line is less than 80 characters. v2->v3: Add the description of why the exchange of ABI values will not affect the existing driver into the commit message. 周琰杰 (Zhou Yanjie) (1): dt-bindings: timer: Add new OST support for the upcoming new driver. include/dt-bindings/clock/ingenic,sysost.h | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 2.11.0 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver. 2020-10-26 15:58 [PATCH v3 0/1] Add macro definition for the upcoming new OST driver 周琰杰 (Zhou Yanjie) @ 2020-10-26 15:58 ` 周琰杰 (Zhou Yanjie) 2020-10-30 18:45 ` Rob Herring 2020-12-03 23:47 ` [tip: timers/core] " tip-bot2 for 周琰杰 0 siblings, 2 replies; 4+ messages in thread From: 周琰杰 (Zhou Yanjie) @ 2020-10-26 15:58 UTC (permalink / raw) To: robh+dt Cc: linux-kernel, devicetree, daniel.lezcano, dongsheng.qiu, aric.pzqi, rick.tyliu, yanfei.li, sernia.zhou, zhenwenjin The new OST has one global timer and two or four percpu timers, so there will be three combinations in the upcoming new OST driver: the original GLOBAL_TIMER + PERCPU_TIMER, the new GLOBAL_TIMER + PERCPU_TIMER0/1 and GLOBAL_TIMER + PERCPU_TIMER0/1/2/3, For this, add the macro definition about OST_CLK_PERCPU_TIMER0/1/2/3. And in order to ensure that all the combinations work normally, the original ABI values of OST_CLK_PERCPU_TIMER and OST_CLK_GLOBAL_TIMER need to be exchanged to ensure that in any combinations, the clock can be registered (by calling clk_hw_register()) from index 0. Before this patch, OST_CLK_PERCPU_TIMER and OST_CLK_GLOBAL_TIMER are only used in two places, one is when using "assigned-clocks" to configure the clocks in the DTS file; the other is when registering the clocks in the sysost driver. When the values of these two ABIs are exchanged, the ABI value used by sysost driver when registering the clock, and the ABI value used by DTS when configuring the clock using "assigned-clocks" will also change accordingly. Therefore, there is no situation that causes the wrong clock to the configured. Therefore, exchanging ABI values will not cause errors in the existing codes when registering and configuring the clocks. Currently, in the mainline, only X1000 and X1830 are using sysost driver, and the upcoming X2000 will also use sysost driver. This patch has been tested on all three SoCs and all works fine. Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> --- Notes: v1->v2: Rewrite the commit message so that each line is less than 80 characters. v2->v3: Add the description of why the exchange of ABI values will not affect the existing driver into the commit message. include/dt-bindings/clock/ingenic,sysost.h | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/include/dt-bindings/clock/ingenic,sysost.h b/include/dt-bindings/clock/ingenic,sysost.h index 9ac88e90babf..063791b01ab3 100644 --- a/include/dt-bindings/clock/ingenic,sysost.h +++ b/include/dt-bindings/clock/ingenic,sysost.h @@ -1,12 +1,16 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * This header provides clock numbers for the ingenic,tcu DT binding. + * This header provides clock numbers for the Ingenic OST DT binding. */ #ifndef __DT_BINDINGS_CLOCK_INGENIC_OST_H__ #define __DT_BINDINGS_CLOCK_INGENIC_OST_H__ -#define OST_CLK_PERCPU_TIMER 0 -#define OST_CLK_GLOBAL_TIMER 1 +#define OST_CLK_PERCPU_TIMER 1 +#define OST_CLK_GLOBAL_TIMER 0 +#define OST_CLK_PERCPU_TIMER0 1 +#define OST_CLK_PERCPU_TIMER1 2 +#define OST_CLK_PERCPU_TIMER2 3 +#define OST_CLK_PERCPU_TIMER3 4 #endif /* __DT_BINDINGS_CLOCK_INGENIC_OST_H__ */ -- 2.11.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver. 2020-10-26 15:58 ` [PATCH v3 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver 周琰杰 (Zhou Yanjie) @ 2020-10-30 18:45 ` Rob Herring 2020-12-03 23:47 ` [tip: timers/core] " tip-bot2 for 周琰杰 1 sibling, 0 replies; 4+ messages in thread From: Rob Herring @ 2020-10-30 18:45 UTC (permalink / raw) To: 周琰杰 (Zhou Yanjie) Cc: dongsheng.qiu, rick.tyliu, robh+dt, sernia.zhou, aric.pzqi, yanfei.li, zhenwenjin, devicetree, linux-kernel, daniel.lezcano On Mon, 26 Oct 2020 23:58:42 +0800, 周琰杰 (Zhou Yanjie) wrote: > The new OST has one global timer and two or four percpu timers, so there > will be three combinations in the upcoming new OST driver: the original > GLOBAL_TIMER + PERCPU_TIMER, the new GLOBAL_TIMER + PERCPU_TIMER0/1 and > GLOBAL_TIMER + PERCPU_TIMER0/1/2/3, For this, add the macro definition > about OST_CLK_PERCPU_TIMER0/1/2/3. And in order to ensure that all the > combinations work normally, the original ABI values of OST_CLK_PERCPU_TIMER > and OST_CLK_GLOBAL_TIMER need to be exchanged to ensure that in any > combinations, the clock can be registered (by calling clk_hw_register()) > from index 0. > > Before this patch, OST_CLK_PERCPU_TIMER and OST_CLK_GLOBAL_TIMER are only > used in two places, one is when using "assigned-clocks" to configure the > clocks in the DTS file; the other is when registering the clocks in the > sysost driver. When the values of these two ABIs are exchanged, the ABI > value used by sysost driver when registering the clock, and the ABI value > used by DTS when configuring the clock using "assigned-clocks" will also > change accordingly. Therefore, there is no situation that causes the wrong > clock to the configured. Therefore, exchanging ABI values will not cause > errors in the existing codes when registering and configuring the clocks. > > Currently, in the mainline, only X1000 and X1830 are using sysost driver, > and the upcoming X2000 will also use sysost driver. This patch has been > tested on all three SoCs and all works fine. > > Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com> > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> > --- > > Notes: > v1->v2: > Rewrite the commit message so that each line is less than 80 characters. > > v2->v3: > Add the description of why the exchange of ABI values will not affect > the existing driver into the commit message. > > include/dt-bindings/clock/ingenic,sysost.h | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip: timers/core] dt-bindings: timer: Add new OST support for the upcoming new driver. 2020-10-26 15:58 ` [PATCH v3 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver 周琰杰 (Zhou Yanjie) 2020-10-30 18:45 ` Rob Herring @ 2020-12-03 23:47 ` tip-bot2 for 周琰杰 1 sibling, 0 replies; 4+ messages in thread From: tip-bot2 for 周琰杰 @ 2020-12-03 23:47 UTC (permalink / raw) To: linux-tip-commits Cc: sernia.zhou, zhouyanjie, Rob Herring, Daniel Lezcano, x86, linux-kernel The following commit has been merged into the timers/core branch of tip: Commit-ID: 0fce2e02a29ca5420472f03d3f2858eedded3fe7 Gitweb: https://git.kernel.org/tip/0fce2e02a29ca5420472f03d3f2858eedded3fe7 Author: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> AuthorDate: Mon, 26 Oct 2020 23:58:42 +08:00 Committer: Daniel Lezcano <daniel.lezcano@linaro.org> CommitterDate: Thu, 03 Dec 2020 19:16:18 +01:00 dt-bindings: timer: Add new OST support for the upcoming new driver. The new OST has one global timer and two or four percpu timers, so there will be three combinations in the upcoming new OST driver: the original GLOBAL_TIMER + PERCPU_TIMER, the new GLOBAL_TIMER + PERCPU_TIMER0/1 and GLOBAL_TIMER + PERCPU_TIMER0/1/2/3, For this, add the macro definition about OST_CLK_PERCPU_TIMER0/1/2/3. And in order to ensure that all the combinations work normally, the original ABI values of OST_CLK_PERCPU_TIMER and OST_CLK_GLOBAL_TIMER need to be exchanged to ensure that in any combinations, the clock can be registered (by calling clk_hw_register()) from index 0. Before this patch, OST_CLK_PERCPU_TIMER and OST_CLK_GLOBAL_TIMER are only used in two places, one is when using "assigned-clocks" to configure the clocks in the DTS file; the other is when registering the clocks in the sysost driver. When the values of these two ABIs are exchanged, the ABI value used by sysost driver when registering the clock, and the ABI value used by DTS when configuring the clock using "assigned-clocks" will also change accordingly. Therefore, there is no situation that causes the wrong clock to the configured. Therefore, exchanging ABI values will not cause errors in the existing codes when registering and configuring the clocks. Currently, in the mainline, only X1000 and X1830 are using sysost driver, and the upcoming X2000 will also use sysost driver. This patch has been tested on all three SoCs and all works fine. Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> Reviewed-by: Rob Herring <robh@kernel.org> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20201026155842.10196-2-zhouyanjie@wanyeetech.com --- include/dt-bindings/clock/ingenic,sysost.h | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/include/dt-bindings/clock/ingenic,sysost.h b/include/dt-bindings/clock/ingenic,sysost.h index 9ac88e9..063791b 100644 --- a/include/dt-bindings/clock/ingenic,sysost.h +++ b/include/dt-bindings/clock/ingenic,sysost.h @@ -1,12 +1,16 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * This header provides clock numbers for the ingenic,tcu DT binding. + * This header provides clock numbers for the Ingenic OST DT binding. */ #ifndef __DT_BINDINGS_CLOCK_INGENIC_OST_H__ #define __DT_BINDINGS_CLOCK_INGENIC_OST_H__ -#define OST_CLK_PERCPU_TIMER 0 -#define OST_CLK_GLOBAL_TIMER 1 +#define OST_CLK_PERCPU_TIMER 1 +#define OST_CLK_GLOBAL_TIMER 0 +#define OST_CLK_PERCPU_TIMER0 1 +#define OST_CLK_PERCPU_TIMER1 2 +#define OST_CLK_PERCPU_TIMER2 3 +#define OST_CLK_PERCPU_TIMER3 4 #endif /* __DT_BINDINGS_CLOCK_INGENIC_OST_H__ */ ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-03 23:49 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-10-26 15:58 [PATCH v3 0/1] Add macro definition for the upcoming new OST driver 周琰杰 (Zhou Yanjie) 2020-10-26 15:58 ` [PATCH v3 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver 周琰杰 (Zhou Yanjie) 2020-10-30 18:45 ` Rob Herring 2020-12-03 23:47 ` [tip: timers/core] " tip-bot2 for 周琰杰
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).