* [PATCH 1/2] extcon: fsa9480: Rewrite bindings in YAML and extend @ 2020-11-01 0:43 ` Linus Walleij 2020-11-01 0:43 ` [PATCH 2/2] extcon: fsa9480: Support TI TSU6111 variant Linus Walleij ` (2 more replies) 0 siblings, 3 replies; 6+ messages in thread From: Linus Walleij @ 2020-11-01 0:43 UTC (permalink / raw) To: MyungJoo Ham, Chanwoo Choi; +Cc: linux-kernel, Linus Walleij, devicetree This rewrites the FSA9480 DT bindings using YAML and extends them with the compatible TI TSU6111. I chose to name the file fcs,fsa880 since this is the first switch, later versions are improvements. Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- .../bindings/extcon/extcon-fsa9480.txt | 21 -------- .../bindings/extcon/fcs,fsa880.yaml | 52 +++++++++++++++++++ 2 files changed, 52 insertions(+), 21 deletions(-) delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt create mode 100644 Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml diff --git a/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt b/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt deleted file mode 100644 index 624bd76f468e..000000000000 --- a/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt +++ /dev/null @@ -1,21 +0,0 @@ -FAIRCHILD SEMICONDUCTOR FSA9480 MICROUSB SWITCH - -The FSA9480 is a USB port accessory detector and switch. The FSA9480 is fully -controlled using I2C and enables USB data, stereo and mono audio, video, -microphone, and UART data to use a common connector port. - -Required properties: - - compatible : Must be one of - "fcs,fsa9480" - "fcs,fsa880" - - reg : Specifies i2c slave address. Must be 0x25. - - interrupts : Should contain one entry specifying interrupt signal of - interrupt parent to which interrupt pin of the chip is connected. - - Example: - musb@25 { - compatible = "fcs,fsa9480"; - reg = <0x25>; - interrupt-parent = <&gph2>; - interrupts = <7 0>; - }; diff --git a/Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml b/Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml new file mode 100644 index 000000000000..ef6a246a1337 --- /dev/null +++ b/Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/extcon/fcs,fsa880.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Fairchild Semiconductor FSA880, FSA9480 and compatibles + +maintainers: + - Linus Walleij <linus.walleij@linaro.org> + +description: + The FSA880 and FSA9480 are USB port accessory detectors and switches. + The switch is fully controlled using I2C and enables USB data, stereo + and mono audio, video, microphone, and UART data to use a common + connector port. Compatible switches exist from other manufacturers. + +properties: + compatible: + enum: + - fcs,fsa880 + - fcs,fsa9480 + - ti,tsu6111 + + reg: + maxItems: 1 + description: The I2C address for an FSA880 compatible device is + usually 0x25. + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + usb-switch@25 { + compatible = "fcs,fsa880"; + reg = <0x25>; + interrupt-parent = <&gpio>; + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; + }; + }; -- 2.26.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] extcon: fsa9480: Support TI TSU6111 variant 2020-11-01 0:43 ` [PATCH 1/2] extcon: fsa9480: Rewrite bindings in YAML and extend Linus Walleij @ 2020-11-01 0:43 ` Linus Walleij 2020-11-02 3:01 ` Chanwoo Choi 2020-11-02 2:59 ` [PATCH 1/2] extcon: fsa9480: Rewrite bindings in YAML and extend Chanwoo Choi 2020-11-04 22:31 ` Rob Herring 2 siblings, 1 reply; 6+ messages in thread From: Linus Walleij @ 2020-11-01 0:43 UTC (permalink / raw) To: MyungJoo Ham, Chanwoo Choi; +Cc: linux-kernel, Linus Walleij The Texas Instruments TSU6111 is compatible to the FSA880/FSA9480. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/extcon/extcon-fsa9480.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa9480.c index 8405512f5199..08bdedbcdb0d 100644 --- a/drivers/extcon/extcon-fsa9480.c +++ b/drivers/extcon/extcon-fsa9480.c @@ -364,6 +364,7 @@ MODULE_DEVICE_TABLE(i2c, fsa9480_id); static const struct of_device_id fsa9480_of_match[] = { { .compatible = "fcs,fsa9480", }, { .compatible = "fcs,fsa880", }, + { .compatible = "ti,tsu6111", }, { }, }; MODULE_DEVICE_TABLE(of, fsa9480_of_match); -- 2.26.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] extcon: fsa9480: Support TI TSU6111 variant 2020-11-01 0:43 ` [PATCH 2/2] extcon: fsa9480: Support TI TSU6111 variant Linus Walleij @ 2020-11-02 3:01 ` Chanwoo Choi 2020-11-05 1:02 ` Chanwoo Choi 0 siblings, 1 reply; 6+ messages in thread From: Chanwoo Choi @ 2020-11-02 3:01 UTC (permalink / raw) To: Linus Walleij, MyungJoo Ham; +Cc: linux-kernel Hi Linus, On 11/1/20 9:43 AM, Linus Walleij wrote: > The Texas Instruments TSU6111 is compatible to the > FSA880/FSA9480. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/extcon/extcon-fsa9480.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa9480.c > index 8405512f5199..08bdedbcdb0d 100644 > --- a/drivers/extcon/extcon-fsa9480.c > +++ b/drivers/extcon/extcon-fsa9480.c > @@ -364,6 +364,7 @@ MODULE_DEVICE_TABLE(i2c, fsa9480_id); > static const struct of_device_id fsa9480_of_match[] = { > { .compatible = "fcs,fsa9480", }, > { .compatible = "fcs,fsa880", }, > + { .compatible = "ti,tsu6111", }, > { }, > }; > MODULE_DEVICE_TABLE(of, fsa9480_of_match); > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> As I replied from patch1, I'm waiting the review from DT maintainer. And then, I'll merge it. -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] extcon: fsa9480: Support TI TSU6111 variant 2020-11-02 3:01 ` Chanwoo Choi @ 2020-11-05 1:02 ` Chanwoo Choi 0 siblings, 0 replies; 6+ messages in thread From: Chanwoo Choi @ 2020-11-05 1:02 UTC (permalink / raw) To: Linus Walleij, MyungJoo Ham; +Cc: linux-kernel On 11/2/20 12:01 PM, Chanwoo Choi wrote: > Hi Linus, > > On 11/1/20 9:43 AM, Linus Walleij wrote: >> The Texas Instruments TSU6111 is compatible to the >> FSA880/FSA9480. >> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> >> --- >> drivers/extcon/extcon-fsa9480.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa9480.c >> index 8405512f5199..08bdedbcdb0d 100644 >> --- a/drivers/extcon/extcon-fsa9480.c >> +++ b/drivers/extcon/extcon-fsa9480.c >> @@ -364,6 +364,7 @@ MODULE_DEVICE_TABLE(i2c, fsa9480_id); >> static const struct of_device_id fsa9480_of_match[] = { >> { .compatible = "fcs,fsa9480", }, >> { .compatible = "fcs,fsa880", }, >> + { .compatible = "ti,tsu6111", }, >> { }, >> }; >> MODULE_DEVICE_TABLE(of, fsa9480_of_match); >> > > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> > > As I replied from patch1, I'm waiting the review from DT maintainer. > And then, I'll merge it. > > Applied them. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] extcon: fsa9480: Rewrite bindings in YAML and extend 2020-11-01 0:43 ` [PATCH 1/2] extcon: fsa9480: Rewrite bindings in YAML and extend Linus Walleij 2020-11-01 0:43 ` [PATCH 2/2] extcon: fsa9480: Support TI TSU6111 variant Linus Walleij @ 2020-11-02 2:59 ` Chanwoo Choi 2020-11-04 22:31 ` Rob Herring 2 siblings, 0 replies; 6+ messages in thread From: Chanwoo Choi @ 2020-11-02 2:59 UTC (permalink / raw) To: Linus Walleij, MyungJoo Ham; +Cc: linux-kernel, devicetree Hi Linus, On 11/1/20 9:43 AM, Linus Walleij wrote: > This rewrites the FSA9480 DT bindings using YAML and > extends them with the compatible TI TSU6111. > > I chose to name the file fcs,fsa880 since this is the > first switch, later versions are improvements. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > .../bindings/extcon/extcon-fsa9480.txt | 21 -------- > .../bindings/extcon/fcs,fsa880.yaml | 52 +++++++++++++++++++ > 2 files changed, 52 insertions(+), 21 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt > create mode 100644 Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml > > diff --git a/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt b/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt > deleted file mode 100644 > index 624bd76f468e..000000000000 > --- a/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt > +++ /dev/null > @@ -1,21 +0,0 @@ > -FAIRCHILD SEMICONDUCTOR FSA9480 MICROUSB SWITCH > - > -The FSA9480 is a USB port accessory detector and switch. The FSA9480 is fully > -controlled using I2C and enables USB data, stereo and mono audio, video, > -microphone, and UART data to use a common connector port. > - > -Required properties: > - - compatible : Must be one of > - "fcs,fsa9480" > - "fcs,fsa880" > - - reg : Specifies i2c slave address. Must be 0x25. > - - interrupts : Should contain one entry specifying interrupt signal of > - interrupt parent to which interrupt pin of the chip is connected. > - > - Example: > - musb@25 { > - compatible = "fcs,fsa9480"; > - reg = <0x25>; > - interrupt-parent = <&gph2>; > - interrupts = <7 0>; > - }; > diff --git a/Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml b/Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml > new file mode 100644 > index 000000000000..ef6a246a1337 > --- /dev/null > +++ b/Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: https://protect2.fireeye.com/v1/url?k=da7a3fd4-85e106de-da7bb49b-0cc47a31384a-f57ab7f026383135&q=1&e=f8ca331d-3c11-4257-8322-d97ac13418ef&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fextcon%2Ffcs%2Cfsa880.yaml%23 > +$schema: https://protect2.fireeye.com/v1/url?k=0449819e-5bd2b894-04480ad1-0cc47a31384a-07ad90468a2ed371&q=1&e=f8ca331d-3c11-4257-8322-d97ac13418ef&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > + > +title: Fairchild Semiconductor FSA880, FSA9480 and compatibles > + > +maintainers: > + - Linus Walleij <linus.walleij@linaro.org> > + > +description: > + The FSA880 and FSA9480 are USB port accessory detectors and switches. > + The switch is fully controlled using I2C and enables USB data, stereo > + and mono audio, video, microphone, and UART data to use a common > + connector port. Compatible switches exist from other manufacturers. > + > +properties: > + compatible: > + enum: > + - fcs,fsa880 > + - fcs,fsa9480 > + - ti,tsu6111 > + > + reg: > + maxItems: 1 > + description: The I2C address for an FSA880 compatible device is > + usually 0x25. > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + usb-switch@25 { > + compatible = "fcs,fsa880"; > + reg = <0x25>; > + interrupt-parent = <&gpio>; > + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; > + }; > + }; > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> I'm waiting the reply from DT maintainer for a while. After that, I'll merge them. -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] extcon: fsa9480: Rewrite bindings in YAML and extend 2020-11-01 0:43 ` [PATCH 1/2] extcon: fsa9480: Rewrite bindings in YAML and extend Linus Walleij 2020-11-01 0:43 ` [PATCH 2/2] extcon: fsa9480: Support TI TSU6111 variant Linus Walleij 2020-11-02 2:59 ` [PATCH 1/2] extcon: fsa9480: Rewrite bindings in YAML and extend Chanwoo Choi @ 2020-11-04 22:31 ` Rob Herring 2 siblings, 0 replies; 6+ messages in thread From: Rob Herring @ 2020-11-04 22:31 UTC (permalink / raw) To: Linus Walleij; +Cc: MyungJoo Ham, linux-kernel, devicetree, Chanwoo Choi On Sun, 01 Nov 2020 01:43:56 +0100, Linus Walleij wrote: > This rewrites the FSA9480 DT bindings using YAML and > extends them with the compatible TI TSU6111. > > I chose to name the file fcs,fsa880 since this is the > first switch, later versions are improvements. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > .../bindings/extcon/extcon-fsa9480.txt | 21 -------- > .../bindings/extcon/fcs,fsa880.yaml | 52 +++++++++++++++++++ > 2 files changed, 52 insertions(+), 21 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt > create mode 100644 Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-05 0:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20201101004410epcas1p36f8a3469611fbc27eed6803d383df06e@epcas1p3.samsung.com>
2020-11-01 0:43 ` [PATCH 1/2] extcon: fsa9480: Rewrite bindings in YAML and extend Linus Walleij
2020-11-01 0:43 ` [PATCH 2/2] extcon: fsa9480: Support TI TSU6111 variant Linus Walleij
2020-11-02 3:01 ` Chanwoo Choi
2020-11-05 1:02 ` Chanwoo Choi
2020-11-02 2:59 ` [PATCH 1/2] extcon: fsa9480: Rewrite bindings in YAML and extend Chanwoo Choi
2020-11-04 22:31 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).