* [PATCH] x86/dumpstack: make show_trace_log_lvl() static
@ 2020-11-13 13:39 Hui Su
2020-11-17 18:24 ` [tip: x86/cleanups] x86/dumpstack: Make " tip-bot2 for Hui Su
2020-11-20 9:50 ` [PATCH] x86/dumpstack: make " Petr Mladek
0 siblings, 2 replies; 3+ messages in thread
From: Hui Su @ 2020-11-13 13:39 UTC (permalink / raw)
To: tglx, mingo, bp, x86, hpa, 0x7f454c46, jroedel, akpm, pmladek,
jannh, mark.mossberg, linux-kernel
Cc: sh_def
show_trace_log_lvl() won't be used by other files, so
make it static and remove the declaration from the header
file.
Signed-off-by: Hui Su <sh_def@163.com>
---
arch/x86/include/asm/stacktrace.h | 3 ---
arch/x86/kernel/dumpstack.c | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/stacktrace.h b/arch/x86/include/asm/stacktrace.h
index 49600643faba..f248eb2ac2d4 100644
--- a/arch/x86/include/asm/stacktrace.h
+++ b/arch/x86/include/asm/stacktrace.h
@@ -88,9 +88,6 @@ get_stack_pointer(struct task_struct *task, struct pt_regs *regs)
return (unsigned long *)task->thread.sp;
}
-void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
- unsigned long *stack, const char *log_lvl);
-
/* The form of the top of the frame on the stack */
struct stack_frame {
struct stack_frame *next_frame;
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index 25c06b67e7e0..067de0d0fa4f 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -168,7 +168,7 @@ static void show_regs_if_on_stack(struct stack_info *info, struct pt_regs *regs,
}
}
-void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
+static void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
unsigned long *stack, const char *log_lvl)
{
struct unwind_state state;
--
2.29.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip: x86/cleanups] x86/dumpstack: Make show_trace_log_lvl() static
2020-11-13 13:39 [PATCH] x86/dumpstack: make show_trace_log_lvl() static Hui Su
@ 2020-11-17 18:24 ` tip-bot2 for Hui Su
2020-11-20 9:50 ` [PATCH] x86/dumpstack: make " Petr Mladek
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Hui Su @ 2020-11-17 18:24 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Hui Su, Borislav Petkov, x86, linux-kernel
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 09a217c10504bcaef911cf2af74e424338efe629
Gitweb: https://git.kernel.org/tip/09a217c10504bcaef911cf2af74e424338efe629
Author: Hui Su <sh_def@163.com>
AuthorDate: Fri, 13 Nov 2020 21:39:43 +08:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Tue, 17 Nov 2020 19:05:32 +01:00
x86/dumpstack: Make show_trace_log_lvl() static
show_trace_log_lvl() is not used by other compilation units so make it
static and remove the declaration from the header file.
Signed-off-by: Hui Su <sh_def@163.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20201113133943.GA136221@rlk
---
arch/x86/include/asm/stacktrace.h | 3 ---
arch/x86/kernel/dumpstack.c | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/stacktrace.h b/arch/x86/include/asm/stacktrace.h
index 4960064..f248eb2 100644
--- a/arch/x86/include/asm/stacktrace.h
+++ b/arch/x86/include/asm/stacktrace.h
@@ -88,9 +88,6 @@ get_stack_pointer(struct task_struct *task, struct pt_regs *regs)
return (unsigned long *)task->thread.sp;
}
-void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
- unsigned long *stack, const char *log_lvl);
-
/* The form of the top of the frame on the stack */
struct stack_frame {
struct stack_frame *next_frame;
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index 25c06b6..067de0d 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -168,7 +168,7 @@ static void show_regs_if_on_stack(struct stack_info *info, struct pt_regs *regs,
}
}
-void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
+static void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
unsigned long *stack, const char *log_lvl)
{
struct unwind_state state;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/dumpstack: make show_trace_log_lvl() static
2020-11-13 13:39 [PATCH] x86/dumpstack: make show_trace_log_lvl() static Hui Su
2020-11-17 18:24 ` [tip: x86/cleanups] x86/dumpstack: Make " tip-bot2 for Hui Su
@ 2020-11-20 9:50 ` Petr Mladek
1 sibling, 0 replies; 3+ messages in thread
From: Petr Mladek @ 2020-11-20 9:50 UTC (permalink / raw)
To: Hui Su
Cc: tglx, mingo, bp, x86, hpa, 0x7f454c46, jroedel, akpm, jannh,
mark.mossberg, linux-kernel
On Fri 2020-11-13 21:39:43, Hui Su wrote:
> show_trace_log_lvl() won't be used by other files, so
> make it static and remove the declaration from the header
> file.
>
> Signed-off-by: Hui Su <sh_def@163.com>
I would make sense to add:
Fixes: 16d1cb0bc43642a4d9 ("x86/dumpstack: Unify show_regs()")
Othrewise, it looks good:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-20 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 13:39 [PATCH] x86/dumpstack: make show_trace_log_lvl() static Hui Su
2020-11-17 18:24 ` [tip: x86/cleanups] x86/dumpstack: Make " tip-bot2 for Hui Su
2020-11-20 9:50 ` [PATCH] x86/dumpstack: make " Petr Mladek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).