linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Garzarella <sgarzare@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	linux-kernel@vger.kernel.org, Eli Cohen <elic@nvidia.com>,
	Jason Wang <jasowang@redhat.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: Re: [PATCH RFC 12/12] vdpa_sim_blk: implement ramdisk behaviour
Date: Mon, 16 Nov 2020 12:23:55 +0100	[thread overview]
Message-ID: <20201116112355.vo6blezyrfh7kltl@steredhat> (raw)
In-Reply-To: <20201116045029-mutt-send-email-mst@kernel.org>

On Mon, Nov 16, 2020 at 04:50:43AM -0500, Michael S. Tsirkin wrote:
>On Fri, Nov 13, 2020 at 02:47:12PM +0100, Stefano Garzarella wrote:
>> The previous implementation wrote only the status of each request.
>> This patch implements a more accurate block device simulator,
>> providing a ramdisk-like behavior.
>>
>> Also handle VIRTIO_BLK_T_GET_ID request, always answering the
>> "vdpa_blk_sim" string.
>
>Maybe an ioctl to specify the id makes more sense.

I agree that make sense to make it configurable from the user, but I'm 
not sure an ioctl() is the best interface with this device simulator.

Maybe we can use a module parameter as in the net simulator or even 
better using the new vdpa management tool recently proposed (I need to 
check better how we can extend it).

What do you think?

Thanks,
Stefano


  reply	other threads:[~2020-11-16 12:37 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 13:47 [PATCH RFC 00/12] vdpa: generalize vdpa simulator and add block device Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 01/12] vhost-vdpa: add support for vDPA blk devices Stefano Garzarella
2020-11-17 10:57   ` Stefan Hajnoczi
2020-11-17 15:05     ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 02/12] vdpa: split vdpasim to core and net modules Stefano Garzarella
2020-11-16  4:00   ` Jason Wang
2020-11-16  9:39     ` Stefano Garzarella
2020-11-18 13:14     ` Stefano Garzarella
2020-11-19  6:16       ` Jason Wang
2020-11-13 13:47 ` [PATCH RFC 03/12] vdpa_sim: remove hard-coded virtq count Stefano Garzarella
2020-11-16  4:02   ` Jason Wang
2020-11-13 13:47 ` [PATCH RFC 04/12] vdpa: add vdpa simulator for block device Stefano Garzarella
2020-11-16  4:10   ` Jason Wang
2020-11-16 10:17     ` Stefano Garzarella
2020-11-17 11:11   ` Stefan Hajnoczi
2020-11-17 14:16     ` Stefano Garzarella
2020-11-17 16:43       ` Stefan Hajnoczi
2020-11-17 17:38         ` Stefano Garzarella
2020-11-18 11:23           ` Stefan Hajnoczi
2020-11-18 11:39             ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 05/12] vdpa_sim: remove the limit of IOTLB entries Stefano Garzarella
2020-11-16  4:12   ` Jason Wang
2020-11-16 10:22     ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 06/12] vdpa_sim: add struct vdpasim_device to store device properties Stefano Garzarella
2020-11-16  4:14   ` Jason Wang
2020-11-16 10:30     ` Stefano Garzarella
2020-11-17 11:23   ` Stefan Hajnoczi
2020-11-17 14:24     ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 07/12] vdpa_sim: move config management outside of the core Stefano Garzarella
2020-11-16  4:18   ` Jason Wang
2020-11-16 10:42     ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 08/12] vdpa_sim: use kvmalloc to allocate vdpasim->buffer Stefano Garzarella
2020-11-16  4:19   ` Jason Wang
2020-11-13 13:47 ` [PATCH RFC 09/12] vdpa_sim: make vdpasim->buffer size configurable Stefano Garzarella
2020-11-16  4:19   ` Jason Wang
2020-11-13 13:47 ` [PATCH RFC 10/12] vdpa_sim: split vdpasim_virtqueue's iov field in riov and wiov Stefano Garzarella
2020-11-16  4:21   ` Jason Wang
2020-11-17 11:27   ` Stefan Hajnoczi
2020-11-20 14:41     ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 11/12] vringh: allow vringh_iov_xfer() to skip bytes when ptr is NULL Stefano Garzarella
2020-11-16  4:32   ` Jason Wang
2020-11-16 11:48     ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 12/12] vdpa_sim_blk: implement ramdisk behaviour Stefano Garzarella
2020-11-16  5:25   ` Jason Wang
2020-11-16 11:08     ` Stefano Garzarella
2020-11-16  9:50   ` Michael S. Tsirkin
2020-11-16 11:23     ` Stefano Garzarella [this message]
2020-11-17 11:36   ` Stefan Hajnoczi
2020-11-17 14:32     ` Stefano Garzarella
2020-11-16  3:37 ` [PATCH RFC 00/12] vdpa: generalize vdpa simulator and add block device Jason Wang
2020-11-16  8:53   ` Stefano Garzarella
2020-12-18 11:38   ` Stefano Garzarella
2020-12-21  3:16     ` Jason Wang
2020-12-21 11:14       ` Stefano Garzarella
2020-12-22  2:44         ` Jason Wang
2020-12-22 10:57           ` Stefano Garzarella
2020-12-22 12:29             ` Jason Wang
2020-12-22 12:56               ` Jason Wang
2020-12-22 13:23               ` Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201116112355.vo6blezyrfh7kltl@steredhat \
    --to=sgarzare@redhat.com \
    --cc=elic@nvidia.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=mst@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).