From: Stefano Garzarella <sgarzare@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
Laurent Vivier <lvivier@redhat.com>,
linux-kernel@vger.kernel.org, Eli Cohen <elic@nvidia.com>,
Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: Re: [PATCH RFC 04/12] vdpa: add vdpa simulator for block device
Date: Tue, 17 Nov 2020 18:38:11 +0100 [thread overview]
Message-ID: <20201117173811.lw4nwicoykhnn3tt@steredhat> (raw)
In-Reply-To: <20201117164342.GT131917@stefanha-x1.localdomain>
On Tue, Nov 17, 2020 at 04:43:42PM +0000, Stefan Hajnoczi wrote:
>On Tue, Nov 17, 2020 at 03:16:20PM +0100, Stefano Garzarella wrote:
>> On Tue, Nov 17, 2020 at 11:11:21AM +0000, Stefan Hajnoczi wrote:
>> > On Fri, Nov 13, 2020 at 02:47:04PM +0100, Stefano Garzarella wrote:
>> > > +static void vdpasim_blk_work(struct work_struct *work)
>> > > +{
>> > > + struct vdpasim *vdpasim = container_of(work, struct vdpasim, work);
>> > > + u8 status = VIRTIO_BLK_S_OK;
>> > > + int i;
>> > > +
>> > > + spin_lock(&vdpasim->lock);
>> > > +
>> > > + if (!(vdpasim->status & VIRTIO_CONFIG_S_DRIVER_OK))
>> > > + goto out;
>> > > +
>> > > + for (i = 0; i < VDPASIM_BLK_VQ_NUM; i++) {
>> > > + struct vdpasim_virtqueue *vq = &vdpasim->vqs[i];
>> > > +
>> > > + if (!vq->ready)
>> > > + continue;
>> > > +
>> > > + while (vringh_getdesc_iotlb(&vq->vring, &vq->iov, &vq->iov,
>> > > + &vq->head, GFP_ATOMIC) > 0) {
>> > > +
>> > > + int write;
>> > > +
>> > > + vq->iov.i = vq->iov.used - 1;
>> > > + write = vringh_iov_push_iotlb(&vq->vring, &vq->iov, &status, 1);
>> > > + if (write <= 0)
>> > > + break;
>> >
>> > We're lucky the guest driver doesn't crash after VIRTIO_BLK_T_GET_ID? :)
>>
>> The crash could happen if the simulator doesn't put the string terminator,
>> but in virtio_blk.c, the serial_show() initialize the buffer putting the
>> string terminator in the VIRTIO_BLK_ID_BYTES element:
>>
>> buf[VIRTIO_BLK_ID_BYTES] = '\0';
>> err = virtblk_get_id(disk, buf);
>>
>> This should prevent the issue, right?
>>
>> However in the last patch of this series I implemented VIRTIO_BLK_T_GET_ID
>> support :-)
>
>Windows, BSD, macOS, etc guest drivers aren't necessarily going to
>terminate or initialize the serial string buffer.
Unfortunately I discovered that VIRTIO_BLK_T_GET_ID is not in the VIRTIO
specs, so, just for curiosity, I checked the QEMU code and I found this:
case VIRTIO_BLK_T_GET_ID:
{
/*
* NB: per existing s/n string convention the string is
* terminated by '\0' only when shorter than buffer.
*/
const char *serial = s->conf.serial ? s->conf.serial : "";
size_t size = MIN(strlen(serial) + 1,
MIN(iov_size(in_iov, in_num),
VIRTIO_BLK_ID_BYTES));
iov_from_buf(in_iov, in_num, 0, serial, size);
virtio_blk_req_complete(req, VIRTIO_BLK_S_OK);
virtio_blk_free_request(req);
break;
}
It seems that the device emulation in QEMU expects that the driver
terminates the serial string buffer.
Do you know why VIRTIO_BLK_T_GET_ID is not in the specs?
Should we add it?
Thanks,
Stefano
>
>Anyway, the later patch that implements VIRTIO_BLK_T_GET_ID solves this
>issue! Thanks.
>
>Stefan
next prev parent reply other threads:[~2020-11-17 17:38 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 13:47 [PATCH RFC 00/12] vdpa: generalize vdpa simulator and add block device Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 01/12] vhost-vdpa: add support for vDPA blk devices Stefano Garzarella
2020-11-17 10:57 ` Stefan Hajnoczi
2020-11-17 15:05 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 02/12] vdpa: split vdpasim to core and net modules Stefano Garzarella
2020-11-16 4:00 ` Jason Wang
2020-11-16 9:39 ` Stefano Garzarella
2020-11-18 13:14 ` Stefano Garzarella
2020-11-19 6:16 ` Jason Wang
2020-11-13 13:47 ` [PATCH RFC 03/12] vdpa_sim: remove hard-coded virtq count Stefano Garzarella
2020-11-16 4:02 ` Jason Wang
2020-11-13 13:47 ` [PATCH RFC 04/12] vdpa: add vdpa simulator for block device Stefano Garzarella
2020-11-16 4:10 ` Jason Wang
2020-11-16 10:17 ` Stefano Garzarella
2020-11-17 11:11 ` Stefan Hajnoczi
2020-11-17 14:16 ` Stefano Garzarella
2020-11-17 16:43 ` Stefan Hajnoczi
2020-11-17 17:38 ` Stefano Garzarella [this message]
2020-11-18 11:23 ` Stefan Hajnoczi
2020-11-18 11:39 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 05/12] vdpa_sim: remove the limit of IOTLB entries Stefano Garzarella
2020-11-16 4:12 ` Jason Wang
2020-11-16 10:22 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 06/12] vdpa_sim: add struct vdpasim_device to store device properties Stefano Garzarella
2020-11-16 4:14 ` Jason Wang
2020-11-16 10:30 ` Stefano Garzarella
2020-11-17 11:23 ` Stefan Hajnoczi
2020-11-17 14:24 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 07/12] vdpa_sim: move config management outside of the core Stefano Garzarella
2020-11-16 4:18 ` Jason Wang
2020-11-16 10:42 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 08/12] vdpa_sim: use kvmalloc to allocate vdpasim->buffer Stefano Garzarella
2020-11-16 4:19 ` Jason Wang
2020-11-13 13:47 ` [PATCH RFC 09/12] vdpa_sim: make vdpasim->buffer size configurable Stefano Garzarella
2020-11-16 4:19 ` Jason Wang
2020-11-13 13:47 ` [PATCH RFC 10/12] vdpa_sim: split vdpasim_virtqueue's iov field in riov and wiov Stefano Garzarella
2020-11-16 4:21 ` Jason Wang
2020-11-17 11:27 ` Stefan Hajnoczi
2020-11-20 14:41 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 11/12] vringh: allow vringh_iov_xfer() to skip bytes when ptr is NULL Stefano Garzarella
2020-11-16 4:32 ` Jason Wang
2020-11-16 11:48 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 12/12] vdpa_sim_blk: implement ramdisk behaviour Stefano Garzarella
2020-11-16 5:25 ` Jason Wang
2020-11-16 11:08 ` Stefano Garzarella
2020-11-16 9:50 ` Michael S. Tsirkin
2020-11-16 11:23 ` Stefano Garzarella
2020-11-17 11:36 ` Stefan Hajnoczi
2020-11-17 14:32 ` Stefano Garzarella
2020-11-16 3:37 ` [PATCH RFC 00/12] vdpa: generalize vdpa simulator and add block device Jason Wang
2020-11-16 8:53 ` Stefano Garzarella
2020-12-18 11:38 ` Stefano Garzarella
2020-12-21 3:16 ` Jason Wang
2020-12-21 11:14 ` Stefano Garzarella
2020-12-22 2:44 ` Jason Wang
2020-12-22 10:57 ` Stefano Garzarella
2020-12-22 12:29 ` Jason Wang
2020-12-22 12:56 ` Jason Wang
2020-12-22 13:23 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117173811.lw4nwicoykhnn3tt@steredhat \
--to=sgarzare@redhat.com \
--cc=elic@nvidia.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).