From: Jason Wang <jasowang@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>,
virtualization@lists.linux-foundation.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
linux-kernel@vger.kernel.org, Eli Cohen <elic@nvidia.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: Re: [PATCH RFC 10/12] vdpa_sim: split vdpasim_virtqueue's iov field in riov and wiov
Date: Mon, 16 Nov 2020 12:21:33 +0800 [thread overview]
Message-ID: <f19a5d14-72b4-4185-183d-84966ee2e5b3@redhat.com> (raw)
In-Reply-To: <20201113134712.69744-11-sgarzare@redhat.com>
On 2020/11/13 下午9:47, Stefano Garzarella wrote:
> vringh_getdesc_iotlb() manages 2 iovs for writable and readable
> descriptors. This is very useful for the block device, where for
> each request we have both types of descriptor.
>
> Let's split the vdpasim_virtqueue's iov field in riov and wiov
> to use them with vringh_getdesc_iotlb().
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/vdpa/vdpa_sim/vdpa_sim.h | 3 ++-
> drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 6 +++---
> drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 8 ++++----
> 3 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.h b/drivers/vdpa/vdpa_sim/vdpa_sim.h
> index cc21e07aa2f7..0d4629675e4b 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim.h
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.h
> @@ -27,7 +27,8 @@ struct vdpasim;
>
> struct vdpasim_virtqueue {
> struct vringh vring;
> - struct vringh_kiov iov;
> + struct vringh_kiov riov;
> + struct vringh_kiov wiov;
> unsigned short head;
> bool ready;
> u64 desc_addr;
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> index 122a3c039507..8e41b3ab98d5 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> @@ -41,13 +41,13 @@ static void vdpasim_blk_work(struct work_struct *work)
> if (!vq->ready)
> continue;
>
> - while (vringh_getdesc_iotlb(&vq->vring, &vq->iov, &vq->iov,
> + while (vringh_getdesc_iotlb(&vq->vring, &vq->riov, &vq->wiov,
> &vq->head, GFP_ATOMIC) > 0) {
>
> int write;
>
> - vq->iov.i = vq->iov.used - 1;
> - write = vringh_iov_push_iotlb(&vq->vring, &vq->iov, &status, 1);
> + vq->wiov.i = vq->wiov.used - 1;
> + write = vringh_iov_push_iotlb(&vq->vring, &vq->wiov, &status, 1);
> if (write <= 0)
> break;
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> index d0a1403f64b2..783b1e85b09c 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> @@ -47,12 +47,12 @@ static void vdpasim_net_work(struct work_struct *work)
>
> while (true) {
> total_write = 0;
> - err = vringh_getdesc_iotlb(&txq->vring, &txq->iov, NULL,
> + err = vringh_getdesc_iotlb(&txq->vring, &txq->riov, NULL,
> &txq->head, GFP_ATOMIC);
> if (err <= 0)
> break;
>
> - err = vringh_getdesc_iotlb(&rxq->vring, NULL, &rxq->iov,
> + err = vringh_getdesc_iotlb(&rxq->vring, NULL, &rxq->wiov,
> &rxq->head, GFP_ATOMIC);
> if (err <= 0) {
> vringh_complete_iotlb(&txq->vring, txq->head, 0);
> @@ -60,13 +60,13 @@ static void vdpasim_net_work(struct work_struct *work)
> }
>
> while (true) {
> - read = vringh_iov_pull_iotlb(&txq->vring, &txq->iov,
> + read = vringh_iov_pull_iotlb(&txq->vring, &txq->riov,
> vdpasim->buffer,
> PAGE_SIZE);
> if (read <= 0)
> break;
>
> - write = vringh_iov_push_iotlb(&rxq->vring, &rxq->iov,
> + write = vringh_iov_push_iotlb(&rxq->vring, &rxq->wiov,
> vdpasim->buffer, read);
> if (write <= 0)
> break;
next prev parent reply other threads:[~2020-11-16 4:21 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 13:47 [PATCH RFC 00/12] vdpa: generalize vdpa simulator and add block device Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 01/12] vhost-vdpa: add support for vDPA blk devices Stefano Garzarella
2020-11-17 10:57 ` Stefan Hajnoczi
2020-11-17 15:05 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 02/12] vdpa: split vdpasim to core and net modules Stefano Garzarella
2020-11-16 4:00 ` Jason Wang
2020-11-16 9:39 ` Stefano Garzarella
2020-11-18 13:14 ` Stefano Garzarella
2020-11-19 6:16 ` Jason Wang
2020-11-13 13:47 ` [PATCH RFC 03/12] vdpa_sim: remove hard-coded virtq count Stefano Garzarella
2020-11-16 4:02 ` Jason Wang
2020-11-13 13:47 ` [PATCH RFC 04/12] vdpa: add vdpa simulator for block device Stefano Garzarella
2020-11-16 4:10 ` Jason Wang
2020-11-16 10:17 ` Stefano Garzarella
2020-11-17 11:11 ` Stefan Hajnoczi
2020-11-17 14:16 ` Stefano Garzarella
2020-11-17 16:43 ` Stefan Hajnoczi
2020-11-17 17:38 ` Stefano Garzarella
2020-11-18 11:23 ` Stefan Hajnoczi
2020-11-18 11:39 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 05/12] vdpa_sim: remove the limit of IOTLB entries Stefano Garzarella
2020-11-16 4:12 ` Jason Wang
2020-11-16 10:22 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 06/12] vdpa_sim: add struct vdpasim_device to store device properties Stefano Garzarella
2020-11-16 4:14 ` Jason Wang
2020-11-16 10:30 ` Stefano Garzarella
2020-11-17 11:23 ` Stefan Hajnoczi
2020-11-17 14:24 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 07/12] vdpa_sim: move config management outside of the core Stefano Garzarella
2020-11-16 4:18 ` Jason Wang
2020-11-16 10:42 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 08/12] vdpa_sim: use kvmalloc to allocate vdpasim->buffer Stefano Garzarella
2020-11-16 4:19 ` Jason Wang
2020-11-13 13:47 ` [PATCH RFC 09/12] vdpa_sim: make vdpasim->buffer size configurable Stefano Garzarella
2020-11-16 4:19 ` Jason Wang
2020-11-13 13:47 ` [PATCH RFC 10/12] vdpa_sim: split vdpasim_virtqueue's iov field in riov and wiov Stefano Garzarella
2020-11-16 4:21 ` Jason Wang [this message]
2020-11-17 11:27 ` Stefan Hajnoczi
2020-11-20 14:41 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 11/12] vringh: allow vringh_iov_xfer() to skip bytes when ptr is NULL Stefano Garzarella
2020-11-16 4:32 ` Jason Wang
2020-11-16 11:48 ` Stefano Garzarella
2020-11-13 13:47 ` [PATCH RFC 12/12] vdpa_sim_blk: implement ramdisk behaviour Stefano Garzarella
2020-11-16 5:25 ` Jason Wang
2020-11-16 11:08 ` Stefano Garzarella
2020-11-16 9:50 ` Michael S. Tsirkin
2020-11-16 11:23 ` Stefano Garzarella
2020-11-17 11:36 ` Stefan Hajnoczi
2020-11-17 14:32 ` Stefano Garzarella
2020-11-16 3:37 ` [PATCH RFC 00/12] vdpa: generalize vdpa simulator and add block device Jason Wang
2020-11-16 8:53 ` Stefano Garzarella
2020-12-18 11:38 ` Stefano Garzarella
2020-12-21 3:16 ` Jason Wang
2020-12-21 11:14 ` Stefano Garzarella
2020-12-22 2:44 ` Jason Wang
2020-12-22 10:57 ` Stefano Garzarella
2020-12-22 12:29 ` Jason Wang
2020-12-22 12:56 ` Jason Wang
2020-12-22 13:23 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f19a5d14-72b4-4185-183d-84966ee2e5b3@redhat.com \
--to=jasowang@redhat.com \
--cc=elic@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).