linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: update RANDOMIZE_MODULE_REGION_FULL config description
@ 2020-11-22  7:08 youngjun
  2020-11-23 11:12 ` Will Deacon
  0 siblings, 1 reply; 2+ messages in thread
From: youngjun @ 2020-11-22  7:08 UTC (permalink / raw)
  To: Will Deacon, Catalin Marinas; +Cc: linux-arm-kernel, linux-kernel, youngjun

module randomization is reduced. (range to 2 GB)
RANDOMIZE_MODULE_REGION_FULL config description is not updated.
update RANDOMIZE_MODULE_REGION_FULL config description.

Signed-off-by: youngjun <her0gyugyu@gmail.com>
---
 arch/arm64/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 1515f6f153a0..0da551828a59 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -1804,11 +1804,11 @@ config RANDOMIZE_BASE
 	  If unsure, say N.
 
 config RANDOMIZE_MODULE_REGION_FULL
-	bool "Randomize the module region over a 4 GB range"
+	bool "Randomize the module region over a 2 GB range"
 	depends on RANDOMIZE_BASE
 	default y
 	help
-	  Randomizes the location of the module region inside a 4 GB window
+	  Randomizes the location of the module region inside a 2 GB window
 	  covering the core kernel. This way, it is less likely for modules
 	  to leak information about the location of core kernel data structures
 	  but it does imply that function calls between modules and the core
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: update RANDOMIZE_MODULE_REGION_FULL config description
  2020-11-22  7:08 [PATCH] arm64: update RANDOMIZE_MODULE_REGION_FULL config description youngjun
@ 2020-11-23 11:12 ` Will Deacon
  0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2020-11-23 11:12 UTC (permalink / raw)
  To: youngjun, rossmeikleham; +Cc: Catalin Marinas, linux-arm-kernel, linux-kernel

On Sat, Nov 21, 2020 at 11:08:55PM -0800, youngjun wrote:
> module randomization is reduced. (range to 2 GB)
> RANDOMIZE_MODULE_REGION_FULL config description is not updated.
> update RANDOMIZE_MODULE_REGION_FULL config description.
> 
> Signed-off-by: youngjun <her0gyugyu@gmail.com>
> ---
>  arch/arm64/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This looks like the same patch as the one I reviewed here:

https://lore.kernel.org/r/20201109112705.GC14356@willie-the-truck

but the commit message isn't a lot better. Please could you (or Ross)
post a version with a fixed commit message?

Thanks,

Will

> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 1515f6f153a0..0da551828a59 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1804,11 +1804,11 @@ config RANDOMIZE_BASE
>  	  If unsure, say N.
>  
>  config RANDOMIZE_MODULE_REGION_FULL
> -	bool "Randomize the module region over a 4 GB range"
> +	bool "Randomize the module region over a 2 GB range"
>  	depends on RANDOMIZE_BASE
>  	default y
>  	help
> -	  Randomizes the location of the module region inside a 4 GB window
> +	  Randomizes the location of the module region inside a 2 GB window
>  	  covering the core kernel. This way, it is less likely for modules
>  	  to leak information about the location of core kernel data structures
>  	  but it does imply that function calls between modules and the core
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-23 11:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-22  7:08 [PATCH] arm64: update RANDOMIZE_MODULE_REGION_FULL config description youngjun
2020-11-23 11:12 ` Will Deacon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).