* [PATCH v2] usb: musb: remove unused variable 'devctl'
@ 2020-11-24 6:36 min.guo
2020-11-24 7:24 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: min.guo @ 2020-11-24 6:36 UTC (permalink / raw)
To: Bin Liu
Cc: Greg Kroah-Hartman, Alan Stern, Matthias Brugger, chunfeng.yun,
linux-usb, linux-kernel, linux-arm-kernel, linux-mediatek,
Min Guo
From: Min Guo <min.guo@mediatek.com>
Remove unused 'devctl' variable to fix compile warnings:
drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq':
drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set
but not used [-Wunused-but-set-variable]
Signed-off-by: Min Guo <min.guo@mediatek.com>
---
changes in v2
suggested by Alan Stern:
Add void before musb_read to indicate that the register MUSB_DEVCTL
was intended to be read and discarded.
---
drivers/usb/musb/musbhsdma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c
index 0aacfc8be5a1..f59a009c533e 100644
--- a/drivers/usb/musb/musbhsdma.c
+++ b/drivers/usb/musb/musbhsdma.c
@@ -321,8 +321,6 @@ irqreturn_t dma_controller_irq(int irq, void *private_data)
musb_channel->channel.status =
MUSB_DMA_STATUS_BUS_ABORT;
} else {
- u8 devctl;
-
addr = musb_read_hsdma_addr(mbase,
bchannel);
channel->actual_len = addr
@@ -336,7 +334,7 @@ irqreturn_t dma_controller_irq(int irq, void *private_data)
< musb_channel->len) ?
"=> reconfig 0" : "=> complete");
- devctl = musb_readb(mbase, MUSB_DEVCTL);
+ (void)musb_readb(mbase, MUSB_DEVCTL);
channel->status = MUSB_DMA_STATUS_FREE;
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] usb: musb: remove unused variable 'devctl'
2020-11-24 6:36 [PATCH v2] usb: musb: remove unused variable 'devctl' min.guo
@ 2020-11-24 7:24 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2020-11-24 7:24 UTC (permalink / raw)
To: min.guo
Cc: Bin Liu, Alan Stern, Matthias Brugger, chunfeng.yun, linux-usb,
linux-kernel, linux-arm-kernel, linux-mediatek
On Tue, Nov 24, 2020 at 02:36:13PM +0800, min.guo@mediatek.com wrote:
> From: Min Guo <min.guo@mediatek.com>
>
> Remove unused 'devctl' variable to fix compile warnings:
>
> drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq':
> drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set
> but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Min Guo <min.guo@mediatek.com>
> ---
> changes in v2
> suggested by Alan Stern:
> Add void before musb_read to indicate that the register MUSB_DEVCTL
> was intended to be read and discarded.
> ---
> drivers/usb/musb/musbhsdma.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c
> index 0aacfc8be5a1..f59a009c533e 100644
> --- a/drivers/usb/musb/musbhsdma.c
> +++ b/drivers/usb/musb/musbhsdma.c
> @@ -321,8 +321,6 @@ irqreturn_t dma_controller_irq(int irq, void *private_data)
> musb_channel->channel.status =
> MUSB_DMA_STATUS_BUS_ABORT;
> } else {
> - u8 devctl;
> -
> addr = musb_read_hsdma_addr(mbase,
> bchannel);
> channel->actual_len = addr
> @@ -336,7 +334,7 @@ irqreturn_t dma_controller_irq(int irq, void *private_data)
> < musb_channel->len) ?
> "=> reconfig 0" : "=> complete");
>
> - devctl = musb_readb(mbase, MUSB_DEVCTL);
> + (void)musb_readb(mbase, MUSB_DEVCTL);
Please put a comment here as to why the read is happening so that people
do not throw it away sometime in the future.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-24 7:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-24 6:36 [PATCH v2] usb: musb: remove unused variable 'devctl' min.guo
2020-11-24 7:24 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).