[PATCH] pinctrl: core: Fix unused variable build warnings

* [PATCH] pinctrl: core: Fix unused variable build warnings
@ 2020-11-23 22:33 Pawan Gupta
  2020-11-24  5:06 ` Drew Fustini
  2020-12-01 23:06 ` Linus Walleij
  0 siblings, 2 replies; 5+ messages in thread
From: Pawan Gupta @ 2020-11-23 22:33 UTC (permalink / raw)
  To: Linus Walleij, linux-gpio; +Cc: linux-kernel, Drew Fustini

A recent commit f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs
file") added build warnings when CONFIG_GPIOLIB=n. Offcourse the kernel
fails to build when warnings are treated as errors. Below is the error
message:

  $ make CFLAGS_KERNEL+=-Werror

  drivers/pinctrl/core.c: In function ‘pinctrl_pins_show’:
  drivers/pinctrl/core.c:1607:20: error: unused variable ‘chip’ [-Werror=unused-variable]
   1607 |  struct gpio_chip *chip;
        |                    ^~~~
  drivers/pinctrl/core.c:1606:15: error: unused variable ‘gpio_num’ [-Werror=unused-variable]
   1606 |  unsigned int gpio_num;
        |               ^~~~~~~~
  drivers/pinctrl/core.c:1605:29: error: unused variable ‘range’ [-Werror=unused-variable]
   1605 |  struct pinctrl_gpio_range *range;
        |                             ^~~~~
  cc1: all warnings being treated as errors

These variables are only used inside #ifdef CONFIG_GPIOLIB, fix the
build warnings by wrapping the definition inside the config.

Fixes: f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs file")
Signed-off-by: Pawan Gupta <writetopawan@gmail.com>
---
 drivers/pinctrl/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 3663d87f51a0..1bb371a5cf8d 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1602,10 +1602,11 @@ static int pinctrl_pins_show(struct seq_file *s, void *what)
 	struct pinctrl_dev *pctldev = s->private;
 	const struct pinctrl_ops *ops = pctldev->desc->pctlops;
 	unsigned i, pin;
+#ifdef CONFIG_GPIOLIB
 	struct pinctrl_gpio_range *range;
 	unsigned int gpio_num;
 	struct gpio_chip *chip;
-
+#endif
 	seq_printf(s, "registered pins: %d\n", pctldev->desc->npins);
 
 	mutex_lock(&pctldev->mutex);
-- 
2.21.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread