* [PATCH] platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init
@ 2020-11-25 6:50 Qinglang Miao
2020-11-25 17:05 ` Hans de Goede
2020-12-02 12:11 ` Hans de Goede
0 siblings, 2 replies; 4+ messages in thread
From: Qinglang Miao @ 2020-11-25 6:50 UTC (permalink / raw)
To: Hans de Goede, Mark Gross
Cc: platform-driver-x86, linux-kernel, Qinglang Miao
Fix to return the error code -ENODEV when fails to init wmi and
smm.
Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-* modules together")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
drivers/platform/x86/dell-smbios-base.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c
index 2e2cd5659..3a1dbf199 100644
--- a/drivers/platform/x86/dell-smbios-base.c
+++ b/drivers/platform/x86/dell-smbios-base.c
@@ -594,6 +594,7 @@ static int __init dell_smbios_init(void)
if (wmi && smm) {
pr_err("No SMBIOS backends available (wmi: %d, smm: %d)\n",
wmi, smm);
+ ret = -ENODEV;
goto fail_create_group;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init
2020-11-25 6:50 [PATCH] platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init Qinglang Miao
@ 2020-11-25 17:05 ` Hans de Goede
2020-11-30 21:50 ` Limonciello, Mario
2020-12-02 12:11 ` Hans de Goede
1 sibling, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2020-11-25 17:05 UTC (permalink / raw)
To: Qinglang Miao, Mark Gross, Limonciello, Mario
Cc: platform-driver-x86, linux-kernel
Hi,
+Cc Mario
On 11/25/20 7:50 AM, Qinglang Miao wrote:
> Fix to return the error code -ENODEV when fails to init wmi and
> smm.
>
> Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-* modules together")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Mario, this seems like a trivial fix to me, but I'm not 100% sure, any comments on this?
Regards,
Hans
> ---
> drivers/platform/x86/dell-smbios-base.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c
> index 2e2cd5659..3a1dbf199 100644
> --- a/drivers/platform/x86/dell-smbios-base.c
> +++ b/drivers/platform/x86/dell-smbios-base.c
> @@ -594,6 +594,7 @@ static int __init dell_smbios_init(void)
> if (wmi && smm) {
> pr_err("No SMBIOS backends available (wmi: %d, smm: %d)\n",
> wmi, smm);
> + ret = -ENODEV;
> goto fail_create_group;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init
2020-11-25 17:05 ` Hans de Goede
@ 2020-11-30 21:50 ` Limonciello, Mario
0 siblings, 0 replies; 4+ messages in thread
From: Limonciello, Mario @ 2020-11-30 21:50 UTC (permalink / raw)
To: Hans de Goede, Qinglang Miao, Mark Gross
Cc: platform-driver-x86, linux-kernel
>
> Hi,
>
> +Cc Mario
>
> On 11/25/20 7:50 AM, Qinglang Miao wrote:
> > Fix to return the error code -ENODEV when fails to init wmi and
> > smm.
> >
> > Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-*
> modules together")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
>
> Mario, this seems like a trivial fix to me, but I'm not 100% sure, any
> comments on this?
>
> Regards,
>
> Hans
Yeah, it's reasonable to me.
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
>
>
> > ---
> > drivers/platform/x86/dell-smbios-base.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/dell-smbios-base.c
> b/drivers/platform/x86/dell-smbios-base.c
> > index 2e2cd5659..3a1dbf199 100644
> > --- a/drivers/platform/x86/dell-smbios-base.c
> > +++ b/drivers/platform/x86/dell-smbios-base.c
> > @@ -594,6 +594,7 @@ static int __init dell_smbios_init(void)
> > if (wmi && smm) {
> > pr_err("No SMBIOS backends available (wmi: %d, smm: %d)\n",
> > wmi, smm);
> > + ret = -ENODEV;
> > goto fail_create_group;
> > }
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init
2020-11-25 6:50 [PATCH] platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init Qinglang Miao
2020-11-25 17:05 ` Hans de Goede
@ 2020-12-02 12:11 ` Hans de Goede
1 sibling, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2020-12-02 12:11 UTC (permalink / raw)
To: Qinglang Miao, Mark Gross; +Cc: platform-driver-x86, linux-kernel
Hi,
On 11/25/20 7:50 AM, Qinglang Miao wrote:
> Fix to return the error code -ENODEV when fails to init wmi and
> smm.
>
> Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-* modules together")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/dell-smbios-base.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c
> index 2e2cd5659..3a1dbf199 100644
> --- a/drivers/platform/x86/dell-smbios-base.c
> +++ b/drivers/platform/x86/dell-smbios-base.c
> @@ -594,6 +594,7 @@ static int __init dell_smbios_init(void)
> if (wmi && smm) {
> pr_err("No SMBIOS backends available (wmi: %d, smm: %d)\n",
> wmi, smm);
> + ret = -ENODEV;
> goto fail_create_group;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-02 12:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-25 6:50 [PATCH] platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init Qinglang Miao
2020-11-25 17:05 ` Hans de Goede
2020-11-30 21:50 ` Limonciello, Mario
2020-12-02 12:11 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).