* [PATCH v2] leds: lp50xx: add missing fwnode_handle_put in error handling case
@ 2020-11-19 7:08 Qinglang Miao
2020-11-19 21:10 ` Dan Murphy
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Qinglang Miao @ 2020-11-19 7:08 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy; +Cc: linux-leds, linux-kernel, Qinglang Miao
Fix to set ret and goto child_out for fwnode_handle_put(child)
in the error handling case rather than simply return, as done
elsewhere in this function.
Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Suggested-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
v2: forget to set ret on v1
drivers/leds/leds-lp50xx.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
index 5fb4f24ae..f13117eed 100644
--- a/drivers/leds/leds-lp50xx.c
+++ b/drivers/leds/leds-lp50xx.c
@@ -487,8 +487,10 @@ static int lp50xx_probe_dt(struct lp50xx *priv)
*/
mc_led_info = devm_kcalloc(priv->dev, LP50XX_LEDS_PER_MODULE,
sizeof(*mc_led_info), GFP_KERNEL);
- if (!mc_led_info)
- return -ENOMEM;
+ if (!mc_led_info) {
+ ret = -ENOMEM;
+ goto child_out;
+ }
fwnode_for_each_child_node(child, led_node) {
ret = fwnode_property_read_u32(led_node, "color",
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] leds: lp50xx: add missing fwnode_handle_put in error handling case
2020-11-19 7:08 [PATCH v2] leds: lp50xx: add missing fwnode_handle_put in error handling case Qinglang Miao
@ 2020-11-19 21:10 ` Dan Murphy
2020-11-25 19:48 ` Pavel Machek
2020-11-25 19:50 ` Pavel Machek
2 siblings, 0 replies; 4+ messages in thread
From: Dan Murphy @ 2020-11-19 21:10 UTC (permalink / raw)
To: Qinglang Miao, Pavel Machek; +Cc: linux-leds, linux-kernel
Hello
On 11/19/20 1:08 AM, Qinglang Miao wrote:
> Fix to set ret and goto child_out for fwnode_handle_put(child)
> in the error handling case rather than simply return, as done
> elsewhere in this function.
>
> Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Suggested-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> v2: forget to set ret on v1
>
> drivers/leds/leds-lp50xx.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
> index 5fb4f24ae..f13117eed 100644
> --- a/drivers/leds/leds-lp50xx.c
> +++ b/drivers/leds/leds-lp50xx.c
> @@ -487,8 +487,10 @@ static int lp50xx_probe_dt(struct lp50xx *priv)
> */
> mc_led_info = devm_kcalloc(priv->dev, LP50XX_LEDS_PER_MODULE,
> sizeof(*mc_led_info), GFP_KERNEL);
> - if (!mc_led_info)
> - return -ENOMEM;
> + if (!mc_led_info) {
> + ret = -ENOMEM;
> + goto child_out;
> + }
>
> fwnode_for_each_child_node(child, led_node) {
> ret = fwnode_property_read_u32(led_node, "color",
Reviewed-by: Dan Murphy <dmurphy@ti.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] leds: lp50xx: add missing fwnode_handle_put in error handling case
2020-11-19 7:08 [PATCH v2] leds: lp50xx: add missing fwnode_handle_put in error handling case Qinglang Miao
2020-11-19 21:10 ` Dan Murphy
@ 2020-11-25 19:48 ` Pavel Machek
2020-11-25 19:50 ` Pavel Machek
2 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2020-11-25 19:48 UTC (permalink / raw)
To: Qinglang Miao; +Cc: Dan Murphy, linux-leds, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
Hi!
> Fix to set ret and goto child_out for fwnode_handle_put(child)
> in the error handling case rather than simply return, as done
> elsewhere in this function.
>
> Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Suggested-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Thanks, applied.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] leds: lp50xx: add missing fwnode_handle_put in error handling case
2020-11-19 7:08 [PATCH v2] leds: lp50xx: add missing fwnode_handle_put in error handling case Qinglang Miao
2020-11-19 21:10 ` Dan Murphy
2020-11-25 19:48 ` Pavel Machek
@ 2020-11-25 19:50 ` Pavel Machek
2 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2020-11-25 19:50 UTC (permalink / raw)
To: Qinglang Miao; +Cc: Dan Murphy, linux-leds, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Thu 2020-11-19 15:08:41, Qinglang Miao wrote:
> Fix to set ret and goto child_out for fwnode_handle_put(child)
> in the error handling case rather than simply return, as done
> elsewhere in this function.
>
> Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Suggested-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Sorry, spoke too fast. We already had equivalent patch in by
Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the
RGB LED driver")
Signed-off-by: Christophe JAILLET
<christophe.jaillet@wanadoo.fr>
Let me push that out in few minutes.. so you can double-check.
Sorry for confusion,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-25 19:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 7:08 [PATCH v2] leds: lp50xx: add missing fwnode_handle_put in error handling case Qinglang Miao
2020-11-19 21:10 ` Dan Murphy
2020-11-25 19:48 ` Pavel Machek
2020-11-25 19:50 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).