* [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition
@ 2020-11-27 18:27 trix
2020-11-30 9:17 ` Daniel Wagner
0 siblings, 1 reply; 5+ messages in thread
From: trix @ 2020-11-27 18:27 UTC (permalink / raw)
To: njavali, jejb, martin.petersen
Cc: GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
The macro use will already have a semicolon.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/scsi/qla2xxx/qla_def.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
index ed9b10f8537d..86d249551b2d 100644
--- a/drivers/scsi/qla2xxx/qla_def.h
+++ b/drivers/scsi/qla2xxx/qla_def.h
@@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
} while (0)
#define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \
- atomic_dec(&__qpair->ref_count); \
+ atomic_dec(&__qpair->ref_count) \
#define QLA_ENA_CONF(_ha) {\
--
2.18.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition
2020-11-27 18:27 [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition trix
@ 2020-11-30 9:17 ` Daniel Wagner
[not found] ` <CAHo-Oow4nPR9ODya-cPHZrsMFFPF9aUJJXfrFqLCxRzmJVMrmA@mail.gmail.com>
2020-11-30 16:16 ` Tom Rix
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Wagner @ 2020-11-30 9:17 UTC (permalink / raw)
To: trix
Cc: njavali, jejb, martin.petersen, GR-QLogic-Storage-Upstream,
linux-scsi, linux-kernel
Hi Tom,
On Fri, Nov 27, 2020 at 10:27:41AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
> ---
> drivers/scsi/qla2xxx/qla_def.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
> index ed9b10f8537d..86d249551b2d 100644
> --- a/drivers/scsi/qla2xxx/qla_def.h
> +++ b/drivers/scsi/qla2xxx/qla_def.h
> @@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
> } while (0)
>
> #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \
> - atomic_dec(&__qpair->ref_count); \
> + atomic_dec(&__qpair->ref_count) \
Nitpick, please insert an additional tab after the remove so that the
backlashes align again.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition
[not found] ` <CAHo-Oow4nPR9ODya-cPHZrsMFFPF9aUJJXfrFqLCxRzmJVMrmA@mail.gmail.com>
@ 2020-11-30 9:34 ` Daniel Wagner
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Wagner @ 2020-11-30 9:34 UTC (permalink / raw)
To: Maciej Żenczykowski
Cc: trix, njavali, jejb, Martin K . Petersen,
GR-QLogic-Storage-Upstream, linux-scsi,
Linux Kernel Mailing List
On Mon, Nov 30, 2020 at 01:29:19AM -0800, Maciej Żenczykowski wrote:
> On Mon, Nov 30, 2020 at 1:23 AM Daniel Wagner <dwagner@suse.de> wrote:
> > > #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \
> > > - atomic_dec(&__qpair->ref_count); \
> > > + atomic_dec(&__qpair->ref_count) \
> >
> > Nitpick, please insert an additional tab after the remove so that the
> > backlashes align again.
> >
>
> Uhm, if there's no semicolon, then presumably it's the final line of the
> macro, and thus there should be no tabs and no backslash at the end of the
> line.
Right! Didn't realize it. The backslash should be removed.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition
2020-11-30 9:17 ` Daniel Wagner
[not found] ` <CAHo-Oow4nPR9ODya-cPHZrsMFFPF9aUJJXfrFqLCxRzmJVMrmA@mail.gmail.com>
@ 2020-11-30 16:16 ` Tom Rix
2020-11-30 16:30 ` Daniel Wagner
1 sibling, 1 reply; 5+ messages in thread
From: Tom Rix @ 2020-11-30 16:16 UTC (permalink / raw)
To: Daniel Wagner
Cc: njavali, jejb, martin.petersen, GR-QLogic-Storage-Upstream,
linux-scsi, linux-kernel
On 11/30/20 1:17 AM, Daniel Wagner wrote:
> Hi Tom,
>
> On Fri, Nov 27, 2020 at 10:27:41AM -0800, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> The macro use will already have a semicolon.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Daniel Wagner <dwagner@suse.de>
>
>> ---
>> drivers/scsi/qla2xxx/qla_def.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
>> index ed9b10f8537d..86d249551b2d 100644
>> --- a/drivers/scsi/qla2xxx/qla_def.h
>> +++ b/drivers/scsi/qla2xxx/qla_def.h
>> @@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
>> } while (0)
>>
>> #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \
>> - atomic_dec(&__qpair->ref_count); \
>> + atomic_dec(&__qpair->ref_count) \
> Nitpick, please insert an additional tab after the remove so that the
> backlashes align again.
How about removing the last escaped newline and the next empty line ?
Tom
>
> Thanks,
> Daniel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition
2020-11-30 16:16 ` Tom Rix
@ 2020-11-30 16:30 ` Daniel Wagner
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Wagner @ 2020-11-30 16:30 UTC (permalink / raw)
To: Tom Rix
Cc: njavali, jejb, martin.petersen, GR-QLogic-Storage-Upstream,
linux-scsi, linux-kernel
> >> #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \
> >> - atomic_dec(&__qpair->ref_count); \
> >> + atomic_dec(&__qpair->ref_count) \
> > Nitpick, please insert an additional tab after the remove so that the
> > backlashes align again.
>
> How about removing the last escaped newline and the next empty line ?
Yes please.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-30 16:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 18:27 [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition trix
2020-11-30 9:17 ` Daniel Wagner
[not found] ` <CAHo-Oow4nPR9ODya-cPHZrsMFFPF9aUJJXfrFqLCxRzmJVMrmA@mail.gmail.com>
2020-11-30 9:34 ` Daniel Wagner
2020-11-30 16:16 ` Tom Rix
2020-11-30 16:30 ` Daniel Wagner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).