linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] x86/platform: classmate-laptop: add WiFi media button
@ 2020-12-08  6:11 Chris Chiu
  2020-12-08 10:18 ` Hans de Goede
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Chiu @ 2020-12-08  6:11 UTC (permalink / raw)
  To: cascardo, don, dvhart, andy
  Cc: platform-driver-x86, linux-kernel, linux, Carlo Caione, Chris Chiu

From: Carlo Caione <carlo@endlessm.com>

The WiFi media button on the Quanta NL3 reports keycodes 0x8b and 0x9b
to the platform driver. Add the mapping to support these codes.

Signed-off-by: Carlo Caione <carlo@endlessm.com>
Reviewed-by: Chris Chiu <chiu@endlessos.org>
---
 drivers/platform/x86/classmate-laptop.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
index af063f690846..3e03e8d3a07f 100644
--- a/drivers/platform/x86/classmate-laptop.c
+++ b/drivers/platform/x86/classmate-laptop.c
@@ -1023,6 +1023,8 @@ static int cmpc_keys_codes[] = {
 	KEY_CAMERA,
 	KEY_BACK,
 	KEY_FORWARD,
+	KEY_UNKNOWN,
+	KEY_WLAN, /* NL3: 0x8b (press), 0x9b (release) */
 	KEY_MAX
 };
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86/platform: classmate-laptop: add WiFi media button
  2020-12-08  6:11 [PATCH] x86/platform: classmate-laptop: add WiFi media button Chris Chiu
@ 2020-12-08 10:18 ` Hans de Goede
  0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2020-12-08 10:18 UTC (permalink / raw)
  To: Chris Chiu, cascardo, don, dvhart, andy
  Cc: platform-driver-x86, linux-kernel, linux, Carlo Caione

Hi,

On 12/8/20 7:11 AM, Chris Chiu wrote:
> From: Carlo Caione <carlo@endlessm.com>
> 
> The WiFi media button on the Quanta NL3 reports keycodes 0x8b and 0x9b
> to the platform driver. Add the mapping to support these codes.
> 
> Signed-off-by: Carlo Caione <carlo@endlessm.com>
> Reviewed-by: Chris Chiu <chiu@endlessos.org>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/classmate-laptop.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index af063f690846..3e03e8d3a07f 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -1023,6 +1023,8 @@ static int cmpc_keys_codes[] = {
>  	KEY_CAMERA,
>  	KEY_BACK,
>  	KEY_FORWARD,
> +	KEY_UNKNOWN,
> +	KEY_WLAN, /* NL3: 0x8b (press), 0x9b (release) */
>  	KEY_MAX
>  };
>  
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-08 10:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08  6:11 [PATCH] x86/platform: classmate-laptop: add WiFi media button Chris Chiu
2020-12-08 10:18 ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).