* [PATCH v2 0/2] rockchip: emmc: rk3399 add vendor prefix
@ 2020-12-15 1:44 Chris Ruehl
2020-12-15 1:44 ` [PATCH v2 1/2] devicetree: phy: rockchip-emmc optional " Chris Ruehl
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Ruehl @ 2020-12-15 1:44 UTC (permalink / raw)
To: Chris Ruehl
Cc: Rob Herring, devicetree, Kishon Vijay Abraham I, Vinod Koul,
Heiko Stuebner, linux-kernel, linux-arm-kernel, linux-rockchip
Following the reference in vendor-prefixes.yaml, update implementation
and documentation for the phy-rockchip-emmc.
This patchset follow up with
commit 8b5c2b45b8f0a ("phy: rockchip: set pulldown for strobe line in dts")
commit a8cef928276bb ("phy: rockchip-emmc: output tap delay dt property")
Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
v2 drop changes for ABI property driver-impedence-ohm
no modification needed for dtsi files
add commits follow up in commit messages
Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 10 +++++-----
drivers/phy/rockchip/phy-rockchip-emmc.c | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] devicetree: phy: rockchip-emmc optional add vendor prefix
2020-12-15 1:44 [PATCH v2 0/2] rockchip: emmc: rk3399 add vendor prefix Chris Ruehl
@ 2020-12-15 1:44 ` Chris Ruehl
2020-12-15 18:18 ` Rob Herring
2020-12-15 1:44 ` [PATCH v2 2/2] phy: rockchip: emmc, add vendor prefix to dts properties Chris Ruehl
2021-01-13 11:54 ` [PATCH v2 0/2] rockchip: emmc: rk3399 add vendor prefix Vinod Koul
2 siblings, 1 reply; 5+ messages in thread
From: Chris Ruehl @ 2020-12-15 1:44 UTC (permalink / raw)
To: Chris Ruehl
Cc: Rob Herring, devicetree, Kishon Vijay Abraham I, Vinod Koul,
Rob Herring, Heiko Stuebner, linux-kernel, linux-arm-kernel,
linux-rockchip
Update the documentation and add the vendor prefix to the optional
properties referred in vendor-prefixes.yaml.
Follow up with
commit 8b5c2b45b8f0a ("phy: rockchip: set pulldown for strobe line in dts")
commit a8cef928276bb ("phy: rockchip-emmc: output tap delay dt property")
Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
.../devicetree/bindings/phy/rockchip-emmc-phy.txt | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
index 00aa2d349e55..57d28c0d5696 100644
--- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
+++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
@@ -16,11 +16,11 @@ Optional properties:
- drive-impedance-ohm: Specifies the drive impedance in Ohm.
Possible values are 33, 40, 50, 66 and 100.
If not set, the default value of 50 will be applied.
- - enable-strobe-pulldown: Enable internal pull-down for the strobe line.
- If not set, pull-down is not used.
- - output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
- If not set, the register defaults to 0x4.
- Maximum value 0xf.
+ - rockchip,enable-strobe-pulldown: Enable internal pull-down for the strobe
+ line. If not set, pull-down is not used.
+ - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
+ If not set, the register defaults to 0x4.
+ Maximum value 0xf.
Example:
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] phy: rockchip: emmc, add vendor prefix to dts properties
2020-12-15 1:44 [PATCH v2 0/2] rockchip: emmc: rk3399 add vendor prefix Chris Ruehl
2020-12-15 1:44 ` [PATCH v2 1/2] devicetree: phy: rockchip-emmc optional " Chris Ruehl
@ 2020-12-15 1:44 ` Chris Ruehl
2021-01-13 11:54 ` [PATCH v2 0/2] rockchip: emmc: rk3399 add vendor prefix Vinod Koul
2 siblings, 0 replies; 5+ messages in thread
From: Chris Ruehl @ 2020-12-15 1:44 UTC (permalink / raw)
To: Chris Ruehl
Cc: Rob Herring, devicetree, Kishon Vijay Abraham I, Vinod Koul,
Heiko Stuebner, linux-kernel, linux-arm-kernel, linux-rockchip
Update the implementation add "rockchip," vendor prefix for the
optional dts properties. Prefix referred from vendor-prefixes.yaml.
Follow up with
commit 8b5c2b45b8f0a ("phy: rockchip: set pulldown for strobe line in dts")
commit a8cef928276bb ("phy: rockchip-emmc: output tap delay dt property")
Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
drivers/phy/rockchip/phy-rockchip-emmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchip/phy-rockchip-emmc.c
index 1e424f263e7a..860b2fbbb092 100644
--- a/drivers/phy/rockchip/phy-rockchip-emmc.c
+++ b/drivers/phy/rockchip/phy-rockchip-emmc.c
@@ -380,10 +380,10 @@ static int rockchip_emmc_phy_probe(struct platform_device *pdev)
if (!of_property_read_u32(dev->of_node, "drive-impedance-ohm", &val))
rk_phy->drive_impedance = convert_drive_impedance_ohm(pdev, val);
- if (of_property_read_bool(dev->of_node, "enable-strobe-pulldown"))
+ if (of_property_read_bool(dev->of_node, "rockchip,enable-strobe-pulldown"))
rk_phy->enable_strobe_pulldown = PHYCTRL_REN_STRB_ENABLE;
- if (!of_property_read_u32(dev->of_node, "output-tapdelay-select", &val)) {
+ if (!of_property_read_u32(dev->of_node, "rockchip,output-tapdelay-select", &val)) {
if (val <= PHYCTRL_OTAPDLYSEL_MAXVALUE)
rk_phy->output_tapdelay_select = val;
else
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] devicetree: phy: rockchip-emmc optional add vendor prefix
2020-12-15 1:44 ` [PATCH v2 1/2] devicetree: phy: rockchip-emmc optional " Chris Ruehl
@ 2020-12-15 18:18 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2020-12-15 18:18 UTC (permalink / raw)
To: Chris Ruehl
Cc: Rob Herring, linux-arm-kernel, Vinod Koul, linux-rockchip,
devicetree, linux-kernel, Kishon Vijay Abraham I, Heiko Stuebner
On Tue, 15 Dec 2020 09:44:07 +0800, Chris Ruehl wrote:
> Update the documentation and add the vendor prefix to the optional
> properties referred in vendor-prefixes.yaml.
> Follow up with
> commit 8b5c2b45b8f0a ("phy: rockchip: set pulldown for strobe line in dts")
> commit a8cef928276bb ("phy: rockchip-emmc: output tap delay dt property")
These could be Fixes tags.
>
> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
> ---
> .../devicetree/bindings/phy/rockchip-emmc-phy.txt | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
TBC, this needs to be applied for v5.11.
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/2] rockchip: emmc: rk3399 add vendor prefix
2020-12-15 1:44 [PATCH v2 0/2] rockchip: emmc: rk3399 add vendor prefix Chris Ruehl
2020-12-15 1:44 ` [PATCH v2 1/2] devicetree: phy: rockchip-emmc optional " Chris Ruehl
2020-12-15 1:44 ` [PATCH v2 2/2] phy: rockchip: emmc, add vendor prefix to dts properties Chris Ruehl
@ 2021-01-13 11:54 ` Vinod Koul
2 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2021-01-13 11:54 UTC (permalink / raw)
To: Chris Ruehl
Cc: Rob Herring, devicetree, Kishon Vijay Abraham I, Heiko Stuebner,
linux-kernel, linux-arm-kernel, linux-rockchip
On 15-12-20, 09:44, Chris Ruehl wrote:
> Following the reference in vendor-prefixes.yaml, update implementation
> and documentation for the phy-rockchip-emmc.
> This patchset follow up with
> commit 8b5c2b45b8f0a ("phy: rockchip: set pulldown for strobe line in dts")
> commit a8cef928276bb ("phy: rockchip-emmc: output tap delay dt property")
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-13 11:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-15 1:44 [PATCH v2 0/2] rockchip: emmc: rk3399 add vendor prefix Chris Ruehl
2020-12-15 1:44 ` [PATCH v2 1/2] devicetree: phy: rockchip-emmc optional " Chris Ruehl
2020-12-15 18:18 ` Rob Herring
2020-12-15 1:44 ` [PATCH v2 2/2] phy: rockchip: emmc, add vendor prefix to dts properties Chris Ruehl
2021-01-13 11:54 ` [PATCH v2 0/2] rockchip: emmc: rk3399 add vendor prefix Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).