[PATCH v2 0/2] rockchip: emmc: rk3399 add vendor prefix

[PATCH v2 0/2] rockchip: emmc: rk3399 add vendor prefix

[Chris Ruehl]

Following the reference in vendor-prefixes.yaml, update implementation
and documentation for the phy-rockchip-emmc.
This patchset follow up with 
commit 8b5c2b45b8f0a ("phy: rockchip: set pulldown for strobe line in dts")
commit a8cef928276bb ("phy: rockchip-emmc: output tap delay dt property")

Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
v2 drop changes for ABI property driver-impedence-ohm
   no modification needed for dtsi files
   add commits follow up in commit messages

Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 10 +++++-----
drivers/phy/rockchip/phy-rockchip-emmc.c                    |  4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)

[PATCH v2 1/2] devicetree: phy: rockchip-emmc optional add vendor prefix

[Chris Ruehl]

Update the documentation and add the vendor prefix to the optional
properties referred in vendor-prefixes.yaml.
Follow up with
commit 8b5c2b45b8f0a ("phy: rockchip: set pulldown for strobe line in dts")
commit a8cef928276bb ("phy: rockchip-emmc: output tap delay dt property")

Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
 .../devicetree/bindings/phy/rockchip-emmc-phy.txt      | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
index 00aa2d349e55..57d28c0d5696 100644
--- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
+++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
@@ -16,11 +16,11 @@ Optional properties:
  - drive-impedance-ohm: Specifies the drive impedance in Ohm.
                         Possible values are 33, 40, 50, 66 and 100.
                         If not set, the default value of 50 will be applied.
- - enable-strobe-pulldown: Enable internal pull-down for the strobe line.
-                           If not set, pull-down is not used.
- - output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
-                           If not set, the register defaults to 0x4.
-                           Maximum value 0xf.
+ - rockchip,enable-strobe-pulldown: Enable internal pull-down for the strobe
+                                    line.  If not set, pull-down is not used.
+ - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
+                                    If not set, the register defaults to 0x4.
+                                    Maximum value 0xf.
 
 Example:
 
-- 
2.20.1

Re: [PATCH v2 1/2] devicetree: phy: rockchip-emmc optional add vendor prefix

[Rob Herring]

On Tue, 15 Dec 2020 09:44:07 +0800, Chris Ruehl wrote:
> Update the documentation and add the vendor prefix to the optional
> properties referred in vendor-prefixes.yaml.
> Follow up with
> commit 8b5c2b45b8f0a ("phy: rockchip: set pulldown for strobe line in dts")
> commit a8cef928276bb ("phy: rockchip-emmc: output tap delay dt property")

These could be Fixes tags.

> 
> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
> ---
>  .../devicetree/bindings/phy/rockchip-emmc-phy.txt      | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

TBC, this needs to be applied for v5.11.

Reviewed-by: Rob Herring <robh@kernel.org>

[PATCH v2 2/2] phy: rockchip: emmc, add vendor prefix to dts properties

[Chris Ruehl]

Update the implementation add "rockchip," vendor prefix for the
optional dts properties. Prefix referred from vendor-prefixes.yaml.
Follow up with
commit 8b5c2b45b8f0a ("phy: rockchip: set pulldown for strobe line in dts")
commit a8cef928276bb ("phy: rockchip-emmc: output tap delay dt property")

Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
 drivers/phy/rockchip/phy-rockchip-emmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchip/phy-rockchip-emmc.c
index 1e424f263e7a..860b2fbbb092 100644
--- a/drivers/phy/rockchip/phy-rockchip-emmc.c
+++ b/drivers/phy/rockchip/phy-rockchip-emmc.c
@@ -380,10 +380,10 @@ static int rockchip_emmc_phy_probe(struct platform_device *pdev)
 	if (!of_property_read_u32(dev->of_node, "drive-impedance-ohm", &val))
 		rk_phy->drive_impedance = convert_drive_impedance_ohm(pdev, val);
 
-	if (of_property_read_bool(dev->of_node, "enable-strobe-pulldown"))
+	if (of_property_read_bool(dev->of_node, "rockchip,enable-strobe-pulldown"))
 		rk_phy->enable_strobe_pulldown = PHYCTRL_REN_STRB_ENABLE;
 
-	if (!of_property_read_u32(dev->of_node, "output-tapdelay-select", &val)) {
+	if (!of_property_read_u32(dev->of_node, "rockchip,output-tapdelay-select", &val)) {
 		if (val <= PHYCTRL_OTAPDLYSEL_MAXVALUE)
 			rk_phy->output_tapdelay_select = val;
 		else
-- 
2.20.1

Re: [PATCH v2 0/2] rockchip: emmc: rk3399 add vendor prefix

[Vinod Koul]

On 15-12-20, 09:44, Chris Ruehl wrote:
> Following the reference in vendor-prefixes.yaml, update implementation
> and documentation for the phy-rockchip-emmc.
> This patchset follow up with 
> commit 8b5c2b45b8f0a ("phy: rockchip: set pulldown for strobe line in dts")
> commit a8cef928276bb ("phy: rockchip-emmc: output tap delay dt property")

Applied, thanks

-- 
~Vinod