From: Maxime Ripard <maxime@cerno.tech>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Eric Anholt <eric@anholt.net>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
Jason Cooper <jason@lakedaemon.net>,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
Marc Zyngier <maz@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
linux-rpi-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 00/15] drm/vc4: hdmi: Add CEC support for the BCM2711
Date: Thu, 17 Dec 2020 13:59:22 +0100 [thread overview]
Message-ID: <20201217125922.bx3wx3dwcl6lojre@gilmour> (raw)
In-Reply-To: <cc3e0adf-ba44-7593-40ec-3d2c1efcba02@xs4all.nl>
[-- Attachment #1: Type: text/plain, Size: 6089 bytes --]
Hi Hans,
On Thu, Dec 17, 2020 at 11:53:42AM +0100, Hans Verkuil wrote:
> On 17/12/2020 11:49, Maxime Ripard wrote:
> > Hi Hans,
> >
> > On Wed, Dec 16, 2020 at 01:35:43PM +0100, Hans Verkuil wrote:
> >> Hi Maxime,
> >>
> >> On 10/12/2020 14:46, Maxime Ripard wrote:
> >>> Hi,
> >>>
> >>> Here's a series introducing the CEC support for the BCM2711 found on the
> >>> RaspberryPi4.
> >>>
> >>> The BCM2711 HDMI controller uses a similar layout for the CEC registers, the
> >>> main difference being that the interrupt handling part is now shared between
> >>> both HDMI controllers.
> >>>
> >>> This series is mainly about fixing a couple of bugs, reworking the driver to
> >>> support having two different interrupts, one for each direction, provided by an
> >>> external irqchip, and enables the irqchip driver for the controller we have.
> >>>
> >>> This has been tested on an RPi3 and RPi4, but requires the latest firmware.
> >>> It's is based on the 10 and 12 bpc series.
> >>
> >> This series looks good to me. Before I give my Acked-by for this series, can you
> >> confirm that it is possible to transmit the Image View On message on both outputs
> >> of the RPi4 when the HPD is low?
> >>
> >> See section "CEC Without HPD" in https://hverkuil.home.xs4all.nl/cec-status.txt
> >> on how to test this with a Pulse-Eight device.
> >>
> >> This should work.
> >
> > This is the output on the RPi4:
> >
> > # cec-ctl --playback
> > Driver Info:
> > Driver Name : vc4_hdmi
> > Adapter Name : vc4
> > Capabilities : 0x0000010e
> > Logical Addresses
> > Transmit
> > Passthrough
> > Driver version : 5.10.0
> > Available Logical Addresses: 1
> > Physical Address : f.f.f.f
> > Logical Address Mask : 0x0000
> > CEC Version : 2.0
> > Vendor ID : 0x000c03 (HDMI)
> > OSD Name : Playback
> > Logical Addresses : 1 (Allow RC Passthrough)
> >
> > Logical Address : Not Allocated
> > Primary Device Type : Playback
> > Logical Address Type : Playback
> > All Device Types : Playback
> > RC TV Profile : None
> > Device Features :
> > None
> >
> > # cec-ctl -t0 --image-view-on
> > Driver Info:
> > Driver Name : vc4_hdmi
> > Adapter Name : vc4
> > Capabilities : 0x0000010e
> > Logical Addresses
> > Transmit
> > Passthrough
> > Driver version : 5.10.0
> > Available Logical Addresses: 1
> > Physical Address : f.f.f.f
> > Logical Address Mask : 0x0000
> > CEC Version : 2.0
> > Vendor ID : 0x000c03 (HDMI)
> > OSD Name : Playback
> > Logical Addresses : 1 (Allow RC Passthrough)
> >
> > Logical Address : Not Allocated
> > Primary Device Type : Playback
> > Logical Address Type : Playback
> > All Device Types : Playback
> > RC TV Profile : None
> > Device Features :
> > None
> >
> >
> > Transmit from Unregistered to TV (15 to 0):
> > CEC_MSG_IMAGE_VIEW_ON (0x04)
> > Sequence: 1 Tx Timestamp: 77.631s
> >
> >
> > And this is the output on my desktop with the Pulse-Eight:
> > $ sudo cec-ctl -p0.0.0.0 --tv
> > Driver Info:
> > Driver Name : pulse8-cec
> > Adapter Name : serio0
> > Capabilities : 0x0000003f
> > Physical Address
> > Logical Addresses
> > Transmit
> > Passthrough
> > Remote Control Support
> > Monitor All
> > Driver version : 5.9.8
> > Available Logical Addresses: 1
> > Connector Info : None
> > Physical Address : 0.0.0.0
> > Logical Address Mask : 0x0001
> > CEC Version : 2.0
> > Vendor ID : 0x000c03 (HDMI)
> > OSD Name : 'TV '
> > Logical Addresses : 1 (Allow RC Passthrough)
> >
> > Logical Address : 0 (TV)
> > Primary Device Type : TV
> > Logical Address Type : TV
> > All Device Types : TV
> > RC TV Profile : None
> > Device Features :
> > None
> >
> > $ sudo cec-ctl -M
> > Driver Info:
> > Driver Name : pulse8-cec
> > Adapter Name : serio0
> > Capabilities : 0x0000003f
> > Physical Address
> > Logical Addresses
> > Transmit
> > Passthrough
> > Remote Control Support
> > Monitor All
> > Driver version : 5.9.8
> > Available Logical Addresses: 1
> > Connector Info : None
> > Physical Address : 0.0.0.0
> > Logical Address Mask : 0x0001
> > CEC Version : 2.0
> > Vendor ID : 0x000c03 (HDMI)
> > OSD Name : 'TV '
> > Logical Addresses : 1 (Allow RC Passthrough)
> >
> > Logical Address : 0 (TV)
> > Primary Device Type : TV
> > Logical Address Type : TV
> > All Device Types : TV
> > RC TV Profile : None
> > Device Features :
> > None
> >
> >
> >
> > Initial Event: State Change: PA: 0.0.0.0, LA mask: 0x0001, Conn Info: no
> > Received from Unregistered to TV (15 to 0): IMAGE_VIEW_ON (0x04)
> >
> > So it looks like it's working as expected?
>
> Yes, it looks good. Make sure you test this for both outputs of the RPi4.
It's a good thing you asked, I don't appear to get CEC interrupts from
HDMI1. I'll fix it and send another version (probably not before the end
of december though).
> If it works for both, then you can add my
>
> Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>
> for this series.
>
> Very nice work, thank you for doing this!
Thanks!
I'll hold your a-b until the next version though, fixing hdmi1 might
change a few things.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2020-12-17 13:00 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 13:46 [PATCH 00/15] drm/vc4: hdmi: Add CEC support for the BCM2711 Maxime Ripard
2020-12-10 13:46 ` [PATCH 01/15] irqchip: Allow to compile bcmstb on other platforms Maxime Ripard
2020-12-10 17:33 ` Florian Fainelli
2020-12-10 17:59 ` Marc Zyngier
2020-12-14 15:27 ` Maxime Ripard
2020-12-14 16:20 ` Marc Zyngier
2020-12-10 13:46 ` [PATCH 02/15] drm/vc4: hdmi: Move hdmi reset to bind Maxime Ripard
2020-12-18 11:20 ` Dave Stevenson
2020-12-10 13:46 ` [PATCH 03/15] drm/vc4: hdmi: Fix register offset with longer CEC messages Maxime Ripard
2020-12-15 11:23 ` Dave Stevenson
2020-12-10 13:46 ` [PATCH 04/15] drm/vc4: hdmi: Fix up CEC registers Maxime Ripard
2020-12-18 11:21 ` Dave Stevenson
2020-12-10 13:46 ` [PATCH 05/15] drm/vc4: hdmi: Restore cec physical address on reconnect Maxime Ripard
2020-12-18 14:21 ` Dave Stevenson
2020-12-18 14:45 ` Dave Stevenson
2021-01-11 10:29 ` Maxime Ripard
2020-12-10 13:46 ` [PATCH 06/15] drm/vc4: hdmi: Compute the CEC clock divider from the clock rate Maxime Ripard
2020-12-18 11:30 ` Dave Stevenson
2020-12-10 13:46 ` [PATCH 07/15] drm/vc4: hdmi: Update the CEC clock divider on HSM rate change Maxime Ripard
2020-12-18 14:26 ` Dave Stevenson
2020-12-10 13:46 ` [PATCH 08/15] drm/vc4: hdmi: Introduce a CEC clock Maxime Ripard
2020-12-18 11:37 ` Dave Stevenson
2020-12-18 12:23 ` Maxime Ripard
2020-12-18 12:25 ` Dave Stevenson
2020-12-10 13:46 ` [PATCH 09/15] drm/vc4: hdmi: Split the interrupt handlers Maxime Ripard
2020-12-10 13:46 ` [PATCH 10/15] drm/vc4: hdmi: Support BCM2711 CEC interrupt setup Maxime Ripard
2020-12-10 13:46 ` [PATCH 11/15] drm/vc4: hdmi: Remove cec_available flag Maxime Ripard
2020-12-18 14:30 ` Dave Stevenson
2020-12-10 13:46 ` [PATCH 12/15] drm/vc4: hdmi: Don't register the CEC adapter if there's no interrupts Maxime Ripard
2020-12-18 14:29 ` Dave Stevenson
2020-12-10 13:46 ` [PATCH 13/15] dt-binding: display: bcm2711-hdmi: Add CEC and hotplug interrupts Maxime Ripard
2020-12-10 13:46 ` [PATCH 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller Maxime Ripard
2020-12-10 17:41 ` Florian Fainelli
2020-12-10 13:46 ` [PATCH 15/15] ARM: dts: bcm2711: Add the CEC " Maxime Ripard
2020-12-10 17:42 ` Florian Fainelli
2020-12-16 12:35 ` [PATCH 00/15] drm/vc4: hdmi: Add CEC support for the BCM2711 Hans Verkuil
2020-12-17 10:49 ` Maxime Ripard
2020-12-17 10:53 ` Hans Verkuil
2020-12-17 12:59 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217125922.bx3wx3dwcl6lojre@gilmour \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.vetter@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maz@kernel.org \
--cc=mchehab@kernel.org \
--cc=tglx@linutronix.de \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).