[PATCH -next] regulator: qcom-rpmh: fix build after QCOM_COMMAND_DB is tristate

[PATCH -next] regulator: qcom-rpmh: fix build after QCOM_COMMAND_DB is tristate

[Randy Dunlap]

Restrict REGULATOR_QCOM_RPMH to QCOM_COMMAND_DB it the latter is enabled.

Fixes this build error:
  microblaze-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_probe':
  (.text+0x354): undefined reference to `cmd_db_read_addr'

Fixes: 778279f4f5e4 ("soc: qcom: cmd-db: allow loading as a module")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Lina Iyer <ilina@codeaurora.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20201223.orig/drivers/regulator/Kconfig
+++ linux-next-20201223/drivers/regulator/Kconfig
@@ -881,6 +881,7 @@ config REGULATOR_QCOM_RPM
 config REGULATOR_QCOM_RPMH
 	tristate "Qualcomm Technologies, Inc. RPMh regulator driver"
 	depends on QCOM_RPMH || (QCOM_RPMH=n && COMPILE_TEST)
+	depends on QCOM_COMMAND_DB || !QCOM_COMMAND_DB
 	help
 	  This driver supports control of PMIC regulators via the RPMh hardware
 	  block found on Qualcomm Technologies Inc. SoCs.  RPMh regulator

Re: [PATCH -next] regulator: qcom-rpmh: fix build after QCOM_COMMAND_DB is tristate

[Lina Iyer]

On Fri, Dec 25 2020 at 11:50 -0700, Randy Dunlap wrote:
>Restrict REGULATOR_QCOM_RPMH to QCOM_COMMAND_DB it the latter is enabled.
>
>Fixes this build error:
>  microblaze-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_probe':
>  (.text+0x354): undefined reference to `cmd_db_read_addr'
>
>Fixes: 778279f4f5e4 ("soc: qcom: cmd-db: allow loading as a module")
>Reported-by: kernel test robot <lkp@intel.com>
>Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>Cc: Lina Iyer <ilina@codeaurora.org>
>Cc: Liam Girdwood <lgirdwood@gmail.com>
>Cc: Mark Brown <broonie@kernel.org>
Reviewed-by: Lina Iyer <ilina@codeaurora.org>

>---
> drivers/regulator/Kconfig |    1 +
> 1 file changed, 1 insertion(+)
>
>--- linux-next-20201223.orig/drivers/regulator/Kconfig
>+++ linux-next-20201223/drivers/regulator/Kconfig
>@@ -881,6 +881,7 @@ config REGULATOR_QCOM_RPM
> config REGULATOR_QCOM_RPMH
> 	tristate "Qualcomm Technologies, Inc. RPMh regulator driver"
> 	depends on QCOM_RPMH || (QCOM_RPMH=n && COMPILE_TEST)
>+	depends on QCOM_COMMAND_DB || !QCOM_COMMAND_DB
> 	help
> 	  This driver supports control of PMIC regulators via the RPMh hardware
> 	  block found on Qualcomm Technologies Inc. SoCs.  RPMh regulator

Re: [PATCH -next] regulator: qcom-rpmh: fix build after QCOM_COMMAND_DB is tristate

[Mark Brown]

On Fri, 25 Dec 2020 10:50:04 -0800, Randy Dunlap wrote:
> Restrict REGULATOR_QCOM_RPMH to QCOM_COMMAND_DB it the latter is enabled.
> 
> Fixes this build error:
>   microblaze-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_probe':
>   (.text+0x354): undefined reference to `cmd_db_read_addr'

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: qcom-rpmh: fix build after QCOM_COMMAND_DB is tristate
      commit: ac6b559d818981406e587f4784777e9112d553f4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark