* [PATCH] mfd: stmpe: Support disabling sub-functions
@ 2020-12-26 9:47 Oleksandr Suvorov
2020-12-26 15:50 ` [Linux-stm32] " Ahmad Fatoum
0 siblings, 1 reply; 11+ messages in thread
From: Oleksandr Suvorov @ 2020-12-26 9:47 UTC (permalink / raw)
To: linux-next
Cc: Marcel Ziswiler, Igor Opaniuk, Philippe Schenker,
Oleksandr Suvorov, Alexandre Torgue, Lee Jones, Maxime Coquelin,
linux-arm-kernel, linux-kernel, linux-stm32
Add support of sub-functions disabling. It allows one to define
an stmpe sub-function device in devicetree, but keep it disabled.
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
---
drivers/mfd/stmpe.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index 90f3292230c9..2182607b75f6 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -1358,6 +1358,9 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata,
pdata->autosleep = (pdata->autosleep_timeout) ? true : false;
for_each_child_of_node(np, child) {
+ /* skip disabled sub-function */
+ if (!of_device_is_available(child))
+ continue;
if (of_node_name_eq(child, "stmpe_gpio")) {
pdata->blocks |= STMPE_BLOCK_GPIO;
} else if (of_node_name_eq(child, "stmpe_keypad")) {
--
2.29.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [Linux-stm32] [PATCH] mfd: stmpe: Support disabling sub-functions
2020-12-26 9:47 [PATCH] mfd: stmpe: Support disabling sub-functions Oleksandr Suvorov
@ 2020-12-26 15:50 ` Ahmad Fatoum
2020-12-26 16:28 ` [PATCH v2] " Oleksandr Suvorov
0 siblings, 1 reply; 11+ messages in thread
From: Ahmad Fatoum @ 2020-12-26 15:50 UTC (permalink / raw)
To: Oleksandr Suvorov, linux-next
Cc: Igor Opaniuk, Marcel Ziswiler, linux-kernel, Philippe Schenker,
Maxime Coquelin, Lee Jones, linux-stm32, linux-arm-kernel
Hello Oleksander,
On 26.12.20 10:47, Oleksandr Suvorov wrote:
> Add support of sub-functions disabling. It allows one to define
> an stmpe sub-function device in devicetree, but keep it disabled.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> ---
>
> drivers/mfd/stmpe.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index 90f3292230c9..2182607b75f6 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -1358,6 +1358,9 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata,
> pdata->autosleep = (pdata->autosleep_timeout) ? true : false;
>
> (np, child) {
> + /* skip disabled sub-function */
> + if (!of_device_is_available(child))
> + continue;
Better use for_each_available_child_of_node().
> if (of_node_name_eq(child, "stmpe_gpio")) {
> pdata->blocks |= STMPE_BLOCK_GPIO;
> } else if (of_node_name_eq(child, "stmpe_keypad")) {
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v2] mfd: stmpe: Support disabling sub-functions
2020-12-26 15:50 ` [Linux-stm32] " Ahmad Fatoum
@ 2020-12-26 16:28 ` Oleksandr Suvorov
0 siblings, 0 replies; 11+ messages in thread
From: Oleksandr Suvorov @ 2020-12-26 16:28 UTC (permalink / raw)
To: linux-next
Cc: Marcel Ziswiler, Igor Opaniuk, Philippe Schenker,
Oleksandr Suvorov, Alexandre Torgue, Lee Jones, Maxime Coquelin,
linux-arm-kernel, linux-kernel, linux-stm32
Add support of sub-functions disabling. It allows one to define
an stmpe sub-function device in devicetree, but keep it disabled.
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
---
Changes in v2:
Use for_each_available_child_of_node() instead of checking
of_device_is_available() for each node.
Thanks for Ahmad Fatoum a.fatoum@pengutronix.de for and idea
drivers/mfd/stmpe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index 90f3292230c9..3e4f32673db3 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -1357,7 +1357,7 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata,
pdata->autosleep = (pdata->autosleep_timeout) ? true : false;
- for_each_child_of_node(np, child) {
+ for_each_available_child_of_node(np, child) {
if (of_node_name_eq(child, "stmpe_gpio")) {
pdata->blocks |= STMPE_BLOCK_GPIO;
} else if (of_node_name_eq(child, "stmpe_keypad")) {
--
2.29.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] mfd: stmpe: Support disabling sub-functions
@ 2021-10-27 8:21 Francesco Dolcini
2021-10-27 16:14 ` Marcel Ziswiler
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Francesco Dolcini @ 2021-10-27 8:21 UTC (permalink / raw)
To: Lee Jones, Maxime Coquelin, Alexandre Torgue
Cc: marcel.ziswiler, Oleksandr Suvorov, Oleksandr Suvorov,
Francesco Dolcini, linux-stm32, linux-arm-kernel, linux-kernel
From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Add support of sub-functions disabling. It allows one to define
an stmpe sub-function device in devicetree, but keep it disabled.
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Cc: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
Hello,
the main reason for this patch is to allow enabling/disabling sub-fuctions
using DTS overlay to enable more flexibility on SoM/Carrier boards
combinations.
---
drivers/mfd/stmpe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index e928df95e316..aeb9ea55f97d 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -1361,7 +1361,7 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata,
pdata->autosleep = (pdata->autosleep_timeout) ? true : false;
- for_each_child_of_node(np, child) {
+ for_each_available_child_of_node(np, child) {
if (of_node_name_eq(child, "stmpe_gpio")) {
pdata->blocks |= STMPE_BLOCK_GPIO;
} else if (of_node_name_eq(child, "stmpe_keypad")) {
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] mfd: stmpe: Support disabling sub-functions
2021-10-27 8:21 [PATCH] " Francesco Dolcini
@ 2021-10-27 16:14 ` Marcel Ziswiler
2021-10-28 0:37 ` Linus Walleij
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Marcel Ziswiler @ 2021-10-27 16:14 UTC (permalink / raw)
To: mcoquelin.stm32, Francesco Dolcini, alexandre.torgue, lee.jones
Cc: linux-stm32, linux-arm-kernel, linux-kernel, oleksandr.suvorov,
oleksandr.suvorov
Hi Francesco
On Wed, 2021-10-27 at 10:21 +0200, Francesco Dolcini wrote:
> From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
>
> Add support of sub-functions disabling. It allows one to define
> an stmpe sub-function device in devicetree, but keep it disabled.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> Cc: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> ---
> Hello,
> the main reason for this patch is to allow enabling/disabling sub-fuctions
:s/sub-fuctions/sub-functions/
> using DTS overlay to enable more flexibility on SoM/Carrier boards
:s/boards/board/
> combinations.
> ---
> drivers/mfd/stmpe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index e928df95e316..aeb9ea55f97d 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -1361,7 +1361,7 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata,
>
> pdata->autosleep = (pdata->autosleep_timeout) ? true : false;
>
> - for_each_child_of_node(np, child) {
> + for_each_available_child_of_node(np, child) {
> if (of_node_name_eq(child, "stmpe_gpio")) {
> pdata->blocks |= STMPE_BLOCK_GPIO;
> } else if (of_node_name_eq(child, "stmpe_keypad")) {
Cheers
Marcel
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] mfd: stmpe: Support disabling sub-functions
2021-10-27 8:21 [PATCH] " Francesco Dolcini
2021-10-27 16:14 ` Marcel Ziswiler
@ 2021-10-28 0:37 ` Linus Walleij
2021-11-01 9:48 ` Francesco Dolcini
2021-11-24 15:45 ` Lee Jones
3 siblings, 0 replies; 11+ messages in thread
From: Linus Walleij @ 2021-10-28 0:37 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Lee Jones, Maxime Coquelin, Alexandre Torgue, marcel.ziswiler,
Oleksandr Suvorov, Oleksandr Suvorov, linux-stm32,
linux-arm-kernel, linux-kernel
On Wed, Oct 27, 2021 at 10:23 AM Francesco Dolcini
<francesco.dolcini@toradex.com> wrote:
> From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
>
> Add support of sub-functions disabling. It allows one to define
> an stmpe sub-function device in devicetree, but keep it disabled.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> Cc: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Looks helpful.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] mfd: stmpe: Support disabling sub-functions
2021-10-27 8:21 [PATCH] " Francesco Dolcini
2021-10-27 16:14 ` Marcel Ziswiler
2021-10-28 0:37 ` Linus Walleij
@ 2021-11-01 9:48 ` Francesco Dolcini
2021-11-01 12:13 ` Lee Jones
2021-11-24 15:45 ` Lee Jones
3 siblings, 1 reply; 11+ messages in thread
From: Francesco Dolcini @ 2021-11-01 9:48 UTC (permalink / raw)
To: Lee Jones
Cc: Francesco Dolcini, Maxime Coquelin, Alexandre Torgue,
marcel.ziswiler, Oleksandr Suvorov, Oleksandr Suvorov,
linux-stm32, linux-arm-kernel, linux-kernel
On Wed, Oct 27, 2021 at 10:21:55AM +0200, Francesco Dolcini wrote:
> From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
>
> Add support of sub-functions disabling. It allows one to define
> an stmpe sub-function device in devicetree, but keep it disabled.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> Cc: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Hello Lee,
any chance you could take this one line patch for this merge window?
Francesco
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] mfd: stmpe: Support disabling sub-functions
2021-11-01 9:48 ` Francesco Dolcini
@ 2021-11-01 12:13 ` Lee Jones
2021-11-02 8:21 ` Francesco Dolcini
0 siblings, 1 reply; 11+ messages in thread
From: Lee Jones @ 2021-11-01 12:13 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Maxime Coquelin, Alexandre Torgue, marcel.ziswiler,
Oleksandr Suvorov, Oleksandr Suvorov, linux-stm32,
linux-arm-kernel, linux-kernel
On Mon, 01 Nov 2021, Francesco Dolcini wrote:
> On Wed, Oct 27, 2021 at 10:21:55AM +0200, Francesco Dolcini wrote:
> > From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> >
> > Add support of sub-functions disabling. It allows one to define
> > an stmpe sub-function device in devicetree, but keep it disabled.
> >
> > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> > Cc: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> Hello Lee,
> any chance you could take this one line patch for this merge window?
For a patch sent 0.5 weeks before the merge-window? Nope. :)
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] mfd: stmpe: Support disabling sub-functions
2021-11-01 12:13 ` Lee Jones
@ 2021-11-02 8:21 ` Francesco Dolcini
2021-11-02 10:48 ` Lee Jones
0 siblings, 1 reply; 11+ messages in thread
From: Francesco Dolcini @ 2021-11-02 8:21 UTC (permalink / raw)
To: Lee Jones
Cc: Francesco Dolcini, Maxime Coquelin, Alexandre Torgue,
marcel.ziswiler, Oleksandr Suvorov, linux-stm32,
linux-arm-kernel, linux-kernel
On Mon, Nov 01, 2021 at 12:13:23PM +0000, Lee Jones wrote:
> On Mon, 01 Nov 2021, Francesco Dolcini wrote:
> > Hello Lee,
> > any chance you could take this one line patch for this merge window?
>
> For a patch sent 0.5 weeks before the merge-window? Nope. :)
Hello Lee,
no problem, I thought it was that trivial to not create any worries.
I'll resend it in a while unless you take it before.
Francesco
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] mfd: stmpe: Support disabling sub-functions
2021-11-02 8:21 ` Francesco Dolcini
@ 2021-11-02 10:48 ` Lee Jones
0 siblings, 0 replies; 11+ messages in thread
From: Lee Jones @ 2021-11-02 10:48 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Maxime Coquelin, Alexandre Torgue, marcel.ziswiler,
Oleksandr Suvorov, linux-stm32, linux-arm-kernel, linux-kernel
On Tue, 02 Nov 2021, Francesco Dolcini wrote:
> On Mon, Nov 01, 2021 at 12:13:23PM +0000, Lee Jones wrote:
> > On Mon, 01 Nov 2021, Francesco Dolcini wrote:
> > > Hello Lee,
> > > any chance you could take this one line patch for this merge window?
> >
> > For a patch sent 0.5 weeks before the merge-window? Nope. :)
>
> Hello Lee,
> no problem, I thought it was that trivial to not create any worries.
> I'll resend it in a while unless you take it before.
I like *all* patches to have a soak in -next.
You don't need to resend it. I'll apply it in due course.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] mfd: stmpe: Support disabling sub-functions
2021-10-27 8:21 [PATCH] " Francesco Dolcini
` (2 preceding siblings ...)
2021-11-01 9:48 ` Francesco Dolcini
@ 2021-11-24 15:45 ` Lee Jones
3 siblings, 0 replies; 11+ messages in thread
From: Lee Jones @ 2021-11-24 15:45 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Maxime Coquelin, Alexandre Torgue, marcel.ziswiler,
Oleksandr Suvorov, Oleksandr Suvorov, linux-stm32,
linux-arm-kernel, linux-kernel
On Wed, 27 Oct 2021, Francesco Dolcini wrote:
> From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
>
> Add support of sub-functions disabling. It allows one to define
> an stmpe sub-function device in devicetree, but keep it disabled.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> Cc: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> Hello,
> the main reason for this patch is to allow enabling/disabling sub-fuctions
> using DTS overlay to enable more flexibility on SoM/Carrier boards
> combinations.
> ---
> drivers/mfd/stmpe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-11-24 15:45 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-26 9:47 [PATCH] mfd: stmpe: Support disabling sub-functions Oleksandr Suvorov
2020-12-26 15:50 ` [Linux-stm32] " Ahmad Fatoum
2020-12-26 16:28 ` [PATCH v2] " Oleksandr Suvorov
2021-10-27 8:21 [PATCH] " Francesco Dolcini
2021-10-27 16:14 ` Marcel Ziswiler
2021-10-28 0:37 ` Linus Walleij
2021-11-01 9:48 ` Francesco Dolcini
2021-11-01 12:13 ` Lee Jones
2021-11-02 8:21 ` Francesco Dolcini
2021-11-02 10:48 ` Lee Jones
2021-11-24 15:45 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).