* [PATCH] mfd: stmpe: Support disabling sub-functions
@ 2020-12-26 9:47 Oleksandr Suvorov
2020-12-26 15:50 ` [Linux-stm32] " Ahmad Fatoum
0 siblings, 1 reply; 3+ messages in thread
From: Oleksandr Suvorov @ 2020-12-26 9:47 UTC (permalink / raw)
To: linux-next
Cc: Marcel Ziswiler, Igor Opaniuk, Philippe Schenker,
Oleksandr Suvorov, Alexandre Torgue, Lee Jones, Maxime Coquelin,
linux-arm-kernel, linux-kernel, linux-stm32
Add support of sub-functions disabling. It allows one to define
an stmpe sub-function device in devicetree, but keep it disabled.
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
---
drivers/mfd/stmpe.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index 90f3292230c9..2182607b75f6 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -1358,6 +1358,9 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata,
pdata->autosleep = (pdata->autosleep_timeout) ? true : false;
for_each_child_of_node(np, child) {
+ /* skip disabled sub-function */
+ if (!of_device_is_available(child))
+ continue;
if (of_node_name_eq(child, "stmpe_gpio")) {
pdata->blocks |= STMPE_BLOCK_GPIO;
} else if (of_node_name_eq(child, "stmpe_keypad")) {
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Linux-stm32] [PATCH] mfd: stmpe: Support disabling sub-functions
2020-12-26 9:47 [PATCH] mfd: stmpe: Support disabling sub-functions Oleksandr Suvorov
@ 2020-12-26 15:50 ` Ahmad Fatoum
2020-12-26 16:28 ` [PATCH v2] " Oleksandr Suvorov
0 siblings, 1 reply; 3+ messages in thread
From: Ahmad Fatoum @ 2020-12-26 15:50 UTC (permalink / raw)
To: Oleksandr Suvorov, linux-next
Cc: Igor Opaniuk, Marcel Ziswiler, linux-kernel, Philippe Schenker,
Maxime Coquelin, Lee Jones, linux-stm32, linux-arm-kernel
Hello Oleksander,
On 26.12.20 10:47, Oleksandr Suvorov wrote:
> Add support of sub-functions disabling. It allows one to define
> an stmpe sub-function device in devicetree, but keep it disabled.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> ---
>
> drivers/mfd/stmpe.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index 90f3292230c9..2182607b75f6 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -1358,6 +1358,9 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata,
> pdata->autosleep = (pdata->autosleep_timeout) ? true : false;
>
> (np, child) {
> + /* skip disabled sub-function */
> + if (!of_device_is_available(child))
> + continue;
Better use for_each_available_child_of_node().
> if (of_node_name_eq(child, "stmpe_gpio")) {
> pdata->blocks |= STMPE_BLOCK_GPIO;
> } else if (of_node_name_eq(child, "stmpe_keypad")) {
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] mfd: stmpe: Support disabling sub-functions
2020-12-26 15:50 ` [Linux-stm32] " Ahmad Fatoum
@ 2020-12-26 16:28 ` Oleksandr Suvorov
0 siblings, 0 replies; 3+ messages in thread
From: Oleksandr Suvorov @ 2020-12-26 16:28 UTC (permalink / raw)
To: linux-next
Cc: Marcel Ziswiler, Igor Opaniuk, Philippe Schenker,
Oleksandr Suvorov, Alexandre Torgue, Lee Jones, Maxime Coquelin,
linux-arm-kernel, linux-kernel, linux-stm32
Add support of sub-functions disabling. It allows one to define
an stmpe sub-function device in devicetree, but keep it disabled.
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
---
Changes in v2:
Use for_each_available_child_of_node() instead of checking
of_device_is_available() for each node.
Thanks for Ahmad Fatoum a.fatoum@pengutronix.de for and idea
drivers/mfd/stmpe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index 90f3292230c9..3e4f32673db3 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -1357,7 +1357,7 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata,
pdata->autosleep = (pdata->autosleep_timeout) ? true : false;
- for_each_child_of_node(np, child) {
+ for_each_available_child_of_node(np, child) {
if (of_node_name_eq(child, "stmpe_gpio")) {
pdata->blocks |= STMPE_BLOCK_GPIO;
} else if (of_node_name_eq(child, "stmpe_keypad")) {
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-26 16:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-26 9:47 [PATCH] mfd: stmpe: Support disabling sub-functions Oleksandr Suvorov
2020-12-26 15:50 ` [Linux-stm32] " Ahmad Fatoum
2020-12-26 16:28 ` [PATCH v2] " Oleksandr Suvorov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).