* [PATCH 0/2] misc: eeprom_93xx46: Enable module autoprobe
@ 2021-01-07 16:39 Aswath Govindraju
2021-01-07 16:39 ` [PATCH 1/2] misc: eeprom_93xx46: Fix module alias to enable " Aswath Govindraju
2021-01-07 16:39 ` [PATCH 2/2] misc: eeprom_93xx46: Enable module autoprobe for microchip 93LC46B eeprom Aswath Govindraju
0 siblings, 2 replies; 5+ messages in thread
From: Aswath Govindraju @ 2021-01-07 16:39 UTC (permalink / raw)
Cc: Vignesh Raghavendra, Sekhar Nori, Kishon Vijay Abraham I,
Pratyush Yadav, Aswath Govindraju, Arnd Bergmann,
Greg Kroah-Hartman, Vadym Kochan, Anatolij Gustschin,
Randy Dunlap, Andrew Morton, linux-kernel
The following series of patches
- fixes the modules alias for eeprom-93XX46
- enables module autprobe for microchip 93LC46B eeprom
Aswath Govindraju (2):
misc: eeprom_93xx46: Fix module alias to enable module autoprobe
misc: eeprom_93xx46: Enable module autoprobe for microchip 93LC46B
eeprom
drivers/misc/eeprom/eeprom_93xx46.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] misc: eeprom_93xx46: Fix module alias to enable module autoprobe
2021-01-07 16:39 [PATCH 0/2] misc: eeprom_93xx46: Enable module autoprobe Aswath Govindraju
@ 2021-01-07 16:39 ` Aswath Govindraju
2021-01-12 7:19 ` Vignesh Raghavendra
2021-01-07 16:39 ` [PATCH 2/2] misc: eeprom_93xx46: Enable module autoprobe for microchip 93LC46B eeprom Aswath Govindraju
1 sibling, 1 reply; 5+ messages in thread
From: Aswath Govindraju @ 2021-01-07 16:39 UTC (permalink / raw)
Cc: Vignesh Raghavendra, Sekhar Nori, Kishon Vijay Abraham I,
Pratyush Yadav, Aswath Govindraju, Arnd Bergmann,
Greg Kroah-Hartman, Vadym Kochan, Andrew Morton,
Anatolij Gustschin, Randy Dunlap, linux-kernel
Fix module autoprobe by correcting module alias to match the string from
/sys/class/.../spi1.0/modalias content.
Fixes: 06b4501e88ad ("misc/eeprom: add driver for microwire 93xx46 EEPROMs")
Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
drivers/misc/eeprom/eeprom_93xx46.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c
index a18247696ce7..890624d97774 100644
--- a/drivers/misc/eeprom/eeprom_93xx46.c
+++ b/drivers/misc/eeprom/eeprom_93xx46.c
@@ -526,4 +526,4 @@ module_spi_driver(eeprom_93xx46_driver);
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Driver for 93xx46 EEPROMs");
MODULE_AUTHOR("Anatolij Gustschin <agust@denx.de>");
-MODULE_ALIAS("spi:93xx46");
+MODULE_ALIAS("spi:eeprom-93xx46");
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] misc: eeprom_93xx46: Enable module autoprobe for microchip 93LC46B eeprom
2021-01-07 16:39 [PATCH 0/2] misc: eeprom_93xx46: Enable module autoprobe Aswath Govindraju
2021-01-07 16:39 ` [PATCH 1/2] misc: eeprom_93xx46: Fix module alias to enable " Aswath Govindraju
@ 2021-01-07 16:39 ` Aswath Govindraju
1 sibling, 0 replies; 5+ messages in thread
From: Aswath Govindraju @ 2021-01-07 16:39 UTC (permalink / raw)
Cc: Vignesh Raghavendra, Sekhar Nori, Kishon Vijay Abraham I,
Pratyush Yadav, Aswath Govindraju, Arnd Bergmann,
Greg Kroah-Hartman, Vadym Kochan, Randy Dunlap,
Anatolij Gustschin, Andrew Morton, linux-kernel
Add module alias to enable autoprobe for microchip 93LC46B eeprom by using
/sys/class/.../spi1.0/modalias content.
Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
This patch is dependent on,
https://lore.kernel.org/patchwork/patch/1360658/
drivers/misc/eeprom/eeprom_93xx46.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c
index 890624d97774..9ca2571cab17 100644
--- a/drivers/misc/eeprom/eeprom_93xx46.c
+++ b/drivers/misc/eeprom/eeprom_93xx46.c
@@ -527,3 +527,4 @@ MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Driver for 93xx46 EEPROMs");
MODULE_AUTHOR("Anatolij Gustschin <agust@denx.de>");
MODULE_ALIAS("spi:eeprom-93xx46");
+MODULE_ALIAS("spi:93lc46b");
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] misc: eeprom_93xx46: Fix module alias to enable module autoprobe
2021-01-07 16:39 ` [PATCH 1/2] misc: eeprom_93xx46: Fix module alias to enable " Aswath Govindraju
@ 2021-01-12 7:19 ` Vignesh Raghavendra
2021-01-13 5:15 ` Aswath Govindraju
0 siblings, 1 reply; 5+ messages in thread
From: Vignesh Raghavendra @ 2021-01-12 7:19 UTC (permalink / raw)
To: Aswath Govindraju
Cc: Sekhar Nori, Kishon Vijay Abraham I, Pratyush Yadav,
Arnd Bergmann, Greg Kroah-Hartman, Vadym Kochan, Andrew Morton,
Anatolij Gustschin, Randy Dunlap, linux-kernel
On 1/7/21 10:09 PM, Aswath Govindraju wrote:
> Fix module autoprobe by correcting module alias to match the string from
> /sys/class/.../spi1.0/modalias content.
>
> Fixes: 06b4501e88ad ("misc/eeprom: add driver for microwire 93xx46 EEPROMs")
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
> drivers/misc/eeprom/eeprom_93xx46.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c
> index a18247696ce7..890624d97774 100644
> --- a/drivers/misc/eeprom/eeprom_93xx46.c
> +++ b/drivers/misc/eeprom/eeprom_93xx46.c
> @@ -526,4 +526,4 @@ module_spi_driver(eeprom_93xx46_driver);
> MODULE_LICENSE("GPL");
> MODULE_DESCRIPTION("Driver for 93xx46 EEPROMs");
> MODULE_AUTHOR("Anatolij Gustschin <agust@denx.de>");
> -MODULE_ALIAS("spi:93xx46");
This will break non DT users of this driver like
drivers/misc/eeprom/digsy_mtc_eeprom.c
> +MODULE_ALIAS("spi:eeprom-93xx46");
>
Can be a new entry.
Regards
Vignesh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] misc: eeprom_93xx46: Fix module alias to enable module autoprobe
2021-01-12 7:19 ` Vignesh Raghavendra
@ 2021-01-13 5:15 ` Aswath Govindraju
0 siblings, 0 replies; 5+ messages in thread
From: Aswath Govindraju @ 2021-01-13 5:15 UTC (permalink / raw)
To: Vignesh Raghavendra
Cc: Sekhar Nori, Kishon Vijay Abraham I, Pratyush Yadav,
Arnd Bergmann, Greg Kroah-Hartman, Vadym Kochan, Andrew Morton,
Anatolij Gustschin, Randy Dunlap, linux-kernel
On 12/01/21 12:49 pm, Vignesh Raghavendra wrote:
>
>
> On 1/7/21 10:09 PM, Aswath Govindraju wrote:
>> Fix module autoprobe by correcting module alias to match the string from
>> /sys/class/.../spi1.0/modalias content.
>>
>> Fixes: 06b4501e88ad ("misc/eeprom: add driver for microwire 93xx46 EEPROMs")
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> ---
>> drivers/misc/eeprom/eeprom_93xx46.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c
>> index a18247696ce7..890624d97774 100644
>> --- a/drivers/misc/eeprom/eeprom_93xx46.c
>> +++ b/drivers/misc/eeprom/eeprom_93xx46.c
>> @@ -526,4 +526,4 @@ module_spi_driver(eeprom_93xx46_driver);
>> MODULE_LICENSE("GPL");
>> MODULE_DESCRIPTION("Driver for 93xx46 EEPROMs");
>> MODULE_AUTHOR("Anatolij Gustschin <agust@denx.de>");
>> -MODULE_ALIAS("spi:93xx46");
>
> This will break non DT users of this driver like
> drivers/misc/eeprom/digsy_mtc_eeprom.c
>
>> +MODULE_ALIAS("spi:eeprom-93xx46");
>>
>
> Can be a new entry.
>
Thank you for the comments. Addressed this by sending a follow up patch,
https://lore.kernel.org/patchwork/patch/1364431/
Thanks,
Aswath
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-13 5:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 16:39 [PATCH 0/2] misc: eeprom_93xx46: Enable module autoprobe Aswath Govindraju
2021-01-07 16:39 ` [PATCH 1/2] misc: eeprom_93xx46: Fix module alias to enable " Aswath Govindraju
2021-01-12 7:19 ` Vignesh Raghavendra
2021-01-13 5:15 ` Aswath Govindraju
2021-01-07 16:39 ` [PATCH 2/2] misc: eeprom_93xx46: Enable module autoprobe for microchip 93LC46B eeprom Aswath Govindraju
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).