* [PATCH v1] Documentation: ACPI: add new rule for gpio-line-names
@ 2021-01-08 15:24 Flavio Suligoi
2021-01-08 16:02 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Flavio Suligoi @ 2021-01-08 15:24 UTC (permalink / raw)
To: Mika Westerberg, Andy Shevchenko, Rafael J . Wysocki, Len Brown
Cc: linux-gpio, linux-acpi, linux-kernel, Flavio Suligoi
The gpio-line-names lists must respect some rules.
This patch adds a new rule in documentation, to avoid
the use of duplicate names in the same gpiochip.
Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
---
Documentation/firmware-guide/acpi/gpio-properties.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst
index b36aa3e743d8..4e264c16ddff 100644
--- a/Documentation/firmware-guide/acpi/gpio-properties.rst
+++ b/Documentation/firmware-guide/acpi/gpio-properties.rst
@@ -146,6 +146,7 @@ following rules (see also the examples):
other words, it is not mandatory to fill all the GPIO lines
- empty names are allowed (two quotation marks ``""`` correspond to an empty
name)
+ - names inside one GPIO controller/expander must be unique
Example of a GPIO controller of 16 lines, with an incomplete list with two
empty names::
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] Documentation: ACPI: add new rule for gpio-line-names
2021-01-08 15:24 [PATCH v1] Documentation: ACPI: add new rule for gpio-line-names Flavio Suligoi
@ 2021-01-08 16:02 ` Andy Shevchenko
2021-01-22 15:32 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2021-01-08 16:02 UTC (permalink / raw)
To: Flavio Suligoi
Cc: Mika Westerberg, Andy Shevchenko, Rafael J . Wysocki, Len Brown,
open list:GPIO SUBSYSTEM, ACPI Devel Maling List,
Linux Kernel Mailing List
On Fri, Jan 8, 2021 at 5:28 PM Flavio Suligoi <f.suligoi@asem.it> wrote:
>
> The gpio-line-names lists must respect some rules.
>
> This patch adds a new rule in documentation, to avoid
> the use of duplicate names in the same gpiochip.
Thanks!
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> ---
> Documentation/firmware-guide/acpi/gpio-properties.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst
> index b36aa3e743d8..4e264c16ddff 100644
> --- a/Documentation/firmware-guide/acpi/gpio-properties.rst
> +++ b/Documentation/firmware-guide/acpi/gpio-properties.rst
> @@ -146,6 +146,7 @@ following rules (see also the examples):
> other words, it is not mandatory to fill all the GPIO lines
> - empty names are allowed (two quotation marks ``""`` correspond to an empty
> name)
> + - names inside one GPIO controller/expander must be unique
>
> Example of a GPIO controller of 16 lines, with an incomplete list with two
> empty names::
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] Documentation: ACPI: add new rule for gpio-line-names
2021-01-08 16:02 ` Andy Shevchenko
@ 2021-01-22 15:32 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2021-01-22 15:32 UTC (permalink / raw)
To: Andy Shevchenko, Flavio Suligoi
Cc: Mika Westerberg, Andy Shevchenko, Rafael J . Wysocki, Len Brown,
open list:GPIO SUBSYSTEM, ACPI Devel Maling List,
Linux Kernel Mailing List
On Fri, Jan 8, 2021 at 5:03 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Fri, Jan 8, 2021 at 5:28 PM Flavio Suligoi <f.suligoi@asem.it> wrote:
> >
> > The gpio-line-names lists must respect some rules.
> >
> > This patch adds a new rule in documentation, to avoid
> > the use of duplicate names in the same gpiochip.
>
> Thanks!
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> > Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> > ---
> > Documentation/firmware-guide/acpi/gpio-properties.rst | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst
> > index b36aa3e743d8..4e264c16ddff 100644
> > --- a/Documentation/firmware-guide/acpi/gpio-properties.rst
> > +++ b/Documentation/firmware-guide/acpi/gpio-properties.rst
> > @@ -146,6 +146,7 @@ following rules (see also the examples):
> > other words, it is not mandatory to fill all the GPIO lines
> > - empty names are allowed (two quotation marks ``""`` correspond to an empty
> > name)
> > + - names inside one GPIO controller/expander must be unique
> >
> > Example of a GPIO controller of 16 lines, with an incomplete list with two
> > empty names::
> > --
Applied as 5.12 material, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-22 15:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08 15:24 [PATCH v1] Documentation: ACPI: add new rule for gpio-line-names Flavio Suligoi
2021-01-08 16:02 ` Andy Shevchenko
2021-01-22 15:32 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).