[PATCH v1] Documentation: ACPI: add new rule for gpio-line-names

[PATCH v1] Documentation: ACPI: add new rule for gpio-line-names

[Flavio Suligoi]

The gpio-line-names lists must respect some rules.

This patch adds a new rule in documentation, to avoid
the use of duplicate names in the same gpiochip.

Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
---
 Documentation/firmware-guide/acpi/gpio-properties.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst
index b36aa3e743d8..4e264c16ddff 100644
--- a/Documentation/firmware-guide/acpi/gpio-properties.rst
+++ b/Documentation/firmware-guide/acpi/gpio-properties.rst
@@ -146,6 +146,7 @@ following rules (see also the examples):
     other words, it is not mandatory to fill all the GPIO lines
   - empty names are allowed (two quotation marks ``""`` correspond to an empty
     name)
+  - names inside one GPIO controller/expander must be unique
 
 Example of a GPIO controller of 16 lines, with an incomplete list with two
 empty names::
-- 
2.25.1

Re: [PATCH v1] Documentation: ACPI: add new rule for gpio-line-names

[Andy Shevchenko]

On Fri, Jan 8, 2021 at 5:28 PM Flavio Suligoi <f.suligoi@asem.it> wrote:
>
> The gpio-line-names lists must respect some rules.
>
> This patch adds a new rule in documentation, to avoid
> the use of duplicate names in the same gpiochip.

Thanks!
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> ---
>  Documentation/firmware-guide/acpi/gpio-properties.rst | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst
> index b36aa3e743d8..4e264c16ddff 100644
> --- a/Documentation/firmware-guide/acpi/gpio-properties.rst
> +++ b/Documentation/firmware-guide/acpi/gpio-properties.rst
> @@ -146,6 +146,7 @@ following rules (see also the examples):
>      other words, it is not mandatory to fill all the GPIO lines
>    - empty names are allowed (two quotation marks ``""`` correspond to an empty
>      name)
> +  - names inside one GPIO controller/expander must be unique
>
>  Example of a GPIO controller of 16 lines, with an incomplete list with two
>  empty names::
> --
> 2.25.1
>


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] Documentation: ACPI: add new rule for gpio-line-names

[Rafael J. Wysocki]

On Fri, Jan 8, 2021 at 5:03 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Fri, Jan 8, 2021 at 5:28 PM Flavio Suligoi <f.suligoi@asem.it> wrote:
> >
> > The gpio-line-names lists must respect some rules.
> >
> > This patch adds a new rule in documentation, to avoid
> > the use of duplicate names in the same gpiochip.
>
> Thanks!
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> > Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> > ---
> >  Documentation/firmware-guide/acpi/gpio-properties.rst | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst
> > index b36aa3e743d8..4e264c16ddff 100644
> > --- a/Documentation/firmware-guide/acpi/gpio-properties.rst
> > +++ b/Documentation/firmware-guide/acpi/gpio-properties.rst
> > @@ -146,6 +146,7 @@ following rules (see also the examples):
> >      other words, it is not mandatory to fill all the GPIO lines
> >    - empty names are allowed (two quotation marks ``""`` correspond to an empty
> >      name)
> > +  - names inside one GPIO controller/expander must be unique
> >
> >  Example of a GPIO controller of 16 lines, with an incomplete list with two
> >  empty names::
> > --

Applied as 5.12 material, thanks!