From: Vinod Koul <vkoul@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Brown <broonie@kernel.org>, Wolfram Sang <wsa@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Andy Gross <agross@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>,
linux-spi <linux-spi@vger.kernel.org>,
linux-i2c@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi
Date: Mon, 11 Jan 2021 23:26:31 +0530 [thread overview]
Message-ID: <20210111175631.GD2771@vkoul-mobl> (raw)
In-Reply-To: <CAD=FV=UPNnSmgJM33QjAb4VvTe4Xs-OHcQCkk5E+o3u+afjbjA@mail.gmail.com>
On 11-01-21, 08:47, Doug Anderson wrote:
> Hi,
>
> On Mon, Jan 11, 2021 at 7:18 AM Vinod Koul <vkoul@kernel.org> wrote:
> >
> > @@ -2622,6 +2626,13 @@ pinmux {
> > "gpio2", "gpio3";
> > function = "qup0";
> > };
> > +
> > + config {
>
> Convention in Qualcomm device tree files seems to be that the node is
> "pinconf", not "config".
Yes missed that, thanks for pointing
>
>
> > + pins = "gpio0", "gpio1",
> > + "gpio2", "gpio3";
> > + drive-strength = <6>;
> > + bias-disable;
> > + };
>
> Pin config almost never belongs in the SoC dtsi file. This should be
> in the board .dts file. What if pulls are needed on some pins? What
> if you need a stronger or weaker drive strength?
Right I will move it to dtsi
--
~Vinod
next prev parent reply other threads:[~2021-01-11 17:57 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 15:16 [PATCH 0/7] Add and enable GPI DMA users Vinod Koul
2021-01-11 15:16 ` [PATCH 1/7] soc: qcom: geni: move GENI_IF_DISABLE_RO to common header Vinod Koul
2021-01-11 15:31 ` Bjorn Andersson
2021-01-11 15:16 ` [PATCH 2/7] soc: qcom: geni: move struct geni_wrapper to header Vinod Koul
2021-01-11 15:34 ` Bjorn Andersson
2021-01-11 17:43 ` Vinod Koul
2021-01-11 18:51 ` Bjorn Andersson
2021-01-11 15:16 ` [PATCH 3/7] soc: qcom: geni: Add support for gpi dma Vinod Koul
2021-01-11 15:40 ` Bjorn Andersson
2021-01-11 17:22 ` Vinod Koul
2021-01-13 0:01 ` Doug Anderson
2021-01-13 3:22 ` Vinod Koul
2021-01-11 15:16 ` [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma Vinod Koul
2021-01-11 16:35 ` Mark Brown
2021-06-16 8:50 ` Vinod Koul
2021-06-16 11:35 ` Mark Brown
2021-06-16 12:02 ` Vinod Koul
2021-06-17 6:20 ` Vinod Koul
2021-01-11 17:19 ` Bjorn Andersson
2021-01-12 7:31 ` Lukas Wunner
2021-01-13 0:01 ` Doug Anderson
2021-01-13 3:24 ` Vinod Koul
2021-02-04 21:34 ` Dmitry Baryshkov
2021-01-11 15:16 ` [PATCH 5/7] i2c: qcom-geni: Add support for GPI DMA Vinod Koul
2021-01-11 18:14 ` Bjorn Andersson
2021-01-12 5:50 ` Vinod Koul
2021-01-11 15:16 ` [PATCH 6/7] arm64: dts: qcom: sdm845: Add gpi dma node Vinod Koul
2021-01-11 18:23 ` Bjorn Andersson
2021-01-12 4:21 ` Vinod Koul
2021-01-11 15:16 ` [PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi Vinod Koul
2021-01-11 16:04 ` Konrad Dybcio
2021-01-11 17:46 ` Vinod Koul
2021-01-11 20:45 ` Konrad Dybcio
2021-01-12 4:19 ` Vinod Koul
2021-01-11 16:47 ` Doug Anderson
2021-01-11 17:56 ` Vinod Koul [this message]
2021-01-13 0:01 ` [PATCH 0/7] Add and enable GPI DMA users Doug Anderson
2021-01-13 3:03 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111175631.GD2771@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=sumit.semwal@linaro.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).