* [PATCH] imx: select SOC_BUS to fix firmware build
@ 2021-01-16 3:32 Randy Dunlap
2021-01-18 4:36 ` Aisheng Dong
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2021-01-16 3:32 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Atish Patra, Palmer Dabbelt,
Ard Biesheuvel, Anson Huang, Daniel Baluta, Shawn Guo,
Dong Aisheng
Fix build error in firmware/imx/ selecting SOC_BUS.
riscv32-linux-ld: drivers/firmware/imx/imx-scu-soc.o: in function `.L9':
imx-scu-soc.c:(.text+0x1b0): undefined reference to `soc_device_register'
Fixes: edbee095fafb ("firmware: imx: add SCU firmware driver support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Atish Patra <atish.patra@wdc.com>
Cc: Palmer Dabbelt <palmerdabbelt@google.com>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Anson Huang <Anson.Huang@nxp.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Dong Aisheng <aisheng.dong@nxp.com>
---
drivers/firmware/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20210115.orig/drivers/firmware/imx/Kconfig
+++ linux-next-20210115/drivers/firmware/imx/Kconfig
@@ -13,6 +13,7 @@ config IMX_DSP
config IMX_SCU
bool "IMX SCU Protocol driver"
depends on IMX_MBOX
+ select SOC_BUS
help
The System Controller Firmware (SCFW) is a low-level system function
which runs on a dedicated Cortex-M core to provide power, clock, and
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] imx: select SOC_BUS to fix firmware build
2021-01-16 3:32 [PATCH] imx: select SOC_BUS to fix firmware build Randy Dunlap
@ 2021-01-18 4:36 ` Aisheng Dong
2021-01-18 7:47 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Aisheng Dong @ 2021-01-18 4:36 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: kernel test robot, Atish Patra, Palmer Dabbelt, Ard Biesheuvel,
Anson Huang, Daniel Baluta, Shawn Guo
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Saturday, January 16, 2021 11:33 AM
> Subject: [PATCH] imx: select SOC_BUS to fix firmware build
Patch title probably is better to be:
firmware: imx: xxxxx
Otherwise:
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
>
> Fix build error in firmware/imx/ selecting SOC_BUS.
>
> riscv32-linux-ld: drivers/firmware/imx/imx-scu-soc.o: in function `.L9':
> imx-scu-soc.c:(.text+0x1b0): undefined reference to `soc_device_register'
>
> Fixes: edbee095fafb ("firmware: imx: add SCU firmware driver support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Atish Patra <atish.patra@wdc.com>
> Cc: Palmer Dabbelt <palmerdabbelt@google.com>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Anson Huang <Anson.Huang@nxp.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> drivers/firmware/imx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210115.orig/drivers/firmware/imx/Kconfig
> +++ linux-next-20210115/drivers/firmware/imx/Kconfig
> @@ -13,6 +13,7 @@ config IMX_DSP
> config IMX_SCU
> bool "IMX SCU Protocol driver"
> depends on IMX_MBOX
> + select SOC_BUS
> help
> The System Controller Firmware (SCFW) is a low-level system function
> which runs on a dedicated Cortex-M core to provide power, clock, and
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] imx: select SOC_BUS to fix firmware build
2021-01-18 4:36 ` Aisheng Dong
@ 2021-01-18 7:47 ` Shawn Guo
0 siblings, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2021-01-18 7:47 UTC (permalink / raw)
To: Aisheng Dong
Cc: Randy Dunlap, linux-kernel, kernel test robot, Atish Patra,
Palmer Dabbelt, Ard Biesheuvel, Anson Huang, Daniel Baluta
On Mon, Jan 18, 2021 at 04:36:55AM +0000, Aisheng Dong wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> > Sent: Saturday, January 16, 2021 11:33 AM
> > Subject: [PATCH] imx: select SOC_BUS to fix firmware build
>
> Patch title probably is better to be:
> firmware: imx: xxxxx
Fixed it up and applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-18 7:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-16 3:32 [PATCH] imx: select SOC_BUS to fix firmware build Randy Dunlap
2021-01-18 4:36 ` Aisheng Dong
2021-01-18 7:47 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).