* [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined
@ 2021-01-18 13:49 trix
2021-01-18 15:15 ` Daniel Lezcano
0 siblings, 1 reply; 3+ messages in thread
From: trix @ 2021-01-18 13:49 UTC (permalink / raw)
To: daniel.lezcano, tglx, shawnguo, s.hauer, kernel, festevam,
linux-imx, viresh.kumar
Cc: linux-kernel, linux-arm-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
When DEBUG is defined this error occurs
drivers/clocksource/mxs_timer.c:138:1: error:
expected ‘;’ before ‘}’ token
The preceding statement needs a semicolon.
Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/clocksource/mxs_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
index bc96a4cbf26c..55aa6b72d075 100644
--- a/drivers/clocksource/mxs_timer.c
+++ b/drivers/clocksource/mxs_timer.c
@@ -133,7 +133,7 @@ static void mxs_irq_clear(char *state)
timrot_irq_acknowledge();
#ifdef DEBUG
- pr_info("%s: changing mode to %s\n", __func__, state)
+ pr_info("%s: changing mode to %s\n", __func__, state);
#endif /* DEBUG */
}
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined
2021-01-18 13:49 [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined trix
@ 2021-01-18 15:15 ` Daniel Lezcano
2021-01-18 16:22 ` Tom Rix
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Lezcano @ 2021-01-18 15:15 UTC (permalink / raw)
To: trix, tglx, shawnguo, s.hauer, kernel, festevam, linux-imx, viresh.kumar
Cc: linux-kernel, linux-arm-kernel
On 18/01/2021 14:49, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> When DEBUG is defined this error occurs
>
> drivers/clocksource/mxs_timer.c:138:1: error:
> expected ‘;’ before ‘}’ token
>
> The preceding statement needs a semicolon.
>
> Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/clocksource/mxs_timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
> index bc96a4cbf26c..55aa6b72d075 100644
> --- a/drivers/clocksource/mxs_timer.c
> +++ b/drivers/clocksource/mxs_timer.c
> @@ -133,7 +133,7 @@ static void mxs_irq_clear(char *state)
> timrot_irq_acknowledge();
>
> #ifdef DEBUG
> - pr_info("%s: changing mode to %s\n", __func__, state)
> + pr_info("%s: changing mode to %s\n", __func__, state);
> #endif /* DEBUG */
Mind to replace by pr_debug and remove the #ifdef ?
> }
>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined
2021-01-18 15:15 ` Daniel Lezcano
@ 2021-01-18 16:22 ` Tom Rix
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rix @ 2021-01-18 16:22 UTC (permalink / raw)
To: Daniel Lezcano, tglx, shawnguo, s.hauer, kernel, festevam,
linux-imx, viresh.kumar
Cc: linux-kernel, linux-arm-kernel
On 1/18/21 7:15 AM, Daniel Lezcano wrote:
> On 18/01/2021 14:49, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> When DEBUG is defined this error occurs
>>
>> drivers/clocksource/mxs_timer.c:138:1: error:
>> expected ‘;’ before ‘}’ token
>>
>> The preceding statement needs a semicolon.
>>
>> Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> drivers/clocksource/mxs_timer.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
>> index bc96a4cbf26c..55aa6b72d075 100644
>> --- a/drivers/clocksource/mxs_timer.c
>> +++ b/drivers/clocksource/mxs_timer.c
>> @@ -133,7 +133,7 @@ static void mxs_irq_clear(char *state)
>> timrot_irq_acknowledge();
>>
>> #ifdef DEBUG
>> - pr_info("%s: changing mode to %s\n", __func__, state)
>> + pr_info("%s: changing mode to %s\n", __func__, state);
>> #endif /* DEBUG */
> Mind to replace by pr_debug and remove the #ifdef ?
ok.
>
>> }
>>
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-18 16:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 13:49 [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined trix
2021-01-18 15:15 ` Daniel Lezcano
2021-01-18 16:22 ` Tom Rix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).