* [PATCH] Revert "checkpatch: add check for keyword 'boolean' in Kconfig definitions"
@ 2021-01-26 19:15 Masahiro Yamada
2021-01-27 3:02 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2021-01-26 19:15 UTC (permalink / raw)
To: linux-kbuild
Cc: Joe Perches, Christoph Jaeger, Masahiro Yamada, Andy Whitcroft,
linux-kernel
This reverts commit 327953e9af6c59ad111b28359e59e3ec0cbd71b6.
You cannot use 'boolean' since commit b92d804a5179 ("kconfig: drop
'boolean' keyword").
This check is no longer needed.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
scripts/checkpatch.pl | 7 -------
1 file changed, 7 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 92e888ed939f..1afe3af1cc09 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3390,13 +3390,6 @@ sub process {
}
}
-# discourage the use of boolean for type definition attributes of Kconfig options
- if ($realfile =~ /Kconfig/ &&
- $line =~ /^\+\s*\bboolean\b/) {
- WARN("CONFIG_TYPE_BOOLEAN",
- "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
- }
-
if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
my $flag = $1;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "checkpatch: add check for keyword 'boolean' in Kconfig definitions"
2021-01-26 19:15 [PATCH] Revert "checkpatch: add check for keyword 'boolean' in Kconfig definitions" Masahiro Yamada
@ 2021-01-27 3:02 ` Joe Perches
2021-01-28 6:39 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2021-01-27 3:02 UTC (permalink / raw)
To: Masahiro Yamada, linux-kbuild
Cc: Christoph Jaeger, Andy Whitcroft, linux-kernel
On Wed, 2021-01-27 at 04:15 +0900, Masahiro Yamada wrote:
> This reverts commit 327953e9af6c59ad111b28359e59e3ec0cbd71b6.
>
> You cannot use 'boolean' since commit b92d804a5179 ("kconfig: drop
> 'boolean' keyword").
>
> This check is no longer needed.
Thanks.
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Joe Perches <joe@perches.com>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3390,13 +3390,6 @@ sub process {
> }
> }
>
> -# discourage the use of boolean for type definition attributes of Kconfig options
> - if ($realfile =~ /Kconfig/ &&
> - $line =~ /^\+\s*\bboolean\b/) {
> - WARN("CONFIG_TYPE_BOOLEAN",
> - "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
> - }
> -
> if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
> ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
> my $flag = $1;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "checkpatch: add check for keyword 'boolean' in Kconfig definitions"
2021-01-27 3:02 ` Joe Perches
@ 2021-01-28 6:39 ` Masahiro Yamada
0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2021-01-28 6:39 UTC (permalink / raw)
To: Joe Perches
Cc: Linux Kbuild mailing list, Christoph Jaeger, Andy Whitcroft,
Linux Kernel Mailing List
On Wed, Jan 27, 2021 at 12:02 PM Joe Perches <joe@perches.com> wrote:
>
> On Wed, 2021-01-27 at 04:15 +0900, Masahiro Yamada wrote:
> > This reverts commit 327953e9af6c59ad111b28359e59e3ec0cbd71b6.
> >
> > You cannot use 'boolean' since commit b92d804a5179 ("kconfig: drop
> > 'boolean' keyword").
> >
> > This check is no longer needed.
>
Applied to linux-kbuild.
> Thanks.
>
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> Acked-by: Joe Perches <joe@perches.com>
>
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -3390,13 +3390,6 @@ sub process {
> > }
> > }
> >
> > -# discourage the use of boolean for type definition attributes of Kconfig options
> > - if ($realfile =~ /Kconfig/ &&
> > - $line =~ /^\+\s*\bboolean\b/) {
> > - WARN("CONFIG_TYPE_BOOLEAN",
> > - "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
> > - }
> > -
> > if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
> > ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
> > my $flag = $1;
>
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-28 6:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26 19:15 [PATCH] Revert "checkpatch: add check for keyword 'boolean' in Kconfig definitions" Masahiro Yamada
2021-01-27 3:02 ` Joe Perches
2021-01-28 6:39 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).