* [PATCH] scripts/spelling.txt: increase error-prone spell checking
@ 2021-01-27 3:01 dingsenjie
2021-01-27 7:47 ` SeongJae Park
0 siblings, 1 reply; 11+ messages in thread
From: dingsenjie @ 2021-01-27 3:01 UTC (permalink / raw)
To: akpm, colin.king, naoki.hayama, xndchn, sjpark, ebiggers, joe
Cc: linux-kernel, dingsenjie
From: dingsenjie <dingsenjie@yulong.com>
Increase allocted spelling error check.
Signed-off-by: dingsenjie <dingsenjie@yulong.com>
---
scripts/spelling.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/spelling.txt b/scripts/spelling.txt
index 953f4a2..5fa8ec2 100644
--- a/scripts/spelling.txt
+++ b/scripts/spelling.txt
@@ -103,6 +103,7 @@ alloated||allocated
allocatote||allocate
allocatrd||allocated
allocte||allocate
+allocted||allocated
allpication||application
alocate||allocate
alogirhtms||algorithms
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] scripts/spelling.txt: increase error-prone spell checking
2021-01-27 3:01 [PATCH] scripts/spelling.txt: increase error-prone spell checking dingsenjie
@ 2021-01-27 7:47 ` SeongJae Park
0 siblings, 0 replies; 11+ messages in thread
From: SeongJae Park @ 2021-01-27 7:47 UTC (permalink / raw)
To: dingsenjie
Cc: akpm, colin.king, naoki.hayama, xndchn, sjpark, ebiggers, joe,
linux-kernel, dingsenjie
On Wed, 27 Jan 2021 11:01:05 +0800 dingsenjie@163.com wrote:
> From: dingsenjie <dingsenjie@yulong.com>
>
> Increase allocted spelling error check.
I think you could improve the title and the commit message. You could
refer to
https://lore.kernel.org/lkml/7937a406-812e-0a41-12c5-41576737a44f@lucaceresoli.net/
Thanks,
SeongJae Park
>
> Signed-off-by: dingsenjie <dingsenjie@yulong.com>
> ---
> scripts/spelling.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> index 953f4a2..5fa8ec2 100644
> --- a/scripts/spelling.txt
> +++ b/scripts/spelling.txt
> @@ -103,6 +103,7 @@ alloated||allocated
> allocatote||allocate
> allocatrd||allocated
> allocte||allocate
> +allocted||allocated
> allpication||application
> alocate||allocate
> alogirhtms||algorithms
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] scripts/spelling.txt: increase error-prone spell checking
2021-01-27 6:00 zuoqilin1
@ 2021-01-27 7:55 ` SeongJae Park
0 siblings, 0 replies; 11+ messages in thread
From: SeongJae Park @ 2021-01-27 7:55 UTC (permalink / raw)
To: zuoqilin1
Cc: akpm, colin.king, ebiggers, sjpark, xndchn, linux-kernel, zuoqilin
On Wed, 27 Jan 2021 14:00:49 +0800 zuoqilin1@163.com wrote:
> From: zuoqilin <zuoqilin@yulong.com>
>
> Increase exeeds spelling error check.
Why don't you consolidate this with your previous patch[1]?
Also, I think you could improve the title and the commit message. You could
refer to
https://lore.kernel.org/lkml/7937a406-812e-0a41-12c5-41576737a44f@lucaceresoli.net/
[1] https://lore.kernel.org/lkml/20210127030105.7244-1-dingsenjie@163.com/
>
> Signed-off-by: zuoqilin <zuoqilin@yulong.com>
> ---
> scripts/spelling.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> index 953f4a2..740aba3 100644
> --- a/scripts/spelling.txt
> +++ b/scripts/spelling.txt
> @@ -566,6 +566,7 @@ estbalishment||establishment
> etsablishment||establishment
> etsbalishment||establishment
> evalution||evaluation
> +exeeds||exceeds
> excecutable||executable
> exceded||exceeded
> exceds||exceeds
Similar misspellings should be grouped together, so this would be better to be
placed under exceds.
Thanks,
SeongJae Park
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] scripts/spelling.txt: increase error-prone spell checking
@ 2021-01-27 6:00 zuoqilin1
2021-01-27 7:55 ` SeongJae Park
0 siblings, 1 reply; 11+ messages in thread
From: zuoqilin1 @ 2021-01-27 6:00 UTC (permalink / raw)
To: akpm, colin.king, ebiggers, sjpark, xndchn; +Cc: linux-kernel, zuoqilin
From: zuoqilin <zuoqilin@yulong.com>
Increase exeeds spelling error check.
Signed-off-by: zuoqilin <zuoqilin@yulong.com>
---
scripts/spelling.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/spelling.txt b/scripts/spelling.txt
index 953f4a2..740aba3 100644
--- a/scripts/spelling.txt
+++ b/scripts/spelling.txt
@@ -566,6 +566,7 @@ estbalishment||establishment
etsablishment||establishment
etsbalishment||establishment
evalution||evaluation
+exeeds||exceeds
excecutable||executable
exceded||exceeded
exceds||exceeds
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] scripts/spelling.txt: increase error-prone spell checking
2021-01-21 9:36 ` Joe Perches
@ 2021-01-21 9:49 ` Naoki Hayama
0 siblings, 0 replies; 11+ messages in thread
From: Naoki Hayama @ 2021-01-21 9:49 UTC (permalink / raw)
To: Joe Perches, Luca Ceresoli, Chunyou Tang
Cc: Randy Dunlap, akpm, colin.king, xndchn, j.neuschaefer, ebiggers,
sjpark, linux-kernel, zhangwen, tangchunyou
Dear Joe,
On 2021/01/21 18:36, Joe Perches wrote:
> On Thu, 2021-01-21 at 18:14 +0900, Naoki Hayama wrote:
>> On 2021/01/21 17:41, Luca Ceresoli wrote:
>>> On 21/01/21 04:21, Chunyou Tang wrote:
>>>> On Wed, 20 Jan 2021 19:09:05 -0800 Joe Perches <joe@perches.com> wrote:
>>>>> On Wed, 2021-01-20 at 19:02 -0800, Randy Dunlap wrote:
>>>>>> On 1/20/21 6:07 PM, ChunyouTang wrote:
>>>>>>> From: tangchunyou <tangchunyou@yulong.com>
> []
>>>>>>> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
>>>>> []
>>>>>>> @@ -875,6 +875,7 @@ manger||manager
>>>>>>> manoeuvering||maneuvering
>>>>>>> manufaucturing||manufacturing
>>>>>>> mappping||mapping
>>>>>>> +maping||mapping
>>>>>>> matchs||matches
>>>>>>> mathimatical||mathematical
>>>>>>> mathimatic||mathematic
> []
>> Rules in scripts/spelling.txt are sorted
>> alphabetically by leftside words. It would
>> be better that you insert "maping||mapping"
>> rule between:
>>
>> "manufaucturing||manufacturing"
>> and
>> "mappping||mapping" .
>
> That's not really true. Try a diff of $ sort < scripts/spelling.txt
>
> The general rule of thumb, and it's only a rule of thumb and it is
> not strictly enforced, is that similar misspellings are grouped
> together.
>
>
Thank you for pointing out. I misunderstood about it.
Sorry for the confusion.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] scripts/spelling.txt: increase error-prone spell checking
2021-01-21 9:14 ` Naoki Hayama
@ 2021-01-21 9:36 ` Joe Perches
2021-01-21 9:49 ` Naoki Hayama
0 siblings, 1 reply; 11+ messages in thread
From: Joe Perches @ 2021-01-21 9:36 UTC (permalink / raw)
To: Naoki Hayama, Luca Ceresoli, Chunyou Tang
Cc: Randy Dunlap, akpm, colin.king, xndchn, j.neuschaefer, ebiggers,
sjpark, linux-kernel, zhangwen, tangchunyou
On Thu, 2021-01-21 at 18:14 +0900, Naoki Hayama wrote:
> On 2021/01/21 17:41, Luca Ceresoli wrote:
> > On 21/01/21 04:21, Chunyou Tang wrote:
> > > On Wed, 20 Jan 2021 19:09:05 -0800 Joe Perches <joe@perches.com> wrote:
> > > > On Wed, 2021-01-20 at 19:02 -0800, Randy Dunlap wrote:
> > > > > On 1/20/21 6:07 PM, ChunyouTang wrote:
> > > > > > From: tangchunyou <tangchunyou@yulong.com>
[]
> > > > > > diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> > > > []
> > > > > > @@ -875,6 +875,7 @@ manger||manager
> > > > > > manoeuvering||maneuvering
> > > > > > manufaucturing||manufacturing
> > > > > > mappping||mapping
> > > > > > +maping||mapping
> > > > > > matchs||matches
> > > > > > mathimatical||mathematical
> > > > > > mathimatic||mathematic
[]
> Rules in scripts/spelling.txt are sorted
> alphabetically by leftside words. It would
> be better that you insert "maping||mapping"
> rule between:
>
> "manufaucturing||manufacturing"
> and
> "mappping||mapping" .
That's not really true. Try a diff of $ sort < scripts/spelling.txt
The general rule of thumb, and it's only a rule of thumb and it is
not strictly enforced, is that similar misspellings are grouped
together.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] scripts/spelling.txt: increase error-prone spell checking
2021-01-21 8:41 ` Luca Ceresoli
@ 2021-01-21 9:14 ` Naoki Hayama
2021-01-21 9:36 ` Joe Perches
0 siblings, 1 reply; 11+ messages in thread
From: Naoki Hayama @ 2021-01-21 9:14 UTC (permalink / raw)
To: Luca Ceresoli, Chunyou Tang, Joe Perches
Cc: Randy Dunlap, akpm, colin.king, xndchn, j.neuschaefer, ebiggers,
sjpark, linux-kernel, zhangwen, tangchunyou
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 1543 bytes --]
Dear Chunyou,
On 2021/01/21 17:41, Luca Ceresoli wrote:
> Hi,
>
> On 21/01/21 04:21, Chunyou Tang wrote:
>> On Wed, 20 Jan 2021 19:09:05 -0800
>> Joe Perches <joe@perches.com> wrote:
>>
>>> On Wed, 2021-01-20 at 19:02 -0800, Randy Dunlap wrote:
>>>> On 1/20/21 6:07 PM, ChunyouTang wrote:
>>>>> From: tangchunyou <tangchunyou@yulong.com>
>>>>>
>>>>> Increase direcly,maping,manger spelling error check
>>>>
>>>> Hi,
>>>> I don't see all of those in the patch below.
>>>> What happened?
>>>
>>> I think mostly it's just a poor commit message as
>>> direcly and manger are already in spelling.txt
>>>
>>>>> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
>>> []
>>>>> @@ -875,6 +875,7 @@ manger||manager
>>>>> 02manoeuvering||maneuvering
>>>>> 02manufaucturing||manufacturing
>>>>> 02mappping||mapping
>>>>> +maping||mapping
>>>>> 02matchs||matches
>>>>> 02mathimatical||mathematical
>>>>> 02mathimatic||mathematic
>>>
>>
>> yes,you are right,the commit message is bad,I change the commit message
>>
>> and resend it.
>
> While doing that, also improve the subject (1st line of commit message)
> by mentioning the typo you are adding. For example, as in previous commits:
>
> scripts/spelling.txt: add "maping" typo
>
> It's more informative and even shorter.
>
> Thanks
>
Rules in scripts/spelling.txt are sorted
alphabetically by leftside words. It would
be better that you insert "maping||mapping"
rule between:
"manufaucturing||manufacturing"
and
"mappping||mapping" .
Best regards,
Naoki Hayama
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] scripts/spelling.txt: increase error-prone spell checking
[not found] ` <20210121112115.00005cb6@163.com>
@ 2021-01-21 8:41 ` Luca Ceresoli
2021-01-21 9:14 ` Naoki Hayama
0 siblings, 1 reply; 11+ messages in thread
From: Luca Ceresoli @ 2021-01-21 8:41 UTC (permalink / raw)
To: Chunyou Tang, Joe Perches
Cc: Randy Dunlap, akpm, colin.king, xndchn, j.neuschaefer,
naoki.hayama, ebiggers, sjpark, linux-kernel, zhangwen,
tangchunyou
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 1209 bytes --]
Hi,
On 21/01/21 04:21, Chunyou Tang wrote:
> On Wed, 20 Jan 2021 19:09:05 -0800
> Joe Perches <joe@perches.com> wrote:
>
>> On Wed, 2021-01-20 at 19:02 -0800, Randy Dunlap wrote:
>>> On 1/20/21 6:07 PM, ChunyouTang wrote:
>>>> From: tangchunyou <tangchunyou@yulong.com>
>>>>
>>>> Increase direcly,maping,manger spelling error check
>>>
>>> Hi,
>>> I don't see all of those in the patch below.
>>> What happened?
>>
>> I think mostly it's just a poor commit message as
>> direcly and manger are already in spelling.txt
>>
>>>> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
>> []
>>>> @@ -875,6 +875,7 @@ manger||manager
>>>> 02manoeuvering||maneuvering
>>>> 02manufaucturing||manufacturing
>>>> 02mappping||mapping
>>>> +maping||mapping
>>>> 02matchs||matches
>>>> 02mathimatical||mathematical
>>>> 02mathimatic||mathematic
>>
>
> yes,you are right,the commit message is bad,I change the commit message
>
> and resend it.
While doing that, also improve the subject (1st line of commit message)
by mentioning the typo you are adding. For example, as in previous commits:
scripts/spelling.txt: add "maping" typo
It's more informative and even shorter.
Thanks
--
Luca
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] scripts/spelling.txt: increase error-prone spell checking
2021-01-21 3:02 ` Randy Dunlap
@ 2021-01-21 3:09 ` Joe Perches
[not found] ` <20210121112115.00005cb6@163.com>
0 siblings, 1 reply; 11+ messages in thread
From: Joe Perches @ 2021-01-21 3:09 UTC (permalink / raw)
To: Randy Dunlap, ChunyouTang, akpm, colin.king, xndchn,
j.neuschaefer, luca, naoki.hayama, ebiggers, sjpark
Cc: linux-kernel, zhangwen, tangchunyou
On Wed, 2021-01-20 at 19:02 -0800, Randy Dunlap wrote:
> On 1/20/21 6:07 PM, ChunyouTang wrote:
> > From: tangchunyou <tangchunyou@yulong.com>
> >
> > Increase direcly,maping,manger spelling error check
>
> Hi,
> I don't see all of those in the patch below.
> What happened?
I think mostly it's just a poor commit message as
direcly and manger are already in spelling.txt
> > diff --git a/scripts/spelling.txt b/scripts/spelling.txt
[]
> > @@ -875,6 +875,7 @@ manger||manager
> > manoeuvering||maneuvering
> > manufaucturing||manufacturing
> > mappping||mapping
> > +maping||mapping
> > matchs||matches
> > mathimatical||mathematical
> > mathimatic||mathematic
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] scripts/spelling.txt: increase error-prone spell checking
2021-01-21 2:07 ChunyouTang
@ 2021-01-21 3:02 ` Randy Dunlap
2021-01-21 3:09 ` Joe Perches
0 siblings, 1 reply; 11+ messages in thread
From: Randy Dunlap @ 2021-01-21 3:02 UTC (permalink / raw)
To: ChunyouTang, akpm, colin.king, xndchn, j.neuschaefer, luca,
naoki.hayama, ebiggers, sjpark, joe
Cc: linux-kernel, zhangwen, tangchunyou
On 1/20/21 6:07 PM, ChunyouTang wrote:
> From: tangchunyou <tangchunyou@yulong.com>
>
> Increase direcly,maping,manger spelling error check
Hi,
I don't see all of those in the patch below.
What happened?
> Signed-off-by: WenZhang <zhangwen@yulong.com>
> ---
> scripts/spelling.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> index 953f4a2..ebcb27b 100644
> --- a/scripts/spelling.txt
> +++ b/scripts/spelling.txt
> @@ -875,6 +875,7 @@ manger||manager
> manoeuvering||maneuvering
> manufaucturing||manufacturing
> mappping||mapping
> +maping||mapping
> matchs||matches
> mathimatical||mathematical
> mathimatic||mathematic
>
thanks.
--
~Randy
"He closes his eyes and drops the goggles. You can't get hurt
by looking at a bitmap. Or can you?"
(Neal Stephenson: Snow Crash)
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] scripts/spelling.txt: increase error-prone spell checking
@ 2021-01-21 2:07 ChunyouTang
2021-01-21 3:02 ` Randy Dunlap
0 siblings, 1 reply; 11+ messages in thread
From: ChunyouTang @ 2021-01-21 2:07 UTC (permalink / raw)
To: akpm, colin.king, xndchn, j.neuschaefer, luca, naoki.hayama,
ebiggers, sjpark, joe
Cc: linux-kernel, zhangwen, tangchunyou
From: tangchunyou <tangchunyou@yulong.com>
Increase direcly,maping,manger spelling error check
Signed-off-by: WenZhang <zhangwen@yulong.com>
---
scripts/spelling.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/spelling.txt b/scripts/spelling.txt
index 953f4a2..ebcb27b 100644
--- a/scripts/spelling.txt
+++ b/scripts/spelling.txt
@@ -875,6 +875,7 @@ manger||manager
manoeuvering||maneuvering
manufaucturing||manufacturing
mappping||mapping
+maping||mapping
matchs||matches
mathimatical||mathematical
mathimatic||mathematic
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-01-27 8:05 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-27 3:01 [PATCH] scripts/spelling.txt: increase error-prone spell checking dingsenjie
2021-01-27 7:47 ` SeongJae Park
-- strict thread matches above, loose matches on Subject: below --
2021-01-27 6:00 zuoqilin1
2021-01-27 7:55 ` SeongJae Park
2021-01-21 2:07 ChunyouTang
2021-01-21 3:02 ` Randy Dunlap
2021-01-21 3:09 ` Joe Perches
[not found] ` <20210121112115.00005cb6@163.com>
2021-01-21 8:41 ` Luca Ceresoli
2021-01-21 9:14 ` Naoki Hayama
2021-01-21 9:36 ` Joe Perches
2021-01-21 9:49 ` Naoki Hayama
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).