* [PATCH v2] ARM: dts: sun5i: Add dts for inet86v_rev2
@ 2021-01-24 19:39 Alexandre GRIVEAUX
2021-01-28 17:23 ` Maxime Ripard
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre GRIVEAUX @ 2021-01-24 19:39 UTC (permalink / raw)
To: robh+dt, mripard, wens, jernej.skrabec
Cc: linux-kernel, devicetree, Alexandre GRIVEAUX
Add Inet 86V Rev 2 support, based upon Inet 86VS.
The Inet 86V use SL1536 touchpanel controller, the Inet 86VS a GSL1680,
which make them both incompatible.
Missing things:
- Accelerometer (MXC6225X)
- Touchpanel (Sitronix SL1536)
- Nand (29F32G08CBACA)
- Camera (HCWY0308)
Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
---
arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
diff --git a/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
new file mode 100644
index 000000000000..581083e932d8
--- /dev/null
+++ b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2021 Alexandre Griveaux <agriveaux@deutnet.info>
+ *
+ * Minimal dts file for the iNet 86V
+ */
+
+/dts-v1/;
+
+#include "sun5i-a13.dtsi"
+#include "sun5i-reference-design-tablet.dtsi"
+
+/ {
+ model = "iNET 86V Rev 02";
+ compatible = "inet,86v-rev2", "allwinner,sun5i-a13";
+
+};
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ARM: dts: sun5i: Add dts for inet86v_rev2
2021-01-24 19:39 [PATCH v2] ARM: dts: sun5i: Add dts for inet86v_rev2 Alexandre GRIVEAUX
@ 2021-01-28 17:23 ` Maxime Ripard
2021-02-01 17:18 ` agriveaux
0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2021-01-28 17:23 UTC (permalink / raw)
To: Alexandre GRIVEAUX
Cc: robh+dt, wens, jernej.skrabec, linux-kernel, devicetree
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
Hi,
On Sun, Jan 24, 2021 at 08:39:03PM +0100, Alexandre GRIVEAUX wrote:
> Add Inet 86V Rev 2 support, based upon Inet 86VS.
>
> The Inet 86V use SL1536 touchpanel controller, the Inet 86VS a GSL1680,
> which make them both incompatible.
>
> Missing things:
> - Accelerometer (MXC6225X)
> - Touchpanel (Sitronix SL1536)
> - Nand (29F32G08CBACA)
> - Camera (HCWY0308)
>
> Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> ---
> arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts | 17 +++++++++++++++++
You have to add it to the Makefile
> 1 file changed, 17 insertions(+)
> create mode 100644 arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
>
> diff --git a/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> new file mode 100644
> index 000000000000..581083e932d8
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> @@ -0,0 +1,17 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright 2021 Alexandre Griveaux <agriveaux@deutnet.info>
> + *
> + * Minimal dts file for the iNet 86V
> + */
> +
> +/dts-v1/;
> +
> +#include "sun5i-a13.dtsi"
> +#include "sun5i-reference-design-tablet.dtsi"
> +
> +/ {
> + model = "iNET 86V Rev 02";
> + compatible = "inet,86v-rev2", "allwinner,sun5i-a13";
inet should be documented in the vendor prefixes, and that compatible
should be documented in Documentation/devicetree/bindings/arm/sunxi.yaml
Having the first rev compatible would be good too
> +
> +};
But I'm wondering. If there's nothing here to add, why would we need
that DT in the first place?
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ARM: dts: sun5i: Add dts for inet86v_rev2
2021-01-28 17:23 ` Maxime Ripard
@ 2021-02-01 17:18 ` agriveaux
2021-02-03 9:21 ` Maxime Ripard
0 siblings, 1 reply; 5+ messages in thread
From: agriveaux @ 2021-02-01 17:18 UTC (permalink / raw)
To: Maxime Ripard, robh+dt, mark.rutland, wens
Cc: linux-kernel, devicetree, agriveaux
On Thu, Jan 28, 2021 at 06:23:29PM +0100, Maxime Ripard wrote:
> Hi,
Hi,
>
> On Sun, Jan 24, 2021 at 08:39:03PM +0100, Alexandre GRIVEAUX wrote:
> > Add Inet 86V Rev 2 support, based upon Inet 86VS.
> >
> > The Inet 86V use SL1536 touchpanel controller, the Inet 86VS a GSL1680,
> > which make them both incompatible.
> >
> > Missing things:
> > - Accelerometer (MXC6225X)
> > - Touchpanel (Sitronix SL1536)
> > - Nand (29F32G08CBACA)
> > - Camera (HCWY0308)
> >
> > Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> > ---
> > arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts | 17 +++++++++++++++++
>
> You have to add it to the Makefile
>
Ok.
> > 1 file changed, 17 insertions(+)
> > create mode 100644 arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> >
> > diff --git a/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> > new file mode 100644
> > index 000000000000..581083e932d8
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> > @@ -0,0 +1,17 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright 2021 Alexandre Griveaux <agriveaux@deutnet.info>
> > + *
> > + * Minimal dts file for the iNet 86V
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "sun5i-a13.dtsi"
> > +#include "sun5i-reference-design-tablet.dtsi"
> > +
> > +/ {
> > + model = "iNET 86V Rev 02";
> > + compatible = "inet,86v-rev2", "allwinner,sun5i-a13";
>
> inet should be documented in the vendor prefixes, and that compatible
> should be documented in Documentation/devicetree/bindings/arm/sunxi.yaml
>
I forgot, but should be:
- description: iNet-86V Rev 02
items:
- const: primux,inet86v-rev2
- const: allwinner,sun5i-a13
> Having the first rev compatible would be good too
Unfortunatly, I didn't find inet86v rev1 on FCC website and on
linux-sunxi.
>
> > +
> > +};
>
> But I'm wondering. If there's nothing here to add, why would we need
> that DT in the first place?
>
I prefer to add often instead of bulk adding, and to show there are some
board to add missing things like those above.
> Maxime
Thanks,
Alexandre.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ARM: dts: sun5i: Add dts for inet86v_rev2
2021-02-01 17:18 ` agriveaux
@ 2021-02-03 9:21 ` Maxime Ripard
2021-02-09 7:26 ` Alexandre GRIVEAUX
0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2021-02-03 9:21 UTC (permalink / raw)
To: agriveaux; +Cc: robh+dt, mark.rutland, wens, linux-kernel, devicetree
[-- Attachment #1: Type: text/plain, Size: 2525 bytes --]
On Mon, Feb 01, 2021 at 06:18:18PM +0100, agriveaux wrote:
> On Thu, Jan 28, 2021 at 06:23:29PM +0100, Maxime Ripard wrote:
> > Hi,
> Hi,
> >
> > On Sun, Jan 24, 2021 at 08:39:03PM +0100, Alexandre GRIVEAUX wrote:
> > > Add Inet 86V Rev 2 support, based upon Inet 86VS.
> > >
> > > The Inet 86V use SL1536 touchpanel controller, the Inet 86VS a GSL1680,
> > > which make them both incompatible.
> > >
> > > Missing things:
> > > - Accelerometer (MXC6225X)
> > > - Touchpanel (Sitronix SL1536)
> > > - Nand (29F32G08CBACA)
> > > - Camera (HCWY0308)
> > >
> > > Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> > > ---
> > > arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts | 17 +++++++++++++++++
> >
> > You have to add it to the Makefile
> >
> Ok.
> > > 1 file changed, 17 insertions(+)
> > > create mode 100644 arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> > >
> > > diff --git a/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> > > new file mode 100644
> > > index 000000000000..581083e932d8
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> > > @@ -0,0 +1,17 @@
> > > +// SPDX-License-Identifier: GPL-2.0+
> > > +/*
> > > + * Copyright 2021 Alexandre Griveaux <agriveaux@deutnet.info>
> > > + *
> > > + * Minimal dts file for the iNet 86V
> > > + */
> > > +
> > > +/dts-v1/;
> > > +
> > > +#include "sun5i-a13.dtsi"
> > > +#include "sun5i-reference-design-tablet.dtsi"
> > > +
> > > +/ {
> > > + model = "iNET 86V Rev 02";
> > > + compatible = "inet,86v-rev2", "allwinner,sun5i-a13";
> >
> > inet should be documented in the vendor prefixes, and that compatible
> > should be documented in Documentation/devicetree/bindings/arm/sunxi.yaml
> >
>
> I forgot, but should be:
>
> - description: iNet-86V Rev 02
> items:
> - const: primux,inet86v-rev2
> - const: allwinner,sun5i-a13
>
> > Having the first rev compatible would be good too
>
> Unfortunatly, I didn't find inet86v rev1 on FCC website and on
> linux-sunxi.
>
> >
> > > +
> > > +};
> >
> > But I'm wondering. If there's nothing here to add, why would we need
> > that DT in the first place?
> >
> I prefer to add often instead of bulk adding, and to show there are some
> board to add missing things like those above.
Yeah, I get that, but the point really is that you're not really adding
anything here except an empty device tree.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ARM: dts: sun5i: Add dts for inet86v_rev2
2021-02-03 9:21 ` Maxime Ripard
@ 2021-02-09 7:26 ` Alexandre GRIVEAUX
0 siblings, 0 replies; 5+ messages in thread
From: Alexandre GRIVEAUX @ 2021-02-09 7:26 UTC (permalink / raw)
To: Maxime Ripard; +Cc: robh+dt, mark.rutland, wens, linux-kernel, devicetree
On Wed, Feb 03, 2021 at 10:21:03AM +0100, Maxime Ripard wrote:
> On Mon, Feb 01, 2021 at 06:18:18PM +0100, agriveaux wrote:
> > On Thu, Jan 28, 2021 at 06:23:29PM +0100, Maxime Ripard wrote:
> > > Hi,
> > Hi,
Hello,
> > >
> > > On Sun, Jan 24, 2021 at 08:39:03PM +0100, Alexandre GRIVEAUX wrote:
> > > > Add Inet 86V Rev 2 support, based upon Inet 86VS.
> > > >
> > > > The Inet 86V use SL1536 touchpanel controller, the Inet 86VS a GSL1680,
> > > > which make them both incompatible.
> > > >
> > > > Missing things:
> > > > - Accelerometer (MXC6225X)
> > > > - Touchpanel (Sitronix SL1536)
> > > > - Nand (29F32G08CBACA)
> > > > - Camera (HCWY0308)
> > > >
> > > > Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> > > > ---
> > > > arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts | 17 +++++++++++++++++
> > >
> > > You have to add it to the Makefile
> > >
> > Ok.
> > > > 1 file changed, 17 insertions(+)
> > > > create mode 100644 arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> > > >
> > > > diff --git a/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> > > > new file mode 100644
> > > > index 000000000000..581083e932d8
> > > > --- /dev/null
> > > > +++ b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts
> > > > @@ -0,0 +1,17 @@
> > > > +// SPDX-License-Identifier: GPL-2.0+
> > > > +/*
> > > > + * Copyright 2021 Alexandre Griveaux <agriveaux@deutnet.info>
> > > > + *
> > > > + * Minimal dts file for the iNet 86V
> > > > + */
> > > > +
> > > > +/dts-v1/;
> > > > +
> > > > +#include "sun5i-a13.dtsi"
> > > > +#include "sun5i-reference-design-tablet.dtsi"
> > > > +
> > > > +/ {
> > > > + model = "iNET 86V Rev 02";
> > > > + compatible = "inet,86v-rev2", "allwinner,sun5i-a13";
> > >
> > > inet should be documented in the vendor prefixes, and that compatible
> > > should be documented in Documentation/devicetree/bindings/arm/sunxi.yaml
> > >
> >
> > I forgot, but should be:
> >
> > - description: iNet-86V Rev 02
> > items:
> > - const: primux,inet86v-rev2
> > - const: allwinner,sun5i-a13
> >
> > > Having the first rev compatible would be good too
> >
> > Unfortunatly, I didn't find inet86v rev1 on FCC website and on
> > linux-sunxi.
> >
> > >
> > > > +
> > > > +};
> > >
> > > But I'm wondering. If there's nothing here to add, why would we need
> > > that DT in the first place?
> > >
> > I prefer to add often instead of bulk adding, and to show there are some
> > board to add missing things like those above.
>
> Yeah, I get that, but the point really is that you're not really adding
> anything here except an empty device tree.
>
> Maxime
In this case, I keep this patch to send it when I have more to add .
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-09 7:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-24 19:39 [PATCH v2] ARM: dts: sun5i: Add dts for inet86v_rev2 Alexandre GRIVEAUX
2021-01-28 17:23 ` Maxime Ripard
2021-02-01 17:18 ` agriveaux
2021-02-03 9:21 ` Maxime Ripard
2021-02-09 7:26 ` Alexandre GRIVEAUX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).