From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Zi Yan <ziy@nvidia.com>, Davidlohr Bueso <dbueso@suse.de>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
Joao Martins <joao.m.martins@oracle.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] hugetlb: fix update_and_free_page contig page struct assumption
Date: Thu, 18 Feb 2021 14:45:54 +0000 [thread overview]
Message-ID: <20210218144554.GS2858050@casper.infradead.org> (raw)
In-Reply-To: <20210217110252.185c7f5cd5a87c3f7b0c0144@linux-foundation.org>
On Wed, Feb 17, 2021 at 11:02:52AM -0800, Andrew Morton wrote:
> On Wed, 17 Feb 2021 10:49:25 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote:
> > page structs are not guaranteed to be contiguous for gigantic pages. The
>
> June 2014. That's a long lurk time for a bug. I wonder if some later
> commit revealed it.
I would suggest that gigantic pages have not seen much use. Certainly
performance with Intel CPUs on benchmarks that I've been involved with
showed lower performance with 1GB pages than with 2MB pages until quite
recently.
next prev parent reply other threads:[~2021-02-18 17:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 18:49 [PATCH 1/2] hugetlb: fix update_and_free_page contig page struct assumption Mike Kravetz
2021-02-17 18:49 ` [PATCH 2/2] hugetlb: fix copy_huge_page_from_user " Mike Kravetz
2021-02-17 19:02 ` [PATCH 1/2] hugetlb: fix update_and_free_page " Andrew Morton
2021-02-17 19:38 ` Mike Kravetz
2021-02-18 14:45 ` Matthew Wilcox [this message]
2021-02-18 17:25 ` Jason Gunthorpe
2021-02-18 17:27 ` Zi Yan
2021-02-18 17:32 ` Jason Gunthorpe
2021-02-18 17:40 ` Zi Yan
2021-02-18 17:51 ` Mike Kravetz
2021-02-18 18:50 ` Zi Yan
2021-02-18 17:34 ` Mike Kravetz
2021-02-18 21:43 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218144554.GS2858050@casper.infradead.org \
--to=willy@infradead.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dbueso@suse.de \
--cc=joao.m.martins@oracle.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=osalvador@suse.de \
--cc=stable@vger.kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).