* [PATCH V2] Trivial typo fix and sentence construction for better readability
@ 2021-03-19 19:54 Bhaskar Chowdhury
2021-03-19 20:03 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-19 19:54 UTC (permalink / raw)
To: axboe, linux-block, linux-kernel; +Cc: rdunlap, Bhaskar Chowdhury
s/funtion/functions/
Plus the sentence reconstructed for better readability.
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
Changes from V1:
Randy's suggestions incorporated.
block/blk-mq-tag.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index 9c92053e704d..c2bef283db63 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq,
}
/**
- * blk_mq_tagset_wait_completed_request - wait until all completed req's
- * complete funtion is run
+ * blk_mq_tagset_wait_completed_request - wait until all the req's
+ * functions completed their run
* @tagset: Tag set to drain completed request
*
* Note: This function has to be run after all IO queues are shutdown
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2] Trivial typo fix and sentence construction for better readability
2021-03-19 19:54 [PATCH V2] Trivial typo fix and sentence construction for better readability Bhaskar Chowdhury
@ 2021-03-19 20:03 ` Randy Dunlap
2021-03-19 20:07 ` Tom Saeger
2021-03-19 20:07 ` Bhaskar Chowdhury
0 siblings, 2 replies; 6+ messages in thread
From: Randy Dunlap @ 2021-03-19 20:03 UTC (permalink / raw)
To: Bhaskar Chowdhury; +Cc: axboe, linux-block, linux-kernel
Hm, needs some spacing fixes IMO. See below.
On Sat, 20 Mar 2021, Bhaskar Chowdhury wrote:
>
> s/funtion/functions/
>
> Plus the sentence reconstructed for better readability.
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> Changes from V1:
> Randy's suggestions incorporated.
>
> block/blk-mq-tag.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
> index 9c92053e704d..c2bef283db63 100644
> --- a/block/blk-mq-tag.c
> +++ b/block/blk-mq-tag.c
> @@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq,
> }
>
> /**
> - * blk_mq_tagset_wait_completed_request - wait until all completed req's
> - * complete funtion is run
> + * blk_mq_tagset_wait_completed_request - wait until all the req's
the req's
> + * functions completed their run
and more indentation + wording on that line above:
* functions have completed their run
> * @tagset: Tag set to drain completed request
> *
> * Note: This function has to be run after all IO queues are shutdown
> --
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH V2] Trivial typo fix and sentence construction for better readability
2021-03-19 20:03 ` Randy Dunlap
@ 2021-03-19 20:07 ` Tom Saeger
2021-03-19 20:08 ` Randy Dunlap
2021-03-19 20:07 ` Bhaskar Chowdhury
1 sibling, 1 reply; 6+ messages in thread
From: Tom Saeger @ 2021-03-19 20:07 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Bhaskar Chowdhury, axboe, linux-block, linux-kernel
On Fri, Mar 19, 2021 at 01:03:02PM -0700, Randy Dunlap wrote:
>
> Hm, needs some spacing fixes IMO. See below.
>
>
> On Sat, 20 Mar 2021, Bhaskar Chowdhury wrote:
>
> >
> > s/funtion/functions/
> >
> > Plus the sentence reconstructed for better readability.
> >
> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> > ---
> > Changes from V1:
> > Randy's suggestions incorporated.
> >
> > block/blk-mq-tag.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
> > index 9c92053e704d..c2bef283db63 100644
> > --- a/block/blk-mq-tag.c
> > +++ b/block/blk-mq-tag.c
> > @@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq,
> > }
> >
> > /**
> > - * blk_mq_tagset_wait_completed_request - wait until all completed req's
> > - * complete funtion is run
completion function
That's my read of it.
--Tom
> > + * blk_mq_tagset_wait_completed_request - wait until all the req's
>
> the req's
>
> > + * functions completed their run
>
> and more indentation + wording on that line above:
> * functions have completed their run
>
> > * @tagset: Tag set to drain completed request
> > *
> > * Note: This function has to be run after all IO queues are shutdown
> > --
>
> Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] Trivial typo fix and sentence construction for better readability
2021-03-19 20:07 ` Tom Saeger
@ 2021-03-19 20:08 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2021-03-19 20:08 UTC (permalink / raw)
To: Tom Saeger; +Cc: Bhaskar Chowdhury, axboe, linux-block, linux-kernel
On Fri, 19 Mar 2021, Tom Saeger wrote:
> On Fri, Mar 19, 2021 at 01:03:02PM -0700, Randy Dunlap wrote:
>>
>> Hm, needs some spacing fixes IMO. See below.
>>
>>
>> On Sat, 20 Mar 2021, Bhaskar Chowdhury wrote:
>>
>>>
>>> s/funtion/functions/
>>>
>>> Plus the sentence reconstructed for better readability.
>>>
>>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>> ---
>>> Changes from V1:
>>> Randy's suggestions incorporated.
>>>
>>> block/blk-mq-tag.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
>>> index 9c92053e704d..c2bef283db63 100644
>>> --- a/block/blk-mq-tag.c
>>> +++ b/block/blk-mq-tag.c
>>> @@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq,
>>> }
>>>
>>> /**
>>> - * blk_mq_tagset_wait_completed_request - wait until all completed req's
>>> - * complete funtion is run
>
> completion function
>
> That's my read of it.
Sounds good. Thanks.
Bhaskar, please use this wording.
> --Tom
>
>>> + * blk_mq_tagset_wait_completed_request - wait until all the req's
>>
>> the req's
>>
>>> + * functions completed their run
>>
>> and more indentation + wording on that line above:
>> * functions have completed their run
>>
>>> * @tagset: Tag set to drain completed request
>>> *
>>> * Note: This function has to be run after all IO queues are shutdown
>>> --
>>
>> Thanks.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] Trivial typo fix and sentence construction for better readability
2021-03-19 20:03 ` Randy Dunlap
2021-03-19 20:07 ` Tom Saeger
@ 2021-03-19 20:07 ` Bhaskar Chowdhury
2021-03-19 20:26 ` Jens Axboe
1 sibling, 1 reply; 6+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-19 20:07 UTC (permalink / raw)
To: Randy Dunlap; +Cc: axboe, linux-block, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]
On 13:03 Fri 19 Mar 2021, Randy Dunlap wrote:
>
>Hm, needs some spacing fixes IMO. See below.
>
>
>On Sat, 20 Mar 2021, Bhaskar Chowdhury wrote:
>
>>
>> s/funtion/functions/
>>
>> Plus the sentence reconstructed for better readability.
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> Changes from V1:
>> Randy's suggestions incorporated.
>>
>> block/blk-mq-tag.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
>> index 9c92053e704d..c2bef283db63 100644
>> --- a/block/blk-mq-tag.c
>> +++ b/block/blk-mq-tag.c
>> @@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq,
>> }
>>
>> /**
>> - * blk_mq_tagset_wait_completed_request - wait until all completed req's
>> - * complete funtion is run
>> + * blk_mq_tagset_wait_completed_request - wait until all the req's
>
> the req's
>
>> + * functions completed their run
>
>and more indentation + wording on that line above:
> * functions have completed their run
>
Apology...my bad ...fixing ...V3 ...in quick time ...
>> * @tagset: Tag set to drain completed request
>> *
>> * Note: This function has to be run after all IO queues are shutdown
>> --
>
>Thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] Trivial typo fix and sentence construction for better readability
2021-03-19 20:07 ` Bhaskar Chowdhury
@ 2021-03-19 20:26 ` Jens Axboe
0 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2021-03-19 20:26 UTC (permalink / raw)
To: Bhaskar Chowdhury, Randy Dunlap, linux-block, linux-kernel
On 3/19/21 2:07 PM, Bhaskar Chowdhury wrote:
> On 13:03 Fri 19 Mar 2021, Randy Dunlap wrote:
>>
>> Hm, needs some spacing fixes IMO. See below.
>>
>>
>> On Sat, 20 Mar 2021, Bhaskar Chowdhury wrote:
>>
>>>
>>> s/funtion/functions/
>>>
>>> Plus the sentence reconstructed for better readability.
>>>
>>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>> ---
>>> Changes from V1:
>>> Randy's suggestions incorporated.
>>>
>>> block/blk-mq-tag.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
>>> index 9c92053e704d..c2bef283db63 100644
>>> --- a/block/blk-mq-tag.c
>>> +++ b/block/blk-mq-tag.c
>>> @@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq,
>>> }
>>>
>>> /**
>>> - * blk_mq_tagset_wait_completed_request - wait until all completed req's
>>> - * complete funtion is run
>>> + * blk_mq_tagset_wait_completed_request - wait until all the req's
>>
>> the req's
>>
>>> + * functions completed their run
>>
>> and more indentation + wording on that line above:
>> * functions have completed their run
>>
> Apology...my bad ...fixing ...V3 ...in quick time ...
Easy, let's get this right instead of spinning tons of versions of a
trivial patch. The text should be:
Wait until all scheduled request completions have finished.
If we're fixing a typo, let's actually make it understandable too...
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-19 20:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-19 19:54 [PATCH V2] Trivial typo fix and sentence construction for better readability Bhaskar Chowdhury
2021-03-19 20:03 ` Randy Dunlap
2021-03-19 20:07 ` Tom Saeger
2021-03-19 20:08 ` Randy Dunlap
2021-03-19 20:07 ` Bhaskar Chowdhury
2021-03-19 20:26 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).