[PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel

[PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel

[Stefan Riedmueller]

The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG.
Add the corresponding connector type and 8 bpc as default bus_format.

Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 4e2dad314c79..44583d0ed902 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = {
 		.width = 211,
 		.height = 158,
 	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
 static const struct drm_display_mode auo_g121ean01_mode = {
-- 
2.25.1

[PATCH 2/3] drm/panel: Add connector_type for some EDT displays

[Stefan Riedmueller]

The connector_type for following two EDT displays is missing:
 - EDT ETM0430G0DH6
 - EDT ETM0700G0BDH6

Both are parallel displays thus add the corresponding connector_type.

Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 44583d0ed902..723c09a82c4c 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1900,6 +1900,7 @@ static const struct panel_desc edt_etm0430g0dh6 = {
 		.width = 95,
 		.height = 54,
 	},
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
 };
 
 static const struct drm_display_mode edt_et057090dhu_mode = {
@@ -1964,6 +1965,7 @@ static const struct panel_desc edt_etm0700g0bdh6 = {
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
 	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
 };
 
 static const struct display_timing evervision_vgg804821_timing = {
-- 
2.25.1

[PATCH 3/3] drm/panel: Add bus_format and bus_flags for EDT ETM0430G0DH6

[Stefan Riedmueller]

Add corresponding bus_format and bus_flags for the EDT ETM0430G0DH6
display.

Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 723c09a82c4c..1bbb205a3b81 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1900,6 +1900,8 @@ static const struct panel_desc edt_etm0430g0dh6 = {
 		.width = 95,
 		.height = 54,
 	},
+	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE,
 	.connector_type = DRM_MODE_CONNECTOR_DPI,
 };
 
-- 
2.25.1

Re: [PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel

[Stefan Riedmüller]

Hi,

gentle ping for this small series.

Regards,
Stefan

On Thu, 2021-04-15 at 11:16 +0200, Stefan Riedmueller wrote:
> The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG.
> Add the corresponding connector type and 8 bpc as default bus_format.
> 
> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c
> index 4e2dad314c79..44583d0ed902 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = {
>  		.width = 211,
>  		.height = 158,
>  	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>  };
>  
>  static const struct drm_display_mode auo_g121ean01_mode = {

Re: [PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel

[Stefan Riedmüller]

Hi,

another gentle ping.

Also adding Laurent Pinchart to CC.

Regards,
Stefan

On Wed, 2021-05-26 at 07:34 +0000, Stefan Riedmüller wrote:
> Hi,
> 
> gentle ping for this small series.
> 
> Regards,
> Stefan
> 
> On Thu, 2021-04-15 at 11:16 +0200, Stefan Riedmueller wrote:
> > The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG.
> > Add the corresponding connector type and 8 bpc as default bus_format.
> > 
> > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > b/drivers/gpu/drm/panel/panel-simple.c
> > index 4e2dad314c79..44583d0ed902 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = {
> >  		.width = 211,
> >  		.height = 158,
> >  	},
> > +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> > +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
> >  };
> >  
> >  static const struct drm_display_mode auo_g121ean01_mode = {

Re: [PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel

[Laurent Pinchart]

Hi Stefan,

Thank you for the patch.

On Mon, Jun 21, 2021 at 08:22:10AM +0000, Stefan Riedmüller wrote:
> Hi,
> 
> another gentle ping.

Sorry for the delay, I have way too little bandwidth these days :-S

> Also adding Laurent Pinchart to CC.
>
> On Wed, 2021-05-26 at 07:34 +0000, Stefan Riedmüller wrote:
> > On Thu, 2021-04-15 at 11:16 +0200, Stefan Riedmueller wrote:
> > > The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG.
> > > Add the corresponding connector type and 8 bpc as default bus_format.
> > > 
> > > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

It will be interesting to add support for the 6bpp mode at some point (I
assume through a custom DT property that reports the state of the
panel's SEL68 pin, as it should be strapped in most cases).

> > > ---
> > >  drivers/gpu/drm/panel/panel-simple.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > > b/drivers/gpu/drm/panel/panel-simple.c
> > > index 4e2dad314c79..44583d0ed902 100644
> > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > @@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = {
> > >  		.width = 211,
> > >  		.height = 158,
> > >  	},
> > > +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> > > +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
> > >  };
> > >  
> > >  static const struct drm_display_mode auo_g121ean01_mode = {

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel

[Stefan Riedmüller]

Hi Sam,

On Mon, 2021-06-21 at 16:17 +0200, Sam Ravnborg wrote:
> Hi Stefan,
> 
> On Mon, Jun 21, 2021 at 08:22:10AM +0000, Stefan Riedmüller wrote:
> > Hi,
> > 
> > another gentle ping.
> > 
> > Also adding Laurent Pinchart to CC.
> 
> Can I ask you to resend the whole lot. I have resurfaced after an
> off-line period and deleted all pending mails.
> 
> I could probarly hunt down the mails somewhere but resend is easier on
> my end.

Sure, no problem, I'll send it out ASAP.

Stefan

> 
> 	Sam