[PATCH] tools/bootconfig: Simplify expression

[PATCH] tools/bootconfig: Simplify expression

[zuoqilin1]

From: zuoqilin <zuoqilin@yulong.com>

It is not necessary to define the variable ret to receive
the return value of the xbc_node_compose_key() method.

Signed-off-by: zuoqilin <zuoqilin@yulong.com>
---
 tools/bootconfig/main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/bootconfig/main.c b/tools/bootconfig/main.c
index 7362bef..5fb309b 100644
--- a/tools/bootconfig/main.c
+++ b/tools/bootconfig/main.c
@@ -84,11 +84,9 @@ static void xbc_show_list(void)
 	char key[XBC_KEYLEN_MAX];
 	struct xbc_node *leaf;
 	const char *val;
-	int ret = 0;
 
 	xbc_for_each_key_value(leaf, val) {
-		ret = xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX);
-		if (ret < 0)
+		if (xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX) < 0)
 			break;
 		printf("%s = ", key);
 		if (!val || val[0] == '\0') {
-- 
1.9.1

Re: [PATCH] tools/bootconfig: Simplify expression

[Masami Hiramatsu]

On Wed, 14 Apr 2021 21:46:47 +0800
zuoqilin1@163.com wrote:

> From: zuoqilin <zuoqilin@yulong.com>
> 
> It is not necessary to define the variable ret to receive
> the return value of the xbc_node_compose_key() method.
> 
> Signed-off-by: zuoqilin <zuoqilin@yulong.com>

Indeed.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you!

> ---
>  tools/bootconfig/main.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tools/bootconfig/main.c b/tools/bootconfig/main.c
> index 7362bef..5fb309b 100644
> --- a/tools/bootconfig/main.c
> +++ b/tools/bootconfig/main.c
> @@ -84,11 +84,9 @@ static void xbc_show_list(void)
>  	char key[XBC_KEYLEN_MAX];
>  	struct xbc_node *leaf;
>  	const char *val;
> -	int ret = 0;
>  
>  	xbc_for_each_key_value(leaf, val) {
> -		ret = xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX);
> -		if (ret < 0)
> +		if (xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX) < 0)
>  			break;
>  		printf("%s = ", key);
>  		if (!val || val[0] == '\0') {
> -- 
> 1.9.1
> 
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>