From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Clemens Gruber <clemens.gruber@pqgruber.com>
Cc: linux-pwm@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Sven Van Asbroeck <TheSven73@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/8] pwm: pca9685: Switch to atomic API
Date: Sat, 17 Apr 2021 17:37:28 +0200 [thread overview]
Message-ID: <20210417153728.eohhphmtm6qf26y4@pengutronix.de> (raw)
In-Reply-To: <20210412132745.76609-1-clemens.gruber@pqgruber.com>
[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]
On Mon, Apr 12, 2021 at 03:27:38PM +0200, Clemens Gruber wrote:
> The switch to the atomic API goes hand in hand with a few fixes to
> previously experienced issues:
> - The duty cycle is no longer lost after disable/enable (previously the
> OFF registers were cleared in disable and the user was required to
> call config to restore the duty cycle settings)
> - If one sets a period resulting in the same prescale register value,
> the sleep and write to the register is now skipped
> - Previously, only the full ON bit was toggled in GPIO mode (and full
> OFF cleared if set to high), which could result in both full OFF and
> full ON not being set and on=0, off=0, which is not allowed according
> to the datasheet
> - The OFF registers were reset to 0 in probe, which could lead to the
> forbidden on=0, off=0. Fixed by resetting to POR default (full OFF)
I didn't recheck all details, but the patch is definitively an
improvement, so:
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-04-17 15:37 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 13:27 [PATCH v8 1/8] pwm: pca9685: Switch to atomic API Clemens Gruber
2021-04-12 13:27 ` [PATCH v8 2/8] pwm: pca9685: Support hardware readout Clemens Gruber
2021-04-12 16:21 ` Uwe Kleine-König
2021-04-12 13:27 ` [PATCH v8 3/8] pwm: pca9685: Improve runtime PM behavior Clemens Gruber
2021-04-12 13:27 ` [PATCH v8 4/8] dt-bindings: pwm: Support new PWM_USAGE_POWER flag Clemens Gruber
2021-04-12 16:27 ` Uwe Kleine-König
2021-04-12 16:46 ` Clemens Gruber
2021-04-13 11:38 ` Uwe Kleine-König
2021-04-13 11:41 ` Thierry Reding
2021-04-13 11:51 ` Thierry Reding
2021-04-13 17:56 ` Uwe Kleine-König
2021-04-15 16:27 ` Thierry Reding
2021-04-16 9:32 ` Uwe Kleine-König
2021-04-16 10:45 ` Thierry Reding
2021-04-18 13:30 ` Uwe Kleine-König
2021-04-16 13:55 ` Thierry Reding
2021-04-16 15:39 ` Rob Herring
2021-04-16 15:54 ` Clemens Gruber
2021-04-17 15:44 ` Uwe Kleine-König
2021-04-12 13:27 ` [PATCH v8 5/8] pwm: core: " Clemens Gruber
2021-04-12 13:27 ` [PATCH v8 6/8] pwm: pca9685: " Clemens Gruber
2021-04-12 16:30 ` Uwe Kleine-König
2021-04-12 17:11 ` Clemens Gruber
2021-04-13 10:34 ` Uwe Kleine-König
2021-04-12 13:27 ` [PATCH v8 7/8] pwm: pca9685: Restrict period change for enabled PWMs Clemens Gruber
2021-04-17 15:46 ` Uwe Kleine-König
2021-04-12 13:27 ` [PATCH v8 8/8] pwm: pca9685: Add error messages for failed regmap calls Clemens Gruber
2021-04-17 15:47 ` Uwe Kleine-König
2021-04-12 16:18 ` [PATCH v8 1/8] pwm: pca9685: Switch to atomic API Uwe Kleine-König
2021-04-12 16:39 ` Clemens Gruber
2021-04-12 20:10 ` Uwe Kleine-König
2021-04-13 12:11 ` Clemens Gruber
2021-04-13 12:17 ` Clemens Gruber
2021-04-13 12:37 ` Thierry Reding
2021-04-13 13:06 ` Clemens Gruber
2021-04-13 19:38 ` Uwe Kleine-König
2021-04-14 12:09 ` Clemens Gruber
2021-04-14 19:21 ` Uwe Kleine-König
2021-04-14 19:45 ` Clemens Gruber
2021-04-15 6:48 ` Uwe Kleine-König
2021-04-17 15:37 ` Uwe Kleine-König [this message]
2021-04-17 16:40 ` Clemens Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210417153728.eohhphmtm6qf26y4@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=TheSven73@gmail.com \
--cc=clemens.gruber@pqgruber.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).