From: Feng Tang <email@example.com> To: Dave Hansen <firstname.lastname@example.org> Cc: Mel Gorman <email@example.com>, Andrew Morton <firstname.lastname@example.org>, Hillf Danton <email@example.com>, Dave Hansen <firstname.lastname@example.org>, Vlastimil Babka <email@example.com>, Michal Hocko <firstname.lastname@example.org>, LKML <email@example.com>, Linux-MM <firstname.lastname@example.org> Subject: Re: [PATCH 0/6 v2] Calculate pcp->high based on zone sizes and active CPUs Date: Mon, 31 May 2021 20:00:15 +0800 [thread overview] Message-ID: <20210531120015.GA89301@shbuild999.sh.intel.com> (raw) In-Reply-To: <email@example.com> On Fri, May 28, 2021 at 09:17:41AM -0700, Dave Hansen wrote: > On 5/28/21 8:18 AM, Mel Gorman wrote: > >> BTW, to do some of this testing, Feng was doing a plain old kernel > >> build. On the one system where this got run, he noted a ~2% regression > >> in build times. Nothing major, but you might want to be on the lookout > >> in case 0day or the other test harnesses find something similar once > >> this series gets to them. > >> > > What type of system was it? > > > > I noticed minor differences for some thread counts on kernel compilations > > but for CascadeLake at least, it was mostly neutral. Below is an old test > > result based on a previous revision. > > It's a Cascade Lake as well. But, I never trust hardware at a hardware > company. These could be preproduction CPUs or BIOS or both, or have > some bonkers configuration knob flipped. > > It's also got a bunch of PMEM plugged and onlined, including the > _possibility_ of kernel data structures ended up on PMEM. They *mostly* > don't end up there, but it does happen on occasion. > > Anyway, I'll see if we can do some more runs with your latest version. > It looks like it's been picked up for -mm so 0day should be pounding on > it soon enough. Yes, usually 0day has more benchmark test covering -mm tree. As for the kbuild test run for v2, after more runs, the previous 2% longer kbuild time turns to 1% shorter time, seems to be in normal deviation range. Also I checked Mel's v3 branch which has the fix for cpuless node, the pcp 'high' looks normal on PMEM node: pagesets cpu: 0 count: 67 high: 724 batch: 63 vm stats threshold: 125 Thanks, Feng
prev parent reply other threads:[~2021-05-31 12:00 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-25 8:01 Mel Gorman 2021-05-25 8:01 ` [PATCH 1/6] mm/page_alloc: Delete vm.percpu_pagelist_fraction Mel Gorman 2021-05-26 17:41 ` Vlastimil Babka 2021-05-25 8:01 ` [PATCH 2/6] mm/page_alloc: Disassociate the pcp->high from pcp->batch Mel Gorman 2021-05-26 18:14 ` Vlastimil Babka 2021-05-27 10:52 ` Mel Gorman 2021-05-28 10:27 ` Vlastimil Babka 2021-05-25 8:01 ` [PATCH 3/6] mm/page_alloc: Adjust pcp->high after CPU hotplug events Mel Gorman 2021-05-28 11:08 ` Vlastimil Babka 2021-05-25 8:01 ` [PATCH 4/6] mm/page_alloc: Scale the number of pages that are batch freed Mel Gorman 2021-05-28 11:19 ` Vlastimil Babka 2021-05-25 8:01 ` [PATCH 5/6] mm/page_alloc: Limit the number of pages on PCP lists when reclaim is active Mel Gorman 2021-05-28 11:43 ` Vlastimil Babka 2021-05-25 8:01 ` [PATCH 6/6] mm/page_alloc: Introduce vm.percpu_pagelist_high_fraction Mel Gorman 2021-05-28 11:59 ` Vlastimil Babka 2021-05-28 12:53 ` Mel Gorman 2021-05-28 14:38 ` Vlastimil Babka 2021-05-27 19:36 ` [PATCH 0/6 v2] Calculate pcp->high based on zone sizes and active CPUs Dave Hansen 2021-05-28 8:55 ` Mel Gorman 2021-05-28 9:03 ` David Hildenbrand 2021-05-28 9:08 ` David Hildenbrand 2021-05-28 9:49 ` Mel Gorman 2021-05-28 9:52 ` David Hildenbrand 2021-05-28 10:09 ` Mel Gorman 2021-05-28 10:21 ` David Hildenbrand 2021-05-28 12:12 ` Vlastimil Babka 2021-05-28 12:37 ` Mel Gorman 2021-05-28 14:39 ` Dave Hansen 2021-05-28 15:18 ` Mel Gorman 2021-05-28 16:17 ` Dave Hansen 2021-05-31 12:00 ` Feng Tang [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210531120015.GA89301@shbuild999.sh.intel.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 0/6 v2] Calculate pcp->high based on zone sizes and active CPUs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).