* [PATCH 1/1] clk: Export clk_register_composite
@ 2020-07-23 8:32 Wendell Lin
2020-08-10 9:36 ` Wendell Lin
0 siblings, 1 reply; 5+ messages in thread
From: Wendell Lin @ 2020-07-23 8:32 UTC (permalink / raw)
To: Matthias Brugger, Michael Turquette, Stephen Boyd
Cc: linux-clk, linux-kernel, linux-mediatek, linux-arm-kernel,
devicetree, wsd_upstream, Wendell Lin
clk_register_composite() will be used in mediatek's
clock kernel module, so export it to GPL modules.
Signed-off-by: Wendell Lin <wendell.lin@mediatek.com>
---
drivers/clk/clk-composite.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c
index 7376f57..7c609c2 100644
--- a/drivers/clk/clk-composite.c
+++ b/drivers/clk/clk-composite.c
@@ -360,6 +360,7 @@ struct clk *clk_register_composite(struct device *dev, const char *name,
return ERR_CAST(hw);
return hw->clk;
}
+EXPORT_SYMBOL_GPL(clk_register_composite);
struct clk *clk_register_composite_pdata(struct device *dev, const char *name,
const struct clk_parent_data *parent_data,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] clk: Export clk_register_composite
2020-07-23 8:32 [PATCH 1/1] clk: Export clk_register_composite Wendell Lin
@ 2020-08-10 9:36 ` Wendell Lin
[not found] ` <CAF2Aj3hZB08d8x6XOqsP4m5fv76fWH48U95j8ugLt-YWFJ-kkA@mail.gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: Wendell Lin @ 2020-08-10 9:36 UTC (permalink / raw)
To: Matthias Brugger
Cc: Michael Turquette, Stephen Boyd, linux-clk, linux-kernel,
linux-mediatek, linux-arm-kernel, devicetree, wsd_upstream
Hi Matthias and all,
Gentle ping on this patch.
Thanks
Wendell Lin
On Thu, 2020-07-23 at 16:32 +0800, Wendell Lin wrote:
> clk_register_composite() will be used in mediatek's
> clock kernel module, so export it to GPL modules.
>
> Signed-off-by: Wendell Lin <wendell.lin@mediatek.com>
> ---
> drivers/clk/clk-composite.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c
> index 7376f57..7c609c2 100644
> --- a/drivers/clk/clk-composite.c
> +++ b/drivers/clk/clk-composite.c
> @@ -360,6 +360,7 @@ struct clk *clk_register_composite(struct device *dev, const char *name,
> return ERR_CAST(hw);
> return hw->clk;
> }
> +EXPORT_SYMBOL_GPL(clk_register_composite);
>
> struct clk *clk_register_composite_pdata(struct device *dev, const char *name,
> const struct clk_parent_data *parent_data,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] clk: Export clk_register_composite
[not found] ` <20210604082524.GF2435141@dell>
@ 2021-06-04 10:22 ` Wendell Lin
2021-06-04 13:23 ` Lee Jones
0 siblings, 1 reply; 5+ messages in thread
From: Wendell Lin @ 2021-06-04 10:22 UTC (permalink / raw)
To: Lee Jones
Cc: Stephen Boyd, Matthias Brugger, Michael Turquette, linux-clk,
open list, ARM/Mediatek SoC support, linux-arm-kernel,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
wsd_upstream
On Fri, 2021-06-04 at 09:25 +0100, Lee Jones wrote:
> On Fri, 04 Jun 2021, Lee Jones wrote:
>
> > On Thu, 03 Jun 2021, Stephen Boyd wrote:
> >
> > > Quoting Lee Jones (2021-05-20 09:07:42)
> > > > On Mon, 10 Aug 2020 at 10:36, Wendell Lin <wendell.lin@mediatek.com> wrote:
> > > >
> > > > Hi Matthias and all,
> > > >
> > > > Gentle ping on this patch.
> > > >
> > > >
> > > > What about a not-so-gentle ping on this patch? Grrrr... :)
> > > >
> > > > FYI, this is still required by more than one source.
> > > >
> > > > Please help get this out of all of the vendor trees please.
> > > >
> > >
> > > Is there an in-kernel user?
> >
> > How can there be? It's not exported yet. :)
> >
> > However there shouldn't be any barriers for vendors represented in
> > Mainline to build their drivers as modules if they so wish. If/when
> > they do, this will need to be exported.
>
> Wendell Lin, is this what you wish to do with the in-kernel MediaTek
> driver?
>
This is because Mediatek clock driver would be built as kernel module,
so clk_register_composite() used should be exported, then we could use
it.
Please refer:
[PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support
https://lkml.org/lkml/2020/7/1/124
+EXPORT_SYMBOL(mtk_clk_register_composites);
clk_register_composite() is used by Mediatek clk kernel module.
From export symbol: mtk_clk_register_composites.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] clk: Export clk_register_composite
2021-06-04 10:22 ` Wendell Lin
@ 2021-06-04 13:23 ` Lee Jones
2021-06-04 19:19 ` Stephen Boyd
0 siblings, 1 reply; 5+ messages in thread
From: Lee Jones @ 2021-06-04 13:23 UTC (permalink / raw)
To: Wendell Lin
Cc: Stephen Boyd, Matthias Brugger, Michael Turquette, linux-clk,
open list, ARM/Mediatek SoC support, linux-arm-kernel,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
wsd_upstream
On Fri, 04 Jun 2021, Wendell Lin wrote:
> On Fri, 2021-06-04 at 09:25 +0100, Lee Jones wrote:
> > On Fri, 04 Jun 2021, Lee Jones wrote:
> >
> > > On Thu, 03 Jun 2021, Stephen Boyd wrote:
> > >
> > > > Quoting Lee Jones (2021-05-20 09:07:42)
> > > > > On Mon, 10 Aug 2020 at 10:36, Wendell Lin <wendell.lin@mediatek.com> wrote:
> > > > >
> > > > > Hi Matthias and all,
> > > > >
> > > > > Gentle ping on this patch.
> > > > >
> > > > >
> > > > > What about a not-so-gentle ping on this patch? Grrrr... :)
> > > > >
> > > > > FYI, this is still required by more than one source.
> > > > >
> > > > > Please help get this out of all of the vendor trees please.
> > > > >
> > > >
> > > > Is there an in-kernel user?
> > >
> > > How can there be? It's not exported yet. :)
> > >
> > > However there shouldn't be any barriers for vendors represented in
> > > Mainline to build their drivers as modules if they so wish. If/when
> > > they do, this will need to be exported.
> >
> > Wendell Lin, is this what you wish to do with the in-kernel MediaTek
> > driver?
> >
> This is because Mediatek clock driver would be built as kernel module,
> so clk_register_composite() used should be exported, then we could use
> it.
>
> Please refer:
> [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support
> https://lkml.org/lkml/2020/7/1/124
> +EXPORT_SYMBOL(mtk_clk_register_composites);
>
> clk_register_composite() is used by Mediatek clk kernel module.
> From export symbol: mtk_clk_register_composites.
Perfect. Thanks for the clarification.
Anything else you need from us Stephen?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] clk: Export clk_register_composite
2021-06-04 13:23 ` Lee Jones
@ 2021-06-04 19:19 ` Stephen Boyd
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2021-06-04 19:19 UTC (permalink / raw)
To: Lee Jones, Wendell Lin
Cc: Matthias Brugger, Michael Turquette, linux-clk, open list,
ARM/Mediatek SoC support, linux-arm-kernel,
OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, wsd_upstream,
Quoting Lee Jones (2021-06-04 06:23:35)
> On Fri, 04 Jun 2021, Wendell Lin wrote:
>
> > On Fri, 2021-06-04 at 09:25 +0100, Lee Jones wrote:
> > > On Fri, 04 Jun 2021, Lee Jones wrote:
> > >
> > > > On Thu, 03 Jun 2021, Stephen Boyd wrote:
> > > >
> > > > > Quoting Lee Jones (2021-05-20 09:07:42)
> > > > > > On Mon, 10 Aug 2020 at 10:36, Wendell Lin <wendell.lin@mediatek.com> wrote:
> > > > > >
> > > > > > Hi Matthias and all,
> > > > > >
> > > > > > Gentle ping on this patch.
> > > > > >
> > > > > >
> > > > > > What about a not-so-gentle ping on this patch? Grrrr... :)
> > > > > >
> > > > > > FYI, this is still required by more than one source.
> > > > > >
> > > > > > Please help get this out of all of the vendor trees please.
> > > > > >
> > > > >
> > > > > Is there an in-kernel user?
> > > >
> > > > How can there be? It's not exported yet. :)
> > > >
> > > > However there shouldn't be any barriers for vendors represented in
> > > > Mainline to build their drivers as modules if they so wish. If/when
> > > > they do, this will need to be exported.
> > >
> > > Wendell Lin, is this what you wish to do with the in-kernel MediaTek
> > > driver?
> > >
> > This is because Mediatek clock driver would be built as kernel module,
> > so clk_register_composite() used should be exported, then we could use
> > it.
> >
> > Please refer:
> > [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support
> > https://lkml.org/lkml/2020/7/1/124
> > +EXPORT_SYMBOL(mtk_clk_register_composites);
> >
> > clk_register_composite() is used by Mediatek clk kernel module.
> > From export symbol: mtk_clk_register_composites.
>
> Perfect. Thanks for the clarification.
>
> Anything else you need from us Stephen?
>
Is the mediatek driver compilable as a module? Last time I checked it
wasn't a module. I want an upstream modular driver that uses the symbol.
Otherwise we're exporting symbols when it doesn't need to be.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-04 19:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 8:32 [PATCH 1/1] clk: Export clk_register_composite Wendell Lin
2020-08-10 9:36 ` Wendell Lin
[not found] ` <CAF2Aj3hZB08d8x6XOqsP4m5fv76fWH48U95j8ugLt-YWFJ-kkA@mail.gmail.com>
[not found] ` <162276982204.1835121.10976600065855289763@swboyd.mtv.corp.google.com>
[not found] ` <20210604082427.GE2435141@dell>
[not found] ` <20210604082524.GF2435141@dell>
2021-06-04 10:22 ` Wendell Lin
2021-06-04 13:23 ` Lee Jones
2021-06-04 19:19 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).