[PATCH v1 1/1] pinctrl: microchip-sgpio: Put fwnode in error case during ->probe()

[PATCH v1 1/1] pinctrl: microchip-sgpio: Put fwnode in error case during ->probe()

[Andy Shevchenko]

device_for_each_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.

Fixes: 7e5ea974e61c ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO")
Cc: Lars Povlsen <lars.povlsen@microchip.com>
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
 drivers/pinctrl/pinctrl-microchip-sgpio.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c
index c12fa57ebd12..165cb7a59715 100644
--- a/drivers/pinctrl/pinctrl-microchip-sgpio.c
+++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c
@@ -845,8 +845,10 @@ static int microchip_sgpio_probe(struct platform_device *pdev)
 	i = 0;
 	device_for_each_child_node(dev, fwnode) {
 		ret = microchip_sgpio_register_bank(dev, priv, fwnode, i++);
-		if (ret)
+		if (ret) {
+			fwnode_handle_put(fwnode);
 			return ret;
+		}
 	}
 
 	if (priv->in.gpio.ngpio != priv->out.gpio.ngpio) {
-- 
2.31.1

Re: [PATCH v1 1/1] pinctrl: microchip-sgpio: Put fwnode in error case during ->probe()

[andy]

Sun, Jun 06, 2021 at 10:19:40PM +0300, Andy Shevchenko kirjoitti:
> device_for_each_child_node() bumps a reference counting of a returned variable.
> We have to balance it whenever we return to the caller.

Linus, any comments on this? Can it be applied sooner than later since
it's a fix?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] pinctrl: microchip-sgpio: Put fwnode in error case during ->probe()

[Linus Walleij]

On Sun, Jun 6, 2021 at 9:21 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:

> device_for_each_child_node() bumps a reference counting of a returned variable.
> We have to balance it whenever we return to the caller.
>
> Fixes: 7e5ea974e61c ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO")
> Cc: Lars Povlsen <lars.povlsen@microchip.com>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Patch applied for fixes, I got a bit snowed under because of
patch-spot activity.

Yours,
Linus Walleij