linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 1/1] pinctrl: microchip-sgpio: Put fwnode in error case during ->probe()
@ 2021-06-06 19:19 Andy Shevchenko
  2021-06-17  7:31 ` andy
  2021-06-18  9:19 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-06-06 19:19 UTC (permalink / raw)
  To: Linus Walleij, Lars Povlsen, linux-arm-kernel, linux-gpio, linux-kernel
  Cc: Steen Hegelund, UNGLinuxDriver, Andy Shevchenko

device_for_each_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.

Fixes: 7e5ea974e61c ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO")
Cc: Lars Povlsen <lars.povlsen@microchip.com>
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
 drivers/pinctrl/pinctrl-microchip-sgpio.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c
index c12fa57ebd12..165cb7a59715 100644
--- a/drivers/pinctrl/pinctrl-microchip-sgpio.c
+++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c
@@ -845,8 +845,10 @@ static int microchip_sgpio_probe(struct platform_device *pdev)
 	i = 0;
 	device_for_each_child_node(dev, fwnode) {
 		ret = microchip_sgpio_register_bank(dev, priv, fwnode, i++);
-		if (ret)
+		if (ret) {
+			fwnode_handle_put(fwnode);
 			return ret;
+		}
 	}
 
 	if (priv->in.gpio.ngpio != priv->out.gpio.ngpio) {
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] pinctrl: microchip-sgpio: Put fwnode in error case during ->probe()
  2021-06-06 19:19 [PATCH v1 1/1] pinctrl: microchip-sgpio: Put fwnode in error case during ->probe() Andy Shevchenko
@ 2021-06-17  7:31 ` andy
  2021-06-18  9:19 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: andy @ 2021-06-17  7:31 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Linus Walleij, Lars Povlsen, linux-arm-kernel, linux-gpio,
	linux-kernel, Steen Hegelund, UNGLinuxDriver

Sun, Jun 06, 2021 at 10:19:40PM +0300, Andy Shevchenko kirjoitti:
> device_for_each_child_node() bumps a reference counting of a returned variable.
> We have to balance it whenever we return to the caller.

Linus, any comments on this? Can it be applied sooner than later since
it's a fix?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] pinctrl: microchip-sgpio: Put fwnode in error case during ->probe()
  2021-06-06 19:19 [PATCH v1 1/1] pinctrl: microchip-sgpio: Put fwnode in error case during ->probe() Andy Shevchenko
  2021-06-17  7:31 ` andy
@ 2021-06-18  9:19 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-06-18  9:19 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Lars Povlsen, Linux ARM, open list:GPIO SUBSYSTEM, linux-kernel,
	Steen Hegelund, Microchip Linux Driver Support

On Sun, Jun 6, 2021 at 9:21 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:

> device_for_each_child_node() bumps a reference counting of a returned variable.
> We have to balance it whenever we return to the caller.
>
> Fixes: 7e5ea974e61c ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO")
> Cc: Lars Povlsen <lars.povlsen@microchip.com>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Patch applied for fixes, I got a bit snowed under because of
patch-spot activity.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-18  9:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-06 19:19 [PATCH v1 1/1] pinctrl: microchip-sgpio: Put fwnode in error case during ->probe() Andy Shevchenko
2021-06-17  7:31 ` andy
2021-06-18  9:19 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).