* [PATCH] media: Kconfig: Fix DVB_CORE can't be selected as module
@ 2021-06-08 10:14 Lecopzer Chen
2021-06-18 16:23 ` Sean Young
0 siblings, 1 reply; 3+ messages in thread
From: Lecopzer Chen @ 2021-06-08 10:14 UTC (permalink / raw)
To: mchehab; +Cc: linux-media, linux-kernel, yj.chiang, Lecopzer Chen
The DVB_CORE now depends on MEDIA_DIGITAL_TV_SUPPORT and
default MEDIA_DIGITAL_TV_SUPPORT, and this makes it can never be =m
since the type of MEDIA_DIGITAL_TV_SUPPORT is bool.
Change MEDIA_DIGITAL_TV_SUPPORT to tristate so it's possible to set
DVB_CORE as =m.
Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
---
drivers/media/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index b07812657cee..c3baf92b4d02 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -88,7 +88,7 @@ config MEDIA_ANALOG_TV_SUPPORT
will disable support for them.
config MEDIA_DIGITAL_TV_SUPPORT
- bool
+ tristate
prompt "Digital TV" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: Kconfig: Fix DVB_CORE can't be selected as module
2021-06-08 10:14 [PATCH] media: Kconfig: Fix DVB_CORE can't be selected as module Lecopzer Chen
@ 2021-06-18 16:23 ` Sean Young
2021-06-19 7:28 ` Lecopzer Chen
0 siblings, 1 reply; 3+ messages in thread
From: Sean Young @ 2021-06-18 16:23 UTC (permalink / raw)
To: Lecopzer Chen; +Cc: mchehab, linux-media, linux-kernel, yj.chiang
On Tue, Jun 08, 2021 at 06:14:51PM +0800, Lecopzer Chen wrote:
> The DVB_CORE now depends on MEDIA_DIGITAL_TV_SUPPORT and
> default MEDIA_DIGITAL_TV_SUPPORT, and this makes it can never be =m
> since the type of MEDIA_DIGITAL_TV_SUPPORT is bool.
First of all, the distributions carrry dvb_core as a module, so clearly
it possible to set DVB_CORE=m.
As far as I can see, if MEDIA_SUPPORT=m, then DVB_CORE=m.
So it is possible.
Sean
> Change MEDIA_DIGITAL_TV_SUPPORT to tristate so it's possible to set
> DVB_CORE as =m.
>
> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> ---
> drivers/media/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index b07812657cee..c3baf92b4d02 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -88,7 +88,7 @@ config MEDIA_ANALOG_TV_SUPPORT
> will disable support for them.
>
> config MEDIA_DIGITAL_TV_SUPPORT
> - bool
> + tristate
> prompt "Digital TV" if MEDIA_SUPPORT_FILTER
> default y if !MEDIA_SUPPORT_FILTER
> help
> --
> 2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: Kconfig: Fix DVB_CORE can't be selected as module
2021-06-18 16:23 ` Sean Young
@ 2021-06-19 7:28 ` Lecopzer Chen
0 siblings, 0 replies; 3+ messages in thread
From: Lecopzer Chen @ 2021-06-19 7:28 UTC (permalink / raw)
To: sean; +Cc: lecopzer.chen, linux-kernel, linux-media, mchehab, yj.chiang
> On Tue, Jun 08, 2021 at 06:14:51PM +0800, Lecopzer Chen wrote:
> > The DVB_CORE now depends on MEDIA_DIGITAL_TV_SUPPORT and
> > default MEDIA_DIGITAL_TV_SUPPORT, and this makes it can never be =m
> > since the type of MEDIA_DIGITAL_TV_SUPPORT is bool.
>
> First of all, the distributions carrry dvb_core as a module, so clearly
> it possible to set DVB_CORE=m.
>
> As far as I can see, if MEDIA_SUPPORT=m, then DVB_CORE=m.
>
> So it is possible.
Thanks for review.
After checking, It does change DVB_CORE=m if MEDIA_SUPPORT=m.
We had MEDIA_SUPPORT=y, thus misunderstood by 'default MEDIA_DIGITAL_TV_SUPPORT'.
Thanks again for figuring out this.
-Lecopzer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-19 7:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 10:14 [PATCH] media: Kconfig: Fix DVB_CORE can't be selected as module Lecopzer Chen
2021-06-18 16:23 ` Sean Young
2021-06-19 7:28 ` Lecopzer Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).