[PATCH] media: Kconfig: Fix DVB_CORE can't be selected as module

[PATCH] media: Kconfig: Fix DVB_CORE can't be selected as module

[Lecopzer Chen]

The DVB_CORE now depends on MEDIA_DIGITAL_TV_SUPPORT and
default MEDIA_DIGITAL_TV_SUPPORT, and this makes it can never be =m
since the type of MEDIA_DIGITAL_TV_SUPPORT is bool.

Change MEDIA_DIGITAL_TV_SUPPORT to tristate so it's possible to set
DVB_CORE as =m.

Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
---
 drivers/media/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index b07812657cee..c3baf92b4d02 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -88,7 +88,7 @@ config MEDIA_ANALOG_TV_SUPPORT
 		will disable support for them.
 
 config MEDIA_DIGITAL_TV_SUPPORT
-	bool
+	tristate
 	prompt "Digital TV" if MEDIA_SUPPORT_FILTER
 	default y if !MEDIA_SUPPORT_FILTER
 	help
-- 
2.18.0

Re: [PATCH] media: Kconfig: Fix DVB_CORE can't be selected as module

[Sean Young]

On Tue, Jun 08, 2021 at 06:14:51PM +0800, Lecopzer Chen wrote:
> The DVB_CORE now depends on MEDIA_DIGITAL_TV_SUPPORT and
> default MEDIA_DIGITAL_TV_SUPPORT, and this makes it can never be =m
> since the type of MEDIA_DIGITAL_TV_SUPPORT is bool.

First of all, the distributions carrry dvb_core as a module, so clearly
it possible to set DVB_CORE=m.

As far as I can see, if MEDIA_SUPPORT=m, then DVB_CORE=m. 

So it is possible.


Sean


> Change MEDIA_DIGITAL_TV_SUPPORT to tristate so it's possible to set
> DVB_CORE as =m.
> 
> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> ---
>  drivers/media/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index b07812657cee..c3baf92b4d02 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -88,7 +88,7 @@ config MEDIA_ANALOG_TV_SUPPORT
>  		will disable support for them.
>  
>  config MEDIA_DIGITAL_TV_SUPPORT
> -	bool
> +	tristate
>  	prompt "Digital TV" if MEDIA_SUPPORT_FILTER
>  	default y if !MEDIA_SUPPORT_FILTER
>  	help
> -- 
> 2.18.0

Re: [PATCH] media: Kconfig: Fix DVB_CORE can't be selected as module

[Lecopzer Chen]

> On Tue, Jun 08, 2021 at 06:14:51PM +0800, Lecopzer Chen wrote:
> > The DVB_CORE now depends on MEDIA_DIGITAL_TV_SUPPORT and
> > default MEDIA_DIGITAL_TV_SUPPORT, and this makes it can never be =m
> > since the type of MEDIA_DIGITAL_TV_SUPPORT is bool.
> 
> First of all, the distributions carrry dvb_core as a module, so clearly
> it possible to set DVB_CORE=m.
> 
> As far as I can see, if MEDIA_SUPPORT=m, then DVB_CORE=m. 
> 
> So it is possible.

Thanks for review.

After checking, It does change DVB_CORE=m if MEDIA_SUPPORT=m.

We had MEDIA_SUPPORT=y, thus misunderstood by 'default MEDIA_DIGITAL_TV_SUPPORT'.

Thanks again for figuring out this.


-Lecopzer