From: Avri Altman <avri.altman@wdc.com>
To: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, Bart Van Assche <bvanassche@acm.org>,
yongmyung lee <ymhungry.lee@samsung.com>,
Daejun Park <daejun7.park@samsung.com>,
alim.akhtar@samsung.com, asutoshd@codeaurora.org,
Zang Leigang <zangleigang@hisilicon.com>,
Avi Shchislowski <avi.shchislowski@wdc.com>,
Bean Huo <beanhuo@micron.com>,
cang@codeaurora.org, stanley.chu@mediatek.com,
Avri Altman <avri.altman@wdc.com>
Subject: [PATCH v11 01/12] scsi: ufshpb: Cache HPB Control mode on init
Date: Wed, 16 Jun 2021 14:27:49 +0300 [thread overview]
Message-ID: <20210616112800.52963-2-avri.altman@wdc.com> (raw)
In-Reply-To: <20210616112800.52963-1-avri.altman@wdc.com>
We will use it later, when we'll need to differentiate between device
and host control modes.
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Daejun Park <daejun7.park@samsung.com>
---
drivers/scsi/ufs/ufshcd.h | 2 ++
drivers/scsi/ufs/ufshpb.c | 8 +++++---
drivers/scsi/ufs/ufshpb.h | 2 ++
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 90aad8393572..0b4496c1af64 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -652,6 +652,7 @@ struct ufs_hba_variant_params {
* @hpb_disabled: flag to check if HPB is disabled
* @max_hpb_single_cmd: device reported bMAX_DATA_SIZE_FOR_SINGLE_CMD value
* @is_legacy: flag to check HPB 1.0
+ * @control_mode: either host or device
*/
struct ufshpb_dev_info {
int num_lu;
@@ -661,6 +662,7 @@ struct ufshpb_dev_info {
bool hpb_disabled;
u8 max_hpb_single_cmd;
bool is_legacy;
+ u8 control_mode;
};
#endif
diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index 69c2450ef650..61f4fcf6bc07 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -1608,6 +1608,9 @@ static void ufshpb_lu_parameter_init(struct ufs_hba *hba,
% (hpb->srgn_mem_size / HPB_ENTRY_SIZE);
hpb->pages_per_srgn = DIV_ROUND_UP(hpb->srgn_mem_size, PAGE_SIZE);
+
+ if (hpb_dev_info->control_mode == HPB_HOST_CONTROL)
+ hpb->is_hcm = true;
}
static int ufshpb_alloc_region_tbl(struct ufs_hba *hba, struct ufshpb_lu *hpb)
@@ -2301,11 +2304,10 @@ void ufshpb_get_dev_info(struct ufs_hba *hba, u8 *desc_buf)
{
struct ufshpb_dev_info *hpb_dev_info = &hba->ufshpb_dev;
int version, ret;
- u8 hpb_mode;
u32 max_hpb_single_cmd = HPB_MULTI_CHUNK_LOW;
- hpb_mode = desc_buf[DEVICE_DESC_PARAM_HPB_CONTROL];
- if (hpb_mode == HPB_HOST_CONTROL) {
+ hpb_dev_info->control_mode = desc_buf[DEVICE_DESC_PARAM_HPB_CONTROL];
+ if (hpb_dev_info->control_mode == HPB_HOST_CONTROL) {
dev_err(hba->dev, "%s: host control mode is not supported.\n",
__func__);
hpb_dev_info->hpb_disabled = true;
diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
index 1e8d6e1d909e..dc168ba08a09 100644
--- a/drivers/scsi/ufs/ufshpb.h
+++ b/drivers/scsi/ufs/ufshpb.h
@@ -228,6 +228,8 @@ struct ufshpb_lu {
u32 entries_per_srgn_shift;
u32 pages_per_srgn;
+ bool is_hcm;
+
struct ufshpb_stats stats;
struct ufshpb_params params;
--
2.25.1
next prev parent reply other threads:[~2021-06-16 11:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 11:27 [PATCH v11 00/12] Add Host control mode to HPB Avri Altman
2021-06-16 11:27 ` Avri Altman [this message]
2021-06-16 11:27 ` [PATCH v11 02/12] scsi: ufshpb: Add host control mode support to rsp_upiu Avri Altman
2021-06-16 11:27 ` [PATCH v11 03/12] scsi: ufshpb: Transform set_dirty to iterate_rgn Avri Altman
2021-06-16 11:27 ` [PATCH v11 04/12] scsi: ufshpb: Add reads counter Avri Altman
2021-06-16 11:27 ` [PATCH v11 05/12] scsi: ufshpb: Make eviction depends on region's reads Avri Altman
2021-06-16 11:27 ` [PATCH v11 06/12] scsi: ufshpb: Region inactivation in host mode Avri Altman
2021-06-16 11:27 ` [PATCH v11 07/12] scsi: ufshpb: Add hpb dev reset response Avri Altman
2021-06-16 11:27 ` [PATCH v11 08/12] scsi: ufshpb: Add "Cold" regions timer Avri Altman
2021-06-16 11:27 ` [PATCH v11 09/12] scsi: ufshpb: Limit the number of inflight map requests Avri Altman
2021-06-16 11:27 ` [PATCH v11 10/12] scsi: ufshpb: Do not send umap_all in host control mode Avri Altman
2021-06-16 11:27 ` [PATCH v11 11/12] scsi: ufshpb: Add support for " Avri Altman
2021-06-16 11:28 ` [PATCH v11 12/12] scsi: ufshpb: Make host mode parameters configurable Avri Altman
[not found] ` <CGME20210616113004epcas2p41cf111449e118965ae71aaaee1d3bd5c@epcms2p8>
2021-06-21 5:12 ` Daejun Park
2021-06-21 6:43 ` Avri Altman
[not found] ` <CGME20210616113004epcas2p41cf111449e118965ae71aaaee1d3bd5c@epcms2p4>
2021-06-21 7:25 ` Daejun Park
[not found] ` <CGME20210616112925epcas2p1267d33aee5fa552333a0503207e262f2@epcms2p1>
2021-06-21 5:17 ` [PATCH v11 08/12] scsi: ufshpb: Add "Cold" regions timer Daejun Park
2021-06-21 7:03 ` Avri Altman
[not found] ` <CGME20210616112925epcas2p1267d33aee5fa552333a0503207e262f2@epcms2p8>
2021-06-21 7:33 ` Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616112800.52963-2-avri.altman@wdc.com \
--to=avri.altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avi.shchislowski@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=ymhungry.lee@samsung.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).