From: Avri Altman <Avri.Altman@wdc.com>
To: "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Bart Van Assche <bvanassche@acm.org>,
yongmyung lee <ymhungry.lee@samsung.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
Zang Leigang <zangleigang@hisilicon.com>,
Avi Shchislowski <Avi.Shchislowski@wdc.com>,
Bean Huo <beanhuo@micron.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>
Subject: RE: [PATCH v11 08/12] scsi: ufshpb: Add "Cold" regions timer
Date: Mon, 21 Jun 2021 07:03:04 +0000 [thread overview]
Message-ID: <DM6PR04MB6575C466A26C5FEB5EEE5B6FFC0A9@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <1891546521.01624253881548.JavaMail.epsvc@epcpadp4>
> Hi Avri,
>
> >diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
> >index 39b86e8b2eee..cf719831adb3 100644
> >--- a/drivers/scsi/ufs/ufshpb.c
> >+++ b/drivers/scsi/ufs/ufshpb.c
>
> ...
>
> >+static void ufshpb_read_to_handler(struct work_struct *work)
> >+{
> >+ struct ufshpb_lu *hpb = container_of(work, struct ufshpb_lu,
> >+ ufshpb_read_to_work.work);
> >+ struct victim_select_info *lru_info = &hpb->lru_info;
> >+ struct ufshpb_region *rgn, *next_rgn;
> >+ unsigned long flags;
> >+ LIST_HEAD(expired_list);
> >+
> >+ if (test_and_set_bit(TIMEOUT_WORK_RUNNING, &hpb-
> >work_data_bits))
> >+ return;
> >+
> >+ spin_lock_irqsave(&hpb->rgn_state_lock, flags);
> >+
> >+ list_for_each_entry_safe(rgn, next_rgn, &lru_info->lh_lru_rgn,
> >+ list_lru_rgn) {
> >+ bool timedout = ktime_after(ktime_get(), rgn->read_timeout);
> >+
> >+ if (timedout) {
> >+ rgn->read_timeout_expiries--;
> >+ if (is_rgn_dirty(rgn) ||
> >+ rgn->read_timeout_expiries == 0)
> >+ list_add(&rgn->list_expired_rgn, &expired_list);
>
> Why we need additional expired_list for updating inactive information?
Since the lru list is accessed under rgn_state_lock,
and inactivation is done under rsp_list_lock,
It's just a convenient way to list all the expired regions.
> And I think "rgn->list_lru_rgn" should be deleted when it is expired.
Oh - I don't think so.
This should be done in one place only, which is cleanup_lru_info,
Which is called, in host mode, after a successful unmap request.
Thanks,
Avri
>
> >+ else
> >+ rgn->read_timeout = ktime_add_ms(ktime_get(),
> >+ READ_TO_MS);
> >+ }
> >+ }
> >+
> >+ spin_unlock_irqrestore(&hpb->rgn_state_lock, flags);
> >+
> >+ list_for_each_entry_safe(rgn, next_rgn, &expired_list,
> >+ list_expired_rgn) {
> >+ list_del_init(&rgn->list_expired_rgn);
> >+ spin_lock_irqsave(&hpb->rsp_list_lock, flags);
> >+ ufshpb_update_inactive_info(hpb, rgn->rgn_idx);
> >+ spin_unlock_irqrestore(&hpb->rsp_list_lock, flags);
> >+ }
> >+
> >+ ufshpb_kick_map_work(hpb);
> >+
> >+ clear_bit(TIMEOUT_WORK_RUNNING, &hpb->work_data_bits);
> >+
> >+ schedule_delayed_work(&hpb->ufshpb_read_to_work,
> >+ msecs_to_jiffies(POLLING_INTERVAL_MS));
> >+}
> >+
>
> Thanks,
> Daejun
next prev parent reply other threads:[~2021-06-21 7:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 11:27 [PATCH v11 00/12] Add Host control mode to HPB Avri Altman
2021-06-16 11:27 ` [PATCH v11 01/12] scsi: ufshpb: Cache HPB Control mode on init Avri Altman
2021-06-16 11:27 ` [PATCH v11 02/12] scsi: ufshpb: Add host control mode support to rsp_upiu Avri Altman
2021-06-16 11:27 ` [PATCH v11 03/12] scsi: ufshpb: Transform set_dirty to iterate_rgn Avri Altman
2021-06-16 11:27 ` [PATCH v11 04/12] scsi: ufshpb: Add reads counter Avri Altman
2021-06-16 11:27 ` [PATCH v11 05/12] scsi: ufshpb: Make eviction depends on region's reads Avri Altman
2021-06-16 11:27 ` [PATCH v11 06/12] scsi: ufshpb: Region inactivation in host mode Avri Altman
2021-06-16 11:27 ` [PATCH v11 07/12] scsi: ufshpb: Add hpb dev reset response Avri Altman
2021-06-16 11:27 ` [PATCH v11 08/12] scsi: ufshpb: Add "Cold" regions timer Avri Altman
2021-06-16 11:27 ` [PATCH v11 09/12] scsi: ufshpb: Limit the number of inflight map requests Avri Altman
2021-06-16 11:27 ` [PATCH v11 10/12] scsi: ufshpb: Do not send umap_all in host control mode Avri Altman
2021-06-16 11:27 ` [PATCH v11 11/12] scsi: ufshpb: Add support for " Avri Altman
2021-06-16 11:28 ` [PATCH v11 12/12] scsi: ufshpb: Make host mode parameters configurable Avri Altman
[not found] ` <CGME20210616113004epcas2p41cf111449e118965ae71aaaee1d3bd5c@epcms2p8>
2021-06-21 5:12 ` Daejun Park
2021-06-21 6:43 ` Avri Altman
[not found] ` <CGME20210616113004epcas2p41cf111449e118965ae71aaaee1d3bd5c@epcms2p4>
2021-06-21 7:25 ` Daejun Park
[not found] ` <CGME20210616112925epcas2p1267d33aee5fa552333a0503207e262f2@epcms2p1>
2021-06-21 5:17 ` [PATCH v11 08/12] scsi: ufshpb: Add "Cold" regions timer Daejun Park
2021-06-21 7:03 ` Avri Altman [this message]
[not found] ` <CGME20210616112925epcas2p1267d33aee5fa552333a0503207e262f2@epcms2p8>
2021-06-21 7:33 ` Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB6575C466A26C5FEB5EEE5B6FFC0A9@DM6PR04MB6575.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=Avi.Shchislowski@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=ymhungry.lee@samsung.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).