From: Daejun Park <daejun7.park@samsung.com>
To: Avri Altman <Avri.Altman@wdc.com>,
Daejun Park <daejun7.park@samsung.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Bart Van Assche <bvanassche@acm.org>,
yongmyung lee <ymhungry.lee@samsung.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
Zang Leigang <zangleigang@hisilicon.com>,
Avi Shchislowski <Avi.Shchislowski@wdc.com>,
Bean Huo <beanhuo@micron.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>
Subject: RE: RE: [PATCH v11 12/12] scsi: ufshpb: Make host mode parameters configurable
Date: Mon, 21 Jun 2021 16:25:10 +0900 [thread overview]
Message-ID: <2038148563.21624261202059.JavaMail.epsvc@epcpadp3> (raw)
In-Reply-To: <DM6PR04MB6575BF2A411BDDF7832A844AFC0A9@DM6PR04MB6575.namprd04.prod.outlook.com>
Hi Avri,
> > Hi Avri,
> >
> > >diff --git a/Documentation/ABI/testing/sysfs-driver-ufs
> > b/Documentation/ABI/testing/sysfs-driver-ufs
> > >index d001f008312b..b10cecb286df 100644
> > >--- a/Documentation/ABI/testing/sysfs-driver-ufs
> > >+++ b/Documentation/ABI/testing/sysfs-driver-ufs
> > >@@ -1449,7 +1449,7 @@ Description: This entry shows the maximum
> > HPB data size for using single HPB
> > >
> > > The file is read only.
> > >
> > >-What: /sys/bus/platform/drivers/ufshcd/*/flags/wb_enable
> > >+What: /sys/bus/platform/drivers/ufshcd/*/flags/hpb_enable
> >
> > This part seems to be the problem with my patch. I will correct it.
> Maybe if just another spin is really required?
OK, I will fix it in next re-spin and update the patches.
> >
> > ...
> >
> > >diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
> > >index ab66919f4065..6f2ded8c63b0 100644
> > >--- a/drivers/scsi/ufs/ufshpb.c
> > >+++ b/drivers/scsi/ufs/ufshpb.c
> >
> > ...
> >
> > >@@ -1697,6 +1704,7 @@ static void
> > ufshpb_normalization_work_handler(struct work_struct *work)
> > > struct ufshpb_lu *hpb = container_of(work, struct ufshpb_lu,
> > > ufshpb_normalization_work);
> > > int rgn_idx;
> > >+ u8 factor = hpb->params.normalization_factor;
> > >
> > > for (rgn_idx = 0; rgn_idx < hpb->rgns_per_lu; rgn_idx++) {
> > > struct ufshpb_region *rgn = hpb->rgn_tbl + rgn_idx;
> > >@@ -1707,7 +1715,7 @@ static void
> > ufshpb_normalization_work_handler(struct work_struct *work)
> > > for (srgn_idx = 0; srgn_idx < hpb->srgns_per_rgn; srgn_idx++) {
> > > struct ufshpb_subregion *srgn = rgn->srgn_tbl + srgn_idx;
> > >
> > >- srgn->reads >>= 1;
> > >+ srgn->reads >>= factor;
> > > rgn->reads += srgn->reads;
> >
> > How about changing it to "rgn->read >>=factor" and placing it outside the
> > for statement?
> I think zeroing rgn->reads before the loop and then rgn->reads += srgn->reads
> Making it clear, even as far as doc, that the region reads is the sum over its subregions.
OK, I understand your intention.
Thanks,
Daejun
>
> Anyway, this code was introduced in patch 4, so I will fix it there only if you find it really necessary.
>
> Thanks,
> Avri
>
>
>
next prev parent reply other threads:[~2021-06-21 7:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 11:27 [PATCH v11 00/12] Add Host control mode to HPB Avri Altman
2021-06-16 11:27 ` [PATCH v11 01/12] scsi: ufshpb: Cache HPB Control mode on init Avri Altman
2021-06-16 11:27 ` [PATCH v11 02/12] scsi: ufshpb: Add host control mode support to rsp_upiu Avri Altman
2021-06-16 11:27 ` [PATCH v11 03/12] scsi: ufshpb: Transform set_dirty to iterate_rgn Avri Altman
2021-06-16 11:27 ` [PATCH v11 04/12] scsi: ufshpb: Add reads counter Avri Altman
2021-06-16 11:27 ` [PATCH v11 05/12] scsi: ufshpb: Make eviction depends on region's reads Avri Altman
2021-06-16 11:27 ` [PATCH v11 06/12] scsi: ufshpb: Region inactivation in host mode Avri Altman
2021-06-16 11:27 ` [PATCH v11 07/12] scsi: ufshpb: Add hpb dev reset response Avri Altman
2021-06-16 11:27 ` [PATCH v11 08/12] scsi: ufshpb: Add "Cold" regions timer Avri Altman
2021-06-16 11:27 ` [PATCH v11 09/12] scsi: ufshpb: Limit the number of inflight map requests Avri Altman
2021-06-16 11:27 ` [PATCH v11 10/12] scsi: ufshpb: Do not send umap_all in host control mode Avri Altman
2021-06-16 11:27 ` [PATCH v11 11/12] scsi: ufshpb: Add support for " Avri Altman
2021-06-16 11:28 ` [PATCH v11 12/12] scsi: ufshpb: Make host mode parameters configurable Avri Altman
[not found] ` <CGME20210616113004epcas2p41cf111449e118965ae71aaaee1d3bd5c@epcms2p8>
2021-06-21 5:12 ` Daejun Park
2021-06-21 6:43 ` Avri Altman
[not found] ` <CGME20210616113004epcas2p41cf111449e118965ae71aaaee1d3bd5c@epcms2p4>
2021-06-21 7:25 ` Daejun Park [this message]
[not found] ` <CGME20210616112925epcas2p1267d33aee5fa552333a0503207e262f2@epcms2p1>
2021-06-21 5:17 ` [PATCH v11 08/12] scsi: ufshpb: Add "Cold" regions timer Daejun Park
2021-06-21 7:03 ` Avri Altman
[not found] ` <CGME20210616112925epcas2p1267d33aee5fa552333a0503207e262f2@epcms2p8>
2021-06-21 7:33 ` Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2038148563.21624261202059.JavaMail.epsvc@epcpadp3 \
--to=daejun7.park@samsung.com \
--cc=Avi.Shchislowski@wdc.com \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=ymhungry.lee@samsung.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).