* [PATCH net-next] net/mlx5: Use cpumask_available() in mlx5_eq_create_generic()
@ 2021-06-18 0:03 Nathan Chancellor
2021-06-21 8:53 ` Leon Romanovsky
2021-06-22 21:39 ` Saeed Mahameed
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Chancellor @ 2021-06-18 0:03 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, David S. Miller, Jakub Kicinski
Cc: Nick Desaulniers, netdev, linux-rdma, linux-kernel,
clang-built-linux, Nathan Chancellor
When CONFIG_CPUMASK_OFFSTACK is unset, cpumask_var_t is not a pointer
but a single element array, meaning its address in a structure cannot be
NULL as long as it is not the first element, which it is not. This
results in a clang warning:
drivers/net/ethernet/mellanox/mlx5/core/eq.c:715:14: warning: address of
array 'param->affinity' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (!param->affinity)
~~~~~~~~^~~~~~~~
1 warning generated.
The helper cpumask_available was added in commit f7e30f01a9e2 ("cpumask:
Add helper cpumask_available()") to handle situations like this so use
it to keep the meaning of the code the same while resolving the warning.
Fixes: e4e3f24b822f ("net/mlx5: Provide cpumask at EQ creation phase")
Link: https://github.com/ClangBuiltLinux/linux/issues/1400
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/net/ethernet/mellanox/mlx5/core/eq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eq.c b/drivers/net/ethernet/mellanox/mlx5/core/eq.c
index 7e5b3826eae5..d3356771e628 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eq.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eq.c
@@ -710,7 +710,7 @@ mlx5_eq_create_generic(struct mlx5_core_dev *dev,
struct mlx5_eq *eq = kvzalloc(sizeof(*eq), GFP_KERNEL);
int err;
- if (!param->affinity)
+ if (!cpumask_available(param->affinity))
return ERR_PTR(-EINVAL);
if (!eq)
base-commit: 8fe088bd4fd12f4c8899b51d5bc3daad98767d49
--
2.32.0.93.g670b81a890
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/mlx5: Use cpumask_available() in mlx5_eq_create_generic()
2021-06-18 0:03 [PATCH net-next] net/mlx5: Use cpumask_available() in mlx5_eq_create_generic() Nathan Chancellor
@ 2021-06-21 8:53 ` Leon Romanovsky
2021-06-22 21:39 ` Saeed Mahameed
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2021-06-21 8:53 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Saeed Mahameed, David S. Miller, Jakub Kicinski,
Nick Desaulniers, netdev, linux-rdma, linux-kernel,
clang-built-linux
On Thu, Jun 17, 2021 at 05:03:59PM -0700, Nathan Chancellor wrote:
> When CONFIG_CPUMASK_OFFSTACK is unset, cpumask_var_t is not a pointer
> but a single element array, meaning its address in a structure cannot be
> NULL as long as it is not the first element, which it is not. This
> results in a clang warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/eq.c:715:14: warning: address of
> array 'param->affinity' will always evaluate to 'true'
> [-Wpointer-bool-conversion]
> if (!param->affinity)
> ~~~~~~~~^~~~~~~~
> 1 warning generated.
>
> The helper cpumask_available was added in commit f7e30f01a9e2 ("cpumask:
> Add helper cpumask_available()") to handle situations like this so use
> it to keep the meaning of the code the same while resolving the warning.
>
> Fixes: e4e3f24b822f ("net/mlx5: Provide cpumask at EQ creation phase")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1400
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/eq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/mlx5: Use cpumask_available() in mlx5_eq_create_generic()
2021-06-18 0:03 [PATCH net-next] net/mlx5: Use cpumask_available() in mlx5_eq_create_generic() Nathan Chancellor
2021-06-21 8:53 ` Leon Romanovsky
@ 2021-06-22 21:39 ` Saeed Mahameed
1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2021-06-22 21:39 UTC (permalink / raw)
To: Nathan Chancellor, Leon Romanovsky, David S. Miller, Jakub Kicinski
Cc: Nick Desaulniers, netdev, linux-rdma, linux-kernel, clang-built-linux
On Thu, 2021-06-17 at 17:03 -0700, Nathan Chancellor wrote:
> When CONFIG_CPUMASK_OFFSTACK is unset, cpumask_var_t is not a pointer
> but a single element array, meaning its address in a structure cannot
> be
> NULL as long as it is not the first element, which it is not. This
> results in a clang warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/eq.c:715:14: warning: address
> of
> array 'param->affinity' will always evaluate to 'true'
> [-Wpointer-bool-conversion]
> if (!param->affinity)
> ~~~~~~~~^~~~~~~~
> 1 warning generated.
>
> The helper cpumask_available was added in commit f7e30f01a9e2
> ("cpumask:
> Add helper cpumask_available()") to handle situations like this so use
> it to keep the meaning of the code the same while resolving the
> warning.
>
> Fixes: e4e3f24b822f ("net/mlx5: Provide cpumask at EQ creation phase")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1400
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
Applied to net-next-mlx5
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-22 21:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 0:03 [PATCH net-next] net/mlx5: Use cpumask_available() in mlx5_eq_create_generic() Nathan Chancellor
2021-06-21 8:53 ` Leon Romanovsky
2021-06-22 21:39 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).