* [PATCH -next] clk: lmk04832: fix return value check in lmk04832_probe()
@ 2021-06-30 2:03 Wang Hai
2021-06-30 16:03 ` Liam Beguin
2021-06-30 18:18 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Wang Hai @ 2021-06-30 2:03 UTC (permalink / raw)
To: mturquette, sboyd, lvb; +Cc: linux-clk, linux-kernel
In case of error, the function devm_kzalloc() and devm_kcalloc() return
NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.
Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/clk/clk-lmk04832.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c
index 0cd76e626c3..66ad5cbe702 100644
--- a/drivers/clk/clk-lmk04832.c
+++ b/drivers/clk/clk-lmk04832.c
@@ -1425,23 +1425,23 @@ static int lmk04832_probe(struct spi_device *spi)
lmk->dclk = devm_kcalloc(lmk->dev, info->num_channels >> 1,
sizeof(struct lmk_dclk), GFP_KERNEL);
- if (IS_ERR(lmk->dclk)) {
- ret = PTR_ERR(lmk->dclk);
+ if (!lmk->dclk) {
+ ret = -ENOMEM;
goto err_disable_oscin;
}
lmk->clkout = devm_kcalloc(lmk->dev, info->num_channels,
sizeof(*lmk->clkout), GFP_KERNEL);
- if (IS_ERR(lmk->clkout)) {
- ret = PTR_ERR(lmk->clkout);
+ if (!lmk->clkout) {
+ ret = -ENOMEM;
goto err_disable_oscin;
}
lmk->clk_data = devm_kzalloc(lmk->dev, struct_size(lmk->clk_data, hws,
info->num_channels),
GFP_KERNEL);
- if (IS_ERR(lmk->clk_data)) {
- ret = PTR_ERR(lmk->clk_data);
+ if (!lmk->clk_data) {
+ ret = -ENOMEM;
goto err_disable_oscin;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH -next] clk: lmk04832: fix return value check in lmk04832_probe()
2021-06-30 2:03 [PATCH -next] clk: lmk04832: fix return value check in lmk04832_probe() Wang Hai
@ 2021-06-30 16:03 ` Liam Beguin
2021-06-30 18:18 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Liam Beguin @ 2021-06-30 16:03 UTC (permalink / raw)
To: Wang Hai, mturquette, sboyd; +Cc: linux-clk, linux-kernel
> -----Original Message-----
> From: Wang Hai <wanghai38@huawei.com>
> Sent: June 29, 2021 10:03 PM
> To: mturquette@baylibre.com; sboyd@kernel.org; Liam Beguin
> <lvb@xiphos.com>
> Cc: linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH -next] clk: lmk04832: fix return value check in
> lmk04832_probe()
>
> In case of error, the function devm_kzalloc() and devm_kcalloc() return
> NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
>
> Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
Reviewed-by: Liam Beguin <lvb@xiphos.com>
> ---
> drivers/clk/clk-lmk04832.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c
> index 0cd76e626c3..66ad5cbe702 100644
> --- a/drivers/clk/clk-lmk04832.c
> +++ b/drivers/clk/clk-lmk04832.c
> @@ -1425,23 +1425,23 @@ static int lmk04832_probe(struct spi_device
> *spi)
>
> lmk->dclk = devm_kcalloc(lmk->dev, info->num_channels >> 1,
> sizeof(struct lmk_dclk), GFP_KERNEL);
> - if (IS_ERR(lmk->dclk)) {
> - ret = PTR_ERR(lmk->dclk);
> + if (!lmk->dclk) {
> + ret = -ENOMEM;
> goto err_disable_oscin;
> }
>
> lmk->clkout = devm_kcalloc(lmk->dev, info->num_channels,
> sizeof(*lmk->clkout), GFP_KERNEL);
> - if (IS_ERR(lmk->clkout)) {
> - ret = PTR_ERR(lmk->clkout);
> + if (!lmk->clkout) {
> + ret = -ENOMEM;
> goto err_disable_oscin;
> }
>
> lmk->clk_data = devm_kzalloc(lmk->dev, struct_size(lmk->clk_data,
> hws,
> info-
> >num_channels),
> GFP_KERNEL);
> - if (IS_ERR(lmk->clk_data)) {
> - ret = PTR_ERR(lmk->clk_data);
> + if (!lmk->clk_data) {
> + ret = -ENOMEM;
> goto err_disable_oscin;
> }
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] clk: lmk04832: fix return value check in lmk04832_probe()
2021-06-30 2:03 [PATCH -next] clk: lmk04832: fix return value check in lmk04832_probe() Wang Hai
2021-06-30 16:03 ` Liam Beguin
@ 2021-06-30 18:18 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2021-06-30 18:18 UTC (permalink / raw)
To: Wang Hai, lvb, mturquette; +Cc: linux-clk, linux-kernel
Quoting Wang Hai (2021-06-29 19:03:22)
> In case of error, the function devm_kzalloc() and devm_kcalloc() return
> NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
>
> Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-30 18:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-30 2:03 [PATCH -next] clk: lmk04832: fix return value check in lmk04832_probe() Wang Hai
2021-06-30 16:03 ` Liam Beguin
2021-06-30 18:18 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).