From: Jakub Kicinski <kuba@kernel.org>
To: <alexandru.tachici@analog.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <robh+dt@kernel.org>,
<andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>
Subject: Re: [PATCH v2 4/7] net: phy: adin1100: Add ethtool get_stats support
Date: Mon, 12 Jul 2021 11:41:14 -0700 [thread overview]
Message-ID: <20210712114114.35d7771b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210712130631.38153-5-alexandru.tachici@analog.com>
On Mon, 12 Jul 2021 16:06:28 +0300 alexandru.tachici@analog.com wrote:
> +static const struct adin_hw_stat adin_hw_stats[] = {
> + { "total_frames_error_count", 0x8008 },
> + { "total_frames_count", 0x8009, 0x800A }, /* hi, lo */
> + { "length_error_frames_count", 0x800B },
> + { "alignment_error_frames_count", 0x800C },
> + { "symbol_error_count", 0x800D },
> + { "oversized_frames_count", 0x800E },
> + { "undersized_frames_count", 0x800F },
> + { "odd_nibble_frames_count", 0x8010 },
> + { "odd_preamble_packet_count", 0x8011 },
> + { "false_carrier_events_count", 0x8013 },
> +};
Since this phy seems to implement a lot MAC stats would it make sense
to plumb thru the new ethtool API for PHYs (ethtool_eth_mac_stats etc.)
rather than let the same string proliferation problem spring up in
another section of the code?
next prev parent reply other threads:[~2021-07-12 18:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 13:06 [PATCH v2 0/7] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY alexandru.tachici
2021-07-12 13:06 ` [PATCH v2 1/7] ethtool: Add 10base-T1L link mode entries alexandru.tachici
2021-07-13 16:50 ` Andrew Lunn
2021-07-27 5:56 ` Oleksij Rempel
2021-07-12 13:06 ` [PATCH v2 2/7] ethtool: Add 10base-T1L voltage levels " alexandru.tachici
2021-07-12 13:06 ` [PATCH v2 3/7] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY alexandru.tachici
2021-07-13 16:58 ` Andrew Lunn
2021-07-16 21:24 ` ADIN1100 alexandru.tachici
2021-07-23 17:20 ` ADIN1100 Oleksij Rempel
2021-07-27 6:31 ` [PATCH v2 3/7] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY Oleksij Rempel
2021-07-27 6:47 ` Oleksij Rempel
2021-07-27 16:36 ` Andrew Lunn
2021-07-12 13:06 ` [PATCH v2 4/7] net: phy: adin1100: Add ethtool get_stats support alexandru.tachici
2021-07-12 18:41 ` Jakub Kicinski [this message]
2021-07-12 13:06 ` [PATCH v2 5/7] net: phy: adin1100: Add ethtool master-slave support alexandru.tachici
2021-07-13 17:53 ` Andrew Lunn
2021-07-12 13:06 ` [PATCH v2 6/7] net: phy: adin1100: Add SQI support alexandru.tachici
2021-07-13 17:55 ` Andrew Lunn
2021-07-12 13:06 ` [PATCH v2 7/7] dt-bindings: adin1100: Add binding for ADIN1100 Ethernet PHY alexandru.tachici
2021-07-12 14:12 ` Rob Herring
2021-07-12 17:46 ` Rob Herring
2021-07-27 5:53 ` Oleksij Rempel
2021-07-28 17:23 ` Rob Herring
2021-07-29 5:02 ` Oleksij Rempel
2021-07-12 13:33 ` [PATCH v2 0/7] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY Russell King (Oracle)
2021-07-23 17:32 ` Oleksij Rempel
2021-08-03 9:47 ` alexandru.tachici
2021-08-03 11:59 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712114114.35d7771b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=alexandru.tachici@analog.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).